Uh oh!
There was an error while loading. Please reload this page.
[CON-196] Add Prometheus and Grafana to Protocol repo - #3225
Merged
Conversation
joaquincasares
approved these changes
Jun 9, 2022
joaquincasares
left a comment
Contributor
There was a problem hiding this comment.
Minor request, can you pull the the latest grafana/dashboards since those have a small change?
Thanks!!
SidSethi
approved these changes
Jun 9, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SidSethi
reviewed
Jun 9, 2022
| grafana/bearer.env | ||
| #Vendored code below | ||
| #------------------- |
Contributor
There was a problem hiding this comment.
add link to the vendored code as well, otherwise anyone reading this won't know where it was vendored from haha
ContributorAuthor
There was a problem hiding this comment.
That's be an @joaquincasares question - I don't think started that gitignore
Contributor
There was a problem hiding this comment.
wdym, aren't we talking about gitignore
but yeah w/e, lets handle this separately - not a merge blocker
Contributor
There was a problem hiding this comment.
my b - i forgot that you just copied files over
SidSethi
approved these changes
Jun 9, 2022
SidSethi
left a comment
Contributor
There was a problem hiding this comment.
great stuff - 1 comment but can address and merge w/o re-review
sliptype pushed a commit
that referenced
this pull request
Sep 10, 2023
sliptype pushed a commit
that referenced
this pull request
Sep 10, 2023
[ffbd520] [C-2511] Don't delay mutuals fetch (#3260) Andrew Mendelsohn [c196de8] [C-2516] Always filter followed users from suggested (#3259) Andrew Mendelsohn [5a4df3e] [C-2514] Fix empty related artists when logged out (web) (#3258) Andrew Mendelsohn [9127806] [C-2484] Fix edit playlist actions (#3255) Kyle Shanks [f668c58] [PAY-1162] Update rendering overflow for some "Supporting" lists (#3256) Randy Schott [5dfe39b] fix lint (#3257) Alec Savvy [b171916] [PAY-1166] Make SDK respect DN override (client-side) (#3246) Reed [1a977b5] PLAT-725: fix browser push (#3252) Alec Savvy [fa9be2d] Fix react-router issues (#3254) Dylan Jeffers [7daa2a8] C-2502: extend store history (#3253) Alec Savvy [b0379b1] [C-2501] Use proxy-wormhole libs (#3250) Dylan Jeffers [b56a71a] Update TOS (#3251) Raymond Jacobson [3142d23] Run CI flows when certain files change (#3248) Sebastian Klingler [77805ca] Fix signout test (#3249) Sebastian Klingler [aae6daf] [C-2493] separate state for suggested follows vs related artists (#3247) Andrew Mendelsohn [115e084] [C-574] Add migration path to @react-spring/web (#3245) Dylan Jeffers [0372252] Fix React errors about `key` property when rendering tables (#3244) Randy Schott [3b03e2e] [C-2495] Refactor left-nav to typescript, update naming, improve perf (#3243) Dylan Jeffers [21feb7e] [C-2486] Add Related Artists on Profile (mobile) (#3240) Andrew Mendelsohn [e3180f6] PLAT-725: browser push misconfigured (#3242) Alec Savvy [e90deb5] [C-2494] Refactor drag-drop to typescript + performance (#3237) Dylan Jeffers [9d3cac4] Remove service selection modal (#3241) Theo Ilie [587abd4] Fix call to player.getPosition (#3239) Andrew Mendelsohn [6e85c32] Bump mobile version (#3238) Sebastian Klingler [63fdba2] [PAY-937] Fix empty state for transactions table (#3234) Randy Schott [7d81ff3] [C-2338][C-2487][C-2489] Add Related Artists on Profile (web) (#3230) Andrew Mendelsohn [7a1b283] Fix dev-mode hot-key modals (#3236) Dylan Jeffers [bb653f6] [C-2440] Remove useThemedStyles (#3232) Dylan Jeffers [8ea7397] Fix lint in common (#3235) Saliou Diallo [ba7f260] [PAY-1140] Prevent spacebar from attempting to play inaccessible tracks (#3227) Saliou Diallo [b7ea4d9] Improve oauth errors/logging (#3233) Raymond Jacobson [80d3609] [PAY-986][PAY-1087][PAY-1091] Fix a bunch of UI issues (#3211) Saliou Diallo [8652e91] [C-2219] Hide desktop modals until needed (#3231) Dylan Jeffers [c026885] [C-2429] Remove hls (#3225) Dylan Jeffers [9a0687d] [C-2448] Fix common dependencies and lint (#3224) Dylan Jeffers [fbabbbf] Revert "[PAY-827][PAY-1154] Use DN stream endpoint for track download and offline mode (#3202) (#3228) Saliou Diallo [1500b7f] Only mark notifications as viewed when notif panel is open (#3229) Dylan Jeffers [1c9df53] [PAY-1128] Update logic for showing "earn/claim $AUDIO" pill (#3218) Randy Schott
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to make Prometheus and Grafana accessible and visible to other services.
Prometheus and Grafana currently live in the
load-test-toolsrepo which makes it less than ideal to work with especially with the new work being done on adding Prometheus being added to Content Node and Network Monitoring.Sister PR:
Tests
n/a
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
n/a