Skip to content

[CON-147] Create Network Monitoring project in protocol repo - #3237

Merged
jonaylor89 merged 7 commits into
masterfrom
jn-network-monitoring
Jun 16, 2022
Merged

[CON-147] Create Network Monitoring project in protocol repo#3237
jonaylor89 merged 7 commits into
masterfrom
jn-network-monitoring

Conversation

@jonaylor89

@jonaylor89jonaylor89 commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

Description

The infamous network monitoring PR

This PR lift-and-shifts the network monitoring project in the protocol repo.

Tests

n/a

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

n/a

@jonaylor89jonaylor89 added the discovery-node Discovery Node (previously known as Discovery Provider) label Jun 10, 2022
@jonaylor89
jonaylor89 requested a review from SidSethiJune 10, 2022 23:15
@jonaylor89
jonaylor89 marked this pull request as ready for review June 12, 2022 21:25
SidSethi
SidSethi reviewed Jun 14, 2022
View reviewed changes

@SidSethiSidSethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks amazing, i love how everything is separate, and the src/index.js makes me so happy

left a bunch of comments on the code (the logic itself looks great), but lets not handle any of that until we have metrics in grafana

general themes of my comments

  • remove inline sql queries where possible
  • better variable/function naming
  • more comments/docs
  • increased separation of concerns at all layers, similar to src/index.ts

really great work on all of this 🚀

Comment threaddiscovery-provider/plugins/network-monitoring/.gitignore
Comment threaddiscovery-provider/plugins/network-monitoring/docker-compose.yaml Outdated
Comment threaddiscovery-provider/plugins/network-monitoring/docker-compose.yaml
Comment threaddiscovery-provider/plugins/network-monitoring/docker-compose.yaml
Comment threaddiscovery-provider/plugins/network-monitoring/docker-compose.yaml
Comment threaddiscovery-provider/plugins/network-monitoring/src/db/models/user.ts
Comment threaddiscovery-provider/plugins/network-monitoring/src/db/sql/create_tables.sql
Comment threaddiscovery-provider/plugins/network-monitoring/src/db/queries.ts
Comment threaddiscovery-provider/plugins/network-monitoring/src/discovery.ts Outdated
Comment threaddiscovery-provider/plugins/network-monitoring/src/content.ts
@jonaylor89
jonaylor89 requested a review from SidSethiJune 15, 2022 18:02
SidSethi
SidSethi approved these changes Jun 15, 2022
View reviewed changes

@SidSethiSidSethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge, just reminder to document remaining work to linear

Comment threaddiscovery-provider/plugins/network-monitoring/src/db/sql/README.md Outdated
Comment threaddiscovery-provider/plugins/network-monitoring/src/metrics/queries.ts
@jonaylor89
jonaylor89 merged commit 415f342 into masterJun 16, 2022
@jonaylor89
jonaylor89 deleted the jn-network-monitoring branch June 16, 2022 02:05
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@dylanjeffers
[C-2494] Refactor drag-drop to typescript + performance (#3237)
a616ed3
sliptype pushed a commit that referenced this pull request Sep 10, 2023
audius-infra
v1.5.21
fa41720
[ffbd520] [C-2511] Don't delay mutuals fetch (#3260) Andrew Mendelsohn
[c196de8] [C-2516] Always filter followed users from suggested (#3259) Andrew Mendelsohn
[5a4df3e] [C-2514] Fix empty related artists when logged out (web) (#3258) Andrew Mendelsohn
[9127806] [C-2484] Fix edit playlist actions (#3255) Kyle Shanks
[f668c58] [PAY-1162] Update rendering overflow for some "Supporting" lists (#3256) Randy Schott
[5dfe39b] fix lint (#3257) Alec Savvy
[b171916] [PAY-1166] Make SDK respect DN override (client-side) (#3246) Reed
[1a977b5] PLAT-725: fix browser push (#3252) Alec Savvy
[fa9be2d] Fix react-router issues (#3254) Dylan Jeffers
[7daa2a8] C-2502: extend store history (#3253) Alec Savvy
[b0379b1] [C-2501] Use proxy-wormhole libs (#3250) Dylan Jeffers
[b56a71a] Update TOS (#3251) Raymond Jacobson
[3142d23] Run CI flows when certain files change (#3248) Sebastian Klingler
[77805ca] Fix signout test (#3249) Sebastian Klingler
[aae6daf] [C-2493] separate state for suggested follows vs related artists (#3247) Andrew Mendelsohn
[115e084] [C-574] Add migration path to @react-spring/web (#3245) Dylan Jeffers
[0372252] Fix React errors about `key` property when rendering tables (#3244) Randy Schott
[3b03e2e] [C-2495] Refactor left-nav to typescript, update naming, improve perf (#3243) Dylan Jeffers
[21feb7e] [C-2486] Add Related Artists on Profile (mobile) (#3240) Andrew Mendelsohn
[e3180f6] PLAT-725: browser push misconfigured (#3242) Alec Savvy
[e90deb5] [C-2494] Refactor drag-drop to typescript + performance (#3237) Dylan Jeffers
[9d3cac4] Remove service selection modal (#3241) Theo Ilie
[587abd4] Fix call to player.getPosition (#3239) Andrew Mendelsohn
[6e85c32] Bump mobile version (#3238) Sebastian Klingler
[63fdba2] [PAY-937] Fix empty state for transactions table (#3234) Randy Schott
[7d81ff3] [C-2338][C-2487][C-2489] Add Related Artists on Profile (web) (#3230) Andrew Mendelsohn
[7a1b283] Fix dev-mode hot-key modals (#3236) Dylan Jeffers
[bb653f6] [C-2440] Remove useThemedStyles (#3232) Dylan Jeffers
[8ea7397] Fix lint in common (#3235) Saliou Diallo
[ba7f260] [PAY-1140] Prevent spacebar from attempting to play inaccessible tracks (#3227) Saliou Diallo
[b7ea4d9] Improve oauth errors/logging (#3233) Raymond Jacobson
[80d3609] [PAY-986][PAY-1087][PAY-1091] Fix a bunch of UI issues (#3211) Saliou Diallo
[8652e91] [C-2219] Hide desktop modals until needed (#3231) Dylan Jeffers
[c026885] [C-2429] Remove hls (#3225) Dylan Jeffers
[9a0687d] [C-2448] Fix common dependencies and lint (#3224) Dylan Jeffers
[fbabbbf] Revert "[PAY-827][PAY-1154] Use DN stream endpoint for track download and offline mode (#3202) (#3228) Saliou Diallo
[1500b7f] Only mark notifications as viewed when notif panel is open (#3229) Dylan Jeffers
[1c9df53] [PAY-1128] Update logic for showing "earn/claim $AUDIO" pill (#3218) Randy Schott
@AudiusProjectAudiusProject deleted a comment from linearBotSep 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SidSethiSidSethiSidSethi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@theoilietheoilie

@vicky-gvicky-g

Labels

discovery-nodeDiscovery Node (previously known as Discovery Provider)size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonaylor89@SidSethi@theoilie@vicky-g