Uh oh!
There was an error while loading. Please reload this page.
Connect account UI + OAuth functionality, top bar changes, add banner C-3496 - #6929
Merged
Conversation
nicoback2
changed the base branch from
main
to
feature-dashboard-improvementsDecember 13, 2023 22:09
nicoback2
requested review from
a team and sliptype
and removed request for
a teamDecember 13, 2023 22:09
dylanjeffers
approved these changes
Dec 15, 2023
| }) | ||
| } | ||
| const loginWithAudius = () => { |
Contributor
There was a problem hiding this comment.
if the user clicks before oauth inits, does it still work?
| let audiusSdk = null | ||
| const initAudiusSdk = () => { |
Contributor
There was a problem hiding this comment.
should we just avoid the function call and just do
const audiusSdk = sdk({...})
export {audiusSdk}
| } | ||
| type BannerProps = PropsWithChildren<{}> | ||
| const Banner = ({ children }: BannerProps) => { |
Contributor
There was a problem hiding this comment.
this is cool, though honestly not sure if we need sub-components just for a container?
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
nicoback2force-pushed
the
nkang--connect-ui
branch
from
December 22, 2023 20:19
b7248b7 to
3e009dbComparenicoback2
changed the base branch from
feature-dashboard-improvements
to
mainDecember 22, 2023 20:25
nicoback2
changed the base branch from
main
to
feature-dashboard-improvementsDecember 22, 2023 20:25
nicoback2force-pushed
the
nkang--connect-ui
branch
from
December 22, 2023 20:53
3e009db to
c11390bCompareCo-authored-by: Nikki Kang <kangaroo233@gmail.com>
[a6c645a] Add chargebackProtectionData (#7021) Raymond Jacobson [b71a0d4] Simple upload UI (#7023) Michelle Brier [389724e] Make CI sed more specific (#7024) Theo Ilie [02a7126] Add back protocol dashboard improvements (#7022) Theo Ilie [5652852] [Discovery] Discovery lint fix (#7020) nicoback2 [b48bb0d] [Discovery] Fix response marshalling - Dashboard Wallet Users API (#7019) nicoback2 [85f9b7f] Revert protocol dashboard changes (#7017) Theo Ilie [a8f0282] Hotfix adding missing scripts to Dockerfile (#7015) Theo Ilie [b759e93] Bump version to 0.6.8 audius-infra [179ba8a] [SDK] Add dashboard wallet users API to SDK [C-3530] (#6971) nicoback2 [3c92e3d] [PROTO-1546] Limit mediorum ffmpeg CPU and filter ffmpeg logs (#6988) Theo Ilie [d494ced] [Discovery] Add bulk get dashboard wallet users to Discovery Api [C-3532] (#6984) nicoback2 [108a688] Build protocol dashboard 84x smaller in CI instead of at runtime (#7014) Theo Ilie [9e337d5] Add ddex to audius-compose and improve its build (#7013) Theo Ilie [d364016] Lower thresholds for prune and full prune on self-hosted ci machines (#7012) Danny [0b47999] [PAY-1872] Add tests for USDC user bank indexer (#7009) Randy Schott [787f68c] [PAY-2315] Explicitly cancel transaction when closing coinflow drawer (#7011) Randy Schott [6ea1880] Index EM transactions for dashboard wallet users C-3529 (#6969) nicoback2 [276540b] Temporarily remove ddex image as required for releases (#7008) Theo Ilie [0360ee3] [C-3539] Add harmony IconButton (#7004) Dylan Jeffers [a002560] Fix sdk Storage retry logic (#7006) Sebastian Klingler [500f9a7] Publish sdk and fix publish flow (#6995) Sebastian Klingler [759c52d]⚠️ [C-3538] Remove moment from common (#6992) Raymond Jacobson [12cfb9d] Bump version to 0.6.7 audius-infra [3448af6] [C-3527] Add native artist previews (#6989) Dylan Jeffers [4701dec] [PROTO-1524] Invalidate cache on refresh (#6996) Dylan Jeffers [a9c2f78] Move ddex UI (#6990) Michelle Brier [b67d52a] As/fix profiles not loading (#6997) alecsavvy [7d2dd60] Ignore legacy images in indexing (#7003) Isaac Solo [9eefe64] Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002) Marcus Pasell [97e8ae3] Disable triggers while migration runs (#7001) Theo Ilie [a542274] Add Solana Support to SDK with sdk.users.sendTip() (#6891) Marcus Pasell [f2a2ce1] fix es-indexer for local dev (#6999) Steve Perkins [b2c900e] Add lock to tracks table for migration (#6998) Theo Ilie [9e3dd6e] [PROTO-1500] Use created_at for release_date by default (#6982) Theo Ilie [bd88bfe] [C-3427] Add BaseButton to mobile harmony (#6968) Kyle Shanks [aa3d301] Publish @audius/spl (#6991) Sebastian Klingler [e3bb2f3] Bump version to 0.6.6 audius-infra [2109fdf] Lint fixes for edit album (#6977) Andrew Mendelsohn [a46ca96] fix non responsive node attestation (#6966) alecsavvy [8967859] Fix sdk write w/ vite and fix npm publish (#6986) Sebastian Klingler [2195a03] Schedule release follow ons (#6985) Isaac Solo [7f0f242] [C-3528] Add harmony animated icons (#6981) Dylan Jeffers [4582d43] [C-3494] Add shadow to icon (#6980) Dylan Jeffers [a9d2924] [C-3447] Add select-artist native screen (#6955) Dylan Jeffers [b6c7aae] bump multiformats version (#6983) alecsavvy [17043de] Bump version to 0.6.5 audius-infra [2d72cef] [C-3519] Fix async absolute lottie imports (#6976) Dylan Jeffers [7f78919] [C-3535] Fix harmony icon types (#6979) Dylan Jeffers [e045809] Update key for tos banner version (#6978) Raymond Jacobson [c9a3e7c] Update ToS (#6973) Raymond Jacobson [7667fee] [PAY-2296] Adds additional metadata to Coinflow purchases (#6975) Randy Schott [cfb3c91] [C-3518] Fix user-list issues, sign-up navigation issue (#6974) Dylan Jeffers [c1d0e85] Quick fix to use release_date for feed ordering (#6972) Steve Perkins [435a464] [PAY-2293][PAY-2292] Add coinflow updates (#6967) Raymond Jacobson [4d7f23a] Revert "[PAY-2276] Selectable amounts for coinflow add funds web (#69… (#6970) Raymond Jacobson [9274a11] [C-3511] Add Track to Album (mobile + mobile web) (#6962) Andrew Mendelsohn [a9a0001] Bump version to 0.6.4 audius-infra [add67ba] Default to Stripe (#6963) Marcus Pasell
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: isaac <isaac@audius.co>
nicoback2force-pushed
the
nkang--connect-ui
branch
from
January 5, 2024 22:28
6eae3cf to
917c6b6Comparenicoback2 added a commit
that referenced
this pull request
Jan 9, 2024
…-3496 (#6929) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Theo Ilie <theoilie.ti@gmail.com> Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: audius-infra <audius-infra@audius.co> Co-authored-by: Andrew Mendelsohn <andrew.j.mendelsohn@gmail.com> Co-authored-by: Steve Perkins <steve@audius.co> Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Marcus Pasell <3690498+rickyrombo@users.noreply.github.com> Co-authored-by: isaac <isaac@audius.co> Co-authored-by: Kyle Shanks <kyle.j.shanks@gmail.com>
nicoback2 added a commit
that referenced
this pull request
Jan 12, 2024
…-3496 (#6929) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Theo Ilie <theoilie.ti@gmail.com> Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: audius-infra <audius-infra@audius.co> Co-authored-by: Andrew Mendelsohn <andrew.j.mendelsohn@gmail.com> Co-authored-by: Steve Perkins <steve@audius.co> Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Marcus Pasell <3690498+rickyrombo@users.noreply.github.com> Co-authored-by: isaac <isaac@audius.co> Co-authored-by: Kyle Shanks <kyle.j.shanks@gmail.com>
nicoback2 added a commit
that referenced
this pull request
Jan 18, 2024
…-3496 (#6929) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Theo Ilie <theoilie.ti@gmail.com> Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: audius-infra <audius-infra@audius.co> Co-authored-by: Andrew Mendelsohn <andrew.j.mendelsohn@gmail.com> Co-authored-by: Steve Perkins <steve@audius.co> Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Marcus Pasell <3690498+rickyrombo@users.noreply.github.com> Co-authored-by: isaac <isaac@audius.co> Co-authored-by: Kyle Shanks <kyle.j.shanks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.