Uh oh!
There was an error while loading. Please reload this page.
[C-4412] Migrate native buttons to harmony-native - #8810
Conversation
|
amendelsohn
left a comment
There was a problem hiding this comment.
HUGE! Awesome update 👏
| export const ScreenHeaderButton = (props: ScreenHeaderButtonProps) => { | ||
| return <Button key={props.title} variant='secondary' size='xs' {...props} /> | ||
| return ( | ||
| <View> |
There was a problem hiding this comment.
What's the extra View for here?
There was a problem hiding this comment.
Supremely weird, but the parent views align-items "center" was not applying to the button, so i added this view so the title + filter buttons in the header like feed was aligned correctly. will add a comment here though :)
| <Button onPress={handleConfirmPress} variant={'destructive'} fullWidth> | ||
| {messages.deleteButton} | ||
| </Button> | ||
| <Button onPress={closeDrawer} variant={'secondary'} fullWidth> |
There was a problem hiding this comment.
nit: don't need the {'...'}
| <ButtononPress={handleConfirmPress}variant={'destructive'}fullWidth> | |
| {messages.deleteButton} | |
| </Button> | |
| <ButtononPress={closeDrawer}variant={'secondary'}fullWidth> | |
| <ButtononPress={handleConfirmPress}variant='destructive'fullWidth> | |
| {messages.deleteButton} | |
| </Button> | |
| <ButtononPress={closeDrawer}variant='secondary'fullWidth> |
There was a problem hiding this comment.
thanks! yes i decided to leave existing issues as is, but can fix this file :)
| onPressIn={handlePressIn} | ||
| onPressOut={handlePressOut} |
There was a problem hiding this comment.
not necessary to change now, but if this is a common pattern, maybe button could pass this as a prop to its children formik style so you could do
<Button>
{ ({isActive}) => <Text style={isActive ? ... }>...</Text> }
</Button>
There was a problem hiding this comment.
yeah great idea, will look into. personally i care not at all for this component because it's only present when monetization is disabled. we should probably just remove this whole feature. will bring it up in the channel when design is back.
| (e: GestureResponderEvent) => { | ||
| onPress?.(e) | ||
| if (haptics) { | ||
| haptic.medium() |
| iconRight={IconMessageLocked} | ||
| variant='secondary' | ||
| size='small' | ||
| style={{ opacity: 0.4 }} |
There was a problem hiding this comment.
do we have a disabled button style to cover this?
There was a problem hiding this comment.
yes we should, let me confirm the pattern here because i think we still want the on-press to happen to show a popup.
[9819b5d] [PROTO-1867] OTP only on unfamiliar devices (#9023) Danny [ef68724] [C-4637] Edit Collection Page (#9021) Dylan Jeffers [119465e] [C-4632] Show 'remove' artwork button on edit collection, otherwise 'change' button (#9042) Andrew Mendelsohn [fb506c3] Fix preview times longer than track duration not erroring (#9039) Reed [8df874e] [C-4649] fix jumping date picker popup (#9038) Andrew Mendelsohn [6ed21e6] [C-4606] Mobile advanced search All Results screen (#9037) Sebastian Klingler [7f77671] [C-4641C-4654C-4648] Edit track page fixes (#9033) Dylan Jeffers [69dd11c] [C-4688] Add AlbumResults and PlaylistResults for advanced search (#9031) Sebastian Klingler [23835e7] [C-4652] Fix track update access conditions (#9035) Reed [0e1c5ee] [PAY-3125] Add SDK support for location in transaction (#8904) Raymond Jacobson [83b37e8] Connect remaining mobile search filters (#9032) Kyle Shanks [826bcd2] [C-4586] Add mobile FilterBpmScreen for new search screen (#9029) Kyle Shanks [e273c60] Update dapp-store build artifacts audius-infra [0869462] [C-4687] Wire up mobile advanced search tracks lineup (#9030) Sebastian Klingler [a00a708] [C-4412] Migrate native buttons to harmony-native (#8810) Dylan Jeffers [8302e19] [QA-1416] Fix top-artists and audius-query (#9025) Dylan Jeffers [a94c07e] [C-4621] Advanced search mobile web (#9019) Sebastian Klingler [0fbd54f] [QA-1414] Force fetch playlist on navigate from playlist tile (#9020) Andrew Mendelsohn [2cabca6] [PAY-3145][PAY-3150] Do not show hidden track/album in feed/trending/explore (#9015) Saliou Diallo [42e8be5] [PROTO-1868PROTO-1871PROTO-1865] lookup key <> wallet association (#8815) alecsavvy [9a50c42] [QA-1403] Fix "Not enough signers" simulation error in "Claim All Rewards" flow (#9012) Marcus Pasell [3027d8a] [C-4555] Add release date to new track edit (#9018) JD Francis [ecc4e27] PAY-2489PAY-2507 Fix UI for Change Email, Change Password (#9010) Marcus Pasell [ab89dc3] [C-4585] Add mobile search musical key filter (#9009) Dylan Jeffers [d400b83] [QA-1412] Show play button and hide stats on smart collections (#9017) Andrew Mendelsohn [e2f3cc2] Make small label update to FilterButton (#9016) Kyle Shanks [4a4b3aa] [PAY-3147] Allow unsave/unrepost hidden track/album (#8995) Saliou Diallo [abb2e78] [C-4624] Add FilterButton to Harmony Native (#8998) Kyle Shanks [db90ca8] [C-4572] Advanced search UI polish (#9004) Sebastian Klingler [1e87a5b] [QA-1409] Fix mobile nowplaying images not loading after failure state (#9005) JD Francis [8b671b4] Improve mobile search state and navigation (#9008) Dylan Jeffers [b3b898b] Bump mobile apps to 105 (#9013) Dylan Jeffers [1fda969] [PAY-3133][PAY-3127] Better UX for accept/reject flows (#8980) Randy Schott [a3001b2] Fix visibility field tests (#9011) Andrew Mendelsohn
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.