Uh oh!
There was an error while loading. Please reload this page.
[C-4637] Edit Collection Page - #9021
Conversation
|
audius-infra
commented
Jul 2, 2024
Preview this change https://demo.audius.co/c-4637-edit-collection-page |
audius-infra
commented
Jul 3, 2024
Preview this change https://demo.audius.co/c-4637-edit-collection-page |
audius-infra
commented
Jul 3, 2024
Preview this change https://demo.audius.co/c-4637-edit-collection-page |
| // Pick< | ||
| // BaseButtonProps, | ||
| // | 'onClick' | ||
| // | 'disabled' | ||
| // | 'className' | ||
| // | 'type' | ||
| // | 'children' | ||
| // | 'isLoading' | ||
| // | 'asChild' | ||
| // > |
| [styles.editableTitle]: isOwner | ||
| })} | ||
| onClick={isOwner ? handleClickEditTitle : undefined} | ||
| // @ts-ignore |
There was a problem hiding this comment.
if this is valid, should we fix the expected type?
There was a problem hiding this comment.
flex as prop isn't doing the best job figuring out type inference, so this saves having to do a big ternery, not the best situation though...
| title: string | ||
| customHeader?: Nullable<string> | ||
| customDescription?: Nullable<string> | ||
| header?: Nullable<string> |
There was a problem hiding this comment.
do we need the optional nullable?
There was a problem hiding this comment.
seems overkill agreed, will simplify
| props: DeleteCollectionConfirmationModalProps | ||
| ) => { | ||
| const history = useHistory() | ||
| const lastLocation = useLastLocation() |
There was a problem hiding this comment.
ohhh that's what I was looking for on the track edit page's back button!
| if (is_private && !values.is_private && !isReleaseConfirmationOpen) { | ||
| setIsReleaseConfirmationOpen(true) | ||
| } else { | ||
| setIsReleaseConfirmationOpen(false) |
There was a problem hiding this comment.
i can double check if that modal closes automatically, probably does since the page naviagtes huh?
| const TopLevelPage = ({ showAddToCollection }: TopLevelPageProps) => { | ||
| const { isOpen } = useEditPlaylistModal() | ||
| const showPage = isOpen || showAddToCollection | ||
| const showPage = showAddToCollection |
There was a problem hiding this comment.
nit: could remove this var and use showAddToCollection below
| dispatch(editPlaylist(playlist_id, collection as EditPlaylistValues)) | ||
| dispatch(replace(permalink)) |
There was a problem hiding this comment.
curious what's the reason to replace here? do we want to remove the edit page from history so you can't back into it?
There was a problem hiding this comment.
yeah that's what is was thinking, its not really a "go-back" type thing, but maybe a product question?
| const initialMetadata = { | ||
| ...(metadata as Collection), | ||
| ...(collection as unknown as Collection), |
There was a problem hiding this comment.
Tangent, but I think the need to do this arises from the lack of a cache type mapping in audius-query
The endpoints return api models, but once we cache and return them, we're actually returning the cache models. Been thinking about ways to handle this if you want to discuss sometime
| import { removeNullable } from 'utils/typeUtils' | ||
| // The edit collection form receives a tracks array, but we need to convert that to playlist_contents | ||
| export const updatePlaylistContents = ( |
There was a problem hiding this comment.
so this is just reordering the existing playlist_contents array using tracks as source of truth of order only?
There was a problem hiding this comment.
order and deletes, yeah. its a bit of annoying addition but it's because we use the tracks array for rending the list of tracks, but ultimately we need to update playlist_contents for the updatePlaylist call
| playlist_contents?.track_ids.map((item) => [item.track, item]) | ||
| ) | ||
| const updatedPlaylistIds = tracks |
audius-infra
commented
Jul 3, 2024
Preview this change https://demo.audius.co/c-4637-edit-collection-page |
| }), | ||
| trackDetails: z.optional( | ||
| z.object({ | ||
| genre: z.optional(GenreSchema), |
There was a problem hiding this comment.
is genre optional? I thought it was required
| // Pick< | ||
| // BaseButtonProps, | ||
| // | 'onClick' | ||
| // | 'disabled' | ||
| // | 'className' | ||
| // | 'type' | ||
| // | 'children' | ||
| // | 'isLoading' | ||
| // | 'asChild' | ||
| // > |
| [styles.editableTitle]: isOwner | ||
| })} | ||
| onClick={isOwner ? handleClickEditTitle : undefined} | ||
| // @ts-ignore |
There was a problem hiding this comment.
would you mind adding a comment context for the ignore?
| <Flex | ||
| direction='column' | ||
| gap='l' | ||
| ph='xl' | ||
| pv='l' | ||
| alignItems='flex-start' | ||
| > | ||
| <Text variant='title' size='l'> | ||
| {messages.trackDetails.title} | ||
| </Text> | ||
| <Text variant='body'>{messages.trackDetails.description}</Text> | ||
| <Flex w='100%' gap='s'> | ||
| <SelectGenreField name='trackDetails.genre' /> | ||
| <SelectMoodField name='trackDetails.mood' /> | ||
| </Flex> | ||
| <TagField name='trackDetails.tags' /> | ||
| {isAlbum && <StemsAndDownloadsCollectionField />} | ||
| </Flex> | ||
| ) : null} | ||
| {!isUpload ? ( | ||
| <Flex> | ||
| <Button | ||
| variant='destructive' | ||
| size='small' | ||
| iconLeft={IconTrash} | ||
| onClick={() => setIsDeleteConfirmationOpen(true)} | ||
| > | ||
| {messages.deleteCollection(collectionTypeName)} | ||
| </Button> | ||
| </Flex> |
There was a problem hiding this comment.
nit: imo could read a bit clearer if you split these out above like
constrenderUpload=()=>constrenderEdit=()=>{isUpload ? renderUpload() : renderEdit()}| const collection = useSelector((state) => | ||
| getCollection(state, { id: collectionId }) | ||
| ) | ||
| const { is_album, permalink } = collection ?? {} |
There was a problem hiding this comment.
nit: prefer to convert this to isAlbum
61a13b9 to
339daf6Compareaudius-infra
commented
Jul 5, 2024
Preview this change https://demo.audius.co/c-4637-edit-collection-page |
[9819b5d] [PROTO-1867] OTP only on unfamiliar devices (#9023) Danny [ef68724] [C-4637] Edit Collection Page (#9021) Dylan Jeffers [119465e] [C-4632] Show 'remove' artwork button on edit collection, otherwise 'change' button (#9042) Andrew Mendelsohn [fb506c3] Fix preview times longer than track duration not erroring (#9039) Reed [8df874e] [C-4649] fix jumping date picker popup (#9038) Andrew Mendelsohn [6ed21e6] [C-4606] Mobile advanced search All Results screen (#9037) Sebastian Klingler [7f77671] [C-4641C-4654C-4648] Edit track page fixes (#9033) Dylan Jeffers [69dd11c] [C-4688] Add AlbumResults and PlaylistResults for advanced search (#9031) Sebastian Klingler [23835e7] [C-4652] Fix track update access conditions (#9035) Reed [0e1c5ee] [PAY-3125] Add SDK support for location in transaction (#8904) Raymond Jacobson [83b37e8] Connect remaining mobile search filters (#9032) Kyle Shanks [826bcd2] [C-4586] Add mobile FilterBpmScreen for new search screen (#9029) Kyle Shanks [e273c60] Update dapp-store build artifacts audius-infra [0869462] [C-4687] Wire up mobile advanced search tracks lineup (#9030) Sebastian Klingler [a00a708] [C-4412] Migrate native buttons to harmony-native (#8810) Dylan Jeffers [8302e19] [QA-1416] Fix top-artists and audius-query (#9025) Dylan Jeffers [a94c07e] [C-4621] Advanced search mobile web (#9019) Sebastian Klingler [0fbd54f] [QA-1414] Force fetch playlist on navigate from playlist tile (#9020) Andrew Mendelsohn [2cabca6] [PAY-3145][PAY-3150] Do not show hidden track/album in feed/trending/explore (#9015) Saliou Diallo [42e8be5] [PROTO-1868PROTO-1871PROTO-1865] lookup key <> wallet association (#8815) alecsavvy [9a50c42] [QA-1403] Fix "Not enough signers" simulation error in "Claim All Rewards" flow (#9012) Marcus Pasell [3027d8a] [C-4555] Add release date to new track edit (#9018) JD Francis [ecc4e27] PAY-2489PAY-2507 Fix UI for Change Email, Change Password (#9010) Marcus Pasell [ab89dc3] [C-4585] Add mobile search musical key filter (#9009) Dylan Jeffers [d400b83] [QA-1412] Show play button and hide stats on smart collections (#9017) Andrew Mendelsohn [e2f3cc2] Make small label update to FilterButton (#9016) Kyle Shanks [4a4b3aa] [PAY-3147] Allow unsave/unrepost hidden track/album (#8995) Saliou Diallo [abb2e78] [C-4624] Add FilterButton to Harmony Native (#8998) Kyle Shanks [db90ca8] [C-4572] Advanced search UI polish (#9004) Sebastian Klingler [1e87a5b] [QA-1409] Fix mobile nowplaying images not loading after failure state (#9005) JD Francis [8b671b4] Improve mobile search state and navigation (#9008) Dylan Jeffers [b3b898b] Bump mobile apps to 105 (#9013) Dylan Jeffers [1fda969] [PAY-3133][PAY-3127] Better UX for accept/reject flows (#8980) Randy Schott [a3001b2] Fix visibility field tests (#9011) Andrew Mendelsohn
…nav-styling * origin/main: (36 commits) Fix mobile single-OTP signup (#9056) Hide 0 stats on mobile collection screens (#9054) [C-4695] Fix remix field visibility (#9049) [C-4647] Fix license type (#9048) [C-4594] Fix user-generated-text links (#9050) Mediorum: skip image transcode (#9051) [Protodash] Show pending transactions on Overview page; tell users they have to come back to undelegate [QA-1396] (#8903) PROTO-1866: merge change email and post auth into one route (#9028) Bump mobile versions to 106 (#9047) Audius Protocol v0.6.142 [C-46916] Fix Block API Streaming (#9044) [C-4650] Fix visibility field when released scheduled release (#9043) Patch paginated query bug (#9046) Fix condition for adding hidden track to playlist (#9045) Audius Client (Web and Mobile) v1.5.89 [PROTO-1867] OTP only on unfamiliar devices (#9023) [C-4637] Edit Collection Page (#9021) [C-4632] Show 'remove' artwork button on edit collection, otherwise 'change' button (#9042) [C-4694] Add track_count to non-full playlist endpoint (#9040) Fix preview times longer than track duration not erroring (#9039) ...
Description
Adds edit collection page and connects it to edit collection buttons.
Conforms to all the requirements in figma
Still need to determine what to do with "create-playlist-modal"