Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [C-4637] Edit Collection Page by dylanjeffers · Pull Request #9021 · AudiusProject/apps · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ import {
import { z } from 'zod'

import { imageBlank } from '~/assets'
import { NativeFile, TrackForUpload } from '~/store/upload/types'
import { Collection } from '~/models'
import { NativeFile, TrackForEdit, TrackForUpload } from '~/store/upload/types'

const messages = {
artworkRequiredError: 'Artwork is required.',
Expand DownExpand Up@@ -149,6 +150,7 @@ const hiddenMetadataSchema = z.object({
const createSdkSchema = () =>
z
.object({
track_id: z.optional(z.number()).nullable(),
ai_attribution_user_id: z.optional(z.number()).nullable(),
allowed_api_keys: z.optional(z.array(z.string())).nullable(),
description: z.optional(z.string().max(1000)).nullable(),
Expand DownExpand Up@@ -230,7 +232,10 @@ export const TrackMetadataFormSchema = TrackMetadataSchema.refine(
}
)

const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({ title: true })
const CollectionTrackMetadataSchema = TrackMetadataSchema.pick({
title: true,
track_id: true
})

/**
* Produces a schema that validates a collection metadata for upload.
Expand DownExpand Up@@ -266,11 +271,13 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
description: z.optional(z.string().max(1000)),
release_date: z.optional(z.string()).nullable(),
is_scheduled_release: z.optional(z.boolean()),
trackDetails: z.object({
genre: GenreSchema,
mood: MoodSchema,
tags: z.optional(z.string())
}),
trackDetails: z.optional(
z.object({
genre: z.optional(GenreSchema),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is genre optional? I thought it was required

mood: MoodSchema,
tags: z.optional(z.string())
})
),
is_private: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
Expand All@@ -279,7 +286,8 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
copyrightLine: z.optional(DDEXCopyright.nullable()),
producerCopyrightLine: z.optional(DDEXCopyright.nullable()),
parentalWarningType: z.optional(z.string().nullable()),
is_downloadable: z.optional(z.boolean())
is_downloadable: z.optional(z.boolean()),
isUpload: z.optional(z.boolean())
})
.merge(
premiumMetadataSchema.extend({
Expand DownExpand Up@@ -310,11 +318,15 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
*/
type UnvalidatedCollectionMetadata = {
playlist_id?: number
artwork: {
file: File | NativeFile
source?: string
} | null
tracks: TrackForUpload[]
artwork:
| {
file: File | NativeFile
source?: string
}
| { url: string }
| null
tracks: (TrackForUpload | TrackForEdit)[]
playlist_contents?: Collection['playlist_contents']
}

export const PlaylistSchema = createCollectionSchema('playlist')
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/store/cache/collections/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,4 +24,5 @@ export type Image = {

export type EditPlaylistValues = Collection & {
artwork: Image
tracks?: { metadata: Track }[]
}
29 changes: 0 additions & 29 deletions packages/common/src/store/ui/modals/edit-playlist-modal/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './inbox-unavailable-modal'
export * from './usdc-purchase-details-modal'
export * from './usdc-transaction-details-modal'
export * from './withdraw-usdc-modal'
export * from './edit-playlist-modal'
export * from './edit-track-modal'
export * from './premium-content-purchase-modal'
export * from './usdc-manual-transfer-modal'
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/store/ui/modals/parentSlice.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ export const initialState: BasicModalsState = {
TrendingGenreSelection: { isOpen: false },
SocialProof: { isOpen: false },
EditFolder: { isOpen: false },
EditPlaylist: { isOpen: false },
EditTrack: { isOpen: false },
SignOutConfirmation: { isOpen: false },
Overflow: { isOpen: false },
Expand Down
2 changes: 0 additions & 2 deletions packages/common/src/store/ui/modals/reducers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import { artistPickModalReducer } from './artist-pick-modal'
import { coinflowOnrampModalReducer } from './coinflow-onramp-modal'
import { coinflowWithdrawModalReducer } from './coinflow-withdraw-modal'
import { createChatModalReducer } from './create-chat-modal'
import { editPlaylistModalReducer } from './edit-playlist-modal'
import { editTrackModalReducer } from './edit-track-modal'
import { inboxUnavailableModalReducer } from './inbox-unavailable-modal'
import { leavingAudiusModalReducer } from './leaving-audius-modal'
Expand DownExpand Up@@ -34,7 +33,6 @@ const noOpReducers = Object.keys(initialState).reduce((prev, curr) => {
*/
const combinedReducers = combineReducers({
...noOpReducers,
EditPlaylist: editPlaylistModalReducer,
EditTrack: editTrackModalReducer,
CreateChatModal: createChatModalReducer,
InboxUnavailableModal: inboxUnavailableModalReducer,
Expand Down
3 changes: 0 additions & 3 deletions packages/common/src/store/ui/modals/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import { AlbumTrackRemoveConfirmationModalState } from './album-track-remove-con
import { ArtistPickModalState } from './artist-pick-modal'
import { CoinflowOnrampModalState } from './coinflow-onramp-modal'
import { CoinflowWithdrawModalState } from './coinflow-withdraw-modal'
import { EditPlaylistModalState } from './edit-playlist-modal'
import { EditTrackModalState } from './edit-track-modal'
import { InboxUnavailableModalState } from './inbox-unavailable-modal'
import { LeavingAudiusModalState } from './leaving-audius-modal'
Expand DownExpand Up@@ -49,7 +48,6 @@ export type Modals =
| 'TrendingGenreSelection'
| 'SocialProof'
| 'EditFolder'
| 'EditPlaylist'
| 'EditTrack'
| 'SignOutConfirmation'
| 'Overflow'
Expand DownExpand Up@@ -95,7 +93,6 @@ export type BasicModalsState = {
export type StatefulModalsState = {
CoinflowOnramp: CoinflowOnrampModalState
CreateChatModal: CreateChatModalState
EditPlaylist: EditPlaylistModalState
EditTrack: EditTrackModalState
InboxUnavailableModal: InboxUnavailableModalState
LeavingAudiusModal: LeavingAudiusModalState
Expand Down
6 changes: 5 additions & 1 deletion packages/common/src/store/upload/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,10 @@ export interface TrackForUpload {
metadata: TrackMetadataForUpload
}

export interface TrackForEdit {
metadata: TrackMetadataForUpload
}

/**
* Unlike normal Track metadata, TrackMetadataForUpload includes additional
* files: artwork and a stems field with StemsForUpload.
Expand All@@ -53,7 +57,7 @@ export interface TrackMetadataForUpload extends TrackMetadata {
*/
export interface CollectionMetadataForUpload extends CollectionMetadata {
artwork: {
file: Blob
file?: Blob
url: string
}
trackDetails: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
fullWidth,
styles,
children,
slotted,
'aria-label': ariaLabelProp,
asChild,
_isHovered,
Expand DownExpand Up@@ -115,7 +116,13 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>(
) : LeftIconComponent ? (
<LeftIconComponent css={[iconCss, styles?.icon]} />
) : null}
{!isTextHidden ? <Slottable>{children}</Slottable> : null}
{!isTextHidden ? (
slotted ? (
children
) : (
<Slottable>{children}</Slottable>
)
) : null}
{RightIconComponent ? (
<RightIconComponent css={[iconCss, styles?.icon]} />
) : null}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,5 +77,6 @@ export type BaseButtonProps = {
* merging their props and behavior.
*/
asChild?: boolean
slotted?: boolean
} & HTMLButtonProps &
InternalProps
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import { forwardRef } from 'react'

import { useTheme, type CSSObject } from '@emotion/react'
import { Slottable } from '@radix-ui/react-slot'

import type { IconComponent, IconProps } from '../../icon'
import { BaseButton } from '../BaseButton/BaseButton'
Expand All@@ -12,10 +13,7 @@ export type IconButtonProps = {
'aria-label': string
iconCss?: CSSObject
} & Pick<IconProps, 'color' | 'size' | 'shadow' | 'height' | 'width'> &
Pick<
BaseButtonProps,
'onClick' | 'disabled' | 'className' | 'type' | 'children' | 'isLoading'
>
BaseButtonProps

/**
* The icon component allows you to pass in an icon and
Expand All@@ -35,7 +33,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
children,
...other
} = props
const { disabled, isLoading } = other
const { disabled, isLoading, asChild } = other
const { color, cornerRadius, spacing, motion, iconSizes } = useTheme()

const buttonCss: CSSObject = {
Expand DownExpand Up@@ -87,10 +85,11 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
return (
<BaseButton
ref={ref}
type='button'
type={asChild ? undefined : 'button'}
{...other}
css={[buttonCss, ripple && rippleCss]}
styles={{ icon: loadingIconCss }}
slotted
>
{isLoading ? null : (
<Icon
Expand All@@ -103,7 +102,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
css={iconCss}
/>
)}
{children}
<Slottable>{children}</Slottable>
</BaseButton>
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/harmony/src/components/popup/Popup.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -356,7 +356,7 @@ export const Popup = forwardRef<HTMLDivElement, PopupProps>(function Popup(
setPopupState('closing')
anchorRef.current?.focus()
}
}, [isVisibleProp, popupState])
}, [anchorRef, isVisibleProp, popupState])

const transitions = useTransition(isVisibleProp, null, {
from: {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,8 +42,10 @@ export const EditPlaylistModalScreen = () => {

if (!playlist) return null

const { tracks: tracksIgnored, ...restPlaylist } = playlist

const initialValues: EditPlaylistValues = {
...playlist,
...restPlaylist,
artwork: {
url:
trackImage && isImageUriSource(trackImage.source)
Expand Down
12 changes: 11 additions & 1 deletion packages/web/src/app/web-player/WebPlayer.jsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ import { CollectiblesPlaylistPage } from 'pages/collectibles-playlist-page'
import CollectionPage from 'pages/collection-page/CollectionPage'
import { DashboardPage } from 'pages/dashboard-page/DashboardPage'
import { DeactivateAccountPage } from 'pages/deactivate-account-page/DeactivateAccountPage'
import { EditCollectionPage } from 'pages/edit-collection-page'
import EmptyPage from 'pages/empty-page/EmptyPage'
import ExploreCollectionsPage from 'pages/explore-page/ExploreCollectionsPage'
import ExplorePage from 'pages/explore-page/ExplorePage'
Expand DownExpand Up@@ -181,7 +182,9 @@ import {
ACCOUNTS_YOU_MANAGE_SETTINGS_PAGE,
TRACK_EDIT_PAGE,
SEARCH_CATEGORY_PAGE_LEGACY,
SEARCH_BASE_ROUTE
SEARCH_BASE_ROUTE,
EDIT_PLAYLIST_PAGE,
EDIT_ALBUM_PAGE
} from 'utils/route'

import styles from './WebPlayer.module.css'
Expand DownExpand Up@@ -863,6 +866,13 @@ class WebPlayer extends Component {
)
}}
/>

<Route
exact
path={[EDIT_PLAYLIST_PAGE, EDIT_ALBUM_PAGE]}
component={EditCollectionPage}
/>

<Route
exact
path={ALBUM_PAGE}
Expand Down
17 changes: 9 additions & 8 deletions packages/web/src/common/store/upload/sagas.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,17 +98,18 @@ function* combineMetadata(
metadata.artwork = collectionMetadata.artwork

if (!metadata.genre)
metadata.genre = collectionMetadata.trackDetails.genre ?? ''
if (!metadata.mood) metadata.mood = collectionMetadata.trackDetails.mood ?? ''
metadata.genre = collectionMetadata.trackDetails?.genre ?? ''
if (!metadata.mood)
metadata.mood = collectionMetadata.trackDetails?.mood ?? ''
if (!metadata.release_date) {
metadata.release_date = collectionMetadata.release_date ?? null
metadata.is_scheduled_release =
collectionMetadata.is_scheduled_release ?? false
}

if (metadata.tags === null && collectionMetadata.trackDetails.tags) {
if (metadata.tags === null && collectionMetadata.trackDetails?.tags) {
// Take collection tags
metadata.tags = collectionMetadata.trackDetails.tags
metadata.tags = collectionMetadata.trackDetails?.tags
}

// Set download & hidden status
Expand DownExpand Up@@ -766,10 +767,10 @@ export function* uploadCollection(
}

// First upload album art
yield* call(
audiusBackendInstance.uploadImage,
collectionMetadata.artwork?.file as File
)
const { artwork } = collectionMetadata
if (artwork && 'file' in artwork) {
yield* call(audiusBackendInstance.uploadImage, artwork.file as File)
}

// Propagate the collection metadata to the tracks
for (const track of tracks) {
Expand Down
Loading