Skip to content

[C-5042] Fix react-native on xcode16 - #9830

Merged
dylanjeffers merged 5 commits into
mainfrom
fix-xcode-16
Sep 23, 2024
Merged

[C-5042] Fix react-native on xcode16#9830
dylanjeffers merged 5 commits into
mainfrom
fix-xcode-16

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes a few of the issues presented by xcode16:

  • react-native-sentry
  • react-native-zip
  • react-native-image-picker

@changeset-bot

changeset-botBot commented Sep 23, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6fcfdf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@alch/alchemy-web3@1.4.6network06.65 MBbrian-alchemy
npm/@amplitude/node@1.9.2network+4590 kBkevinpagtakhan
npm/@amplitude/react-native@2.17.2None0187 kBhao.yu
npm/@apollo/client@3.3.7environment, network Transitive: eval+13.3 MBapollo-bot
npm/@apollo/protobufjs@1.2.7environment, filesystem, network02.9 MBglasser
npm/@apollo/usage-reporting-protobuf@4.1.1None01.02 MBapollo-bot
npm/@apollo/utils.dropunuseddefinitions@2.0.1None06.58 kBapollo-bot
npm/@apollo/utils.keyvaluecache@2.1.1None034.1 kBapollo-bot
npm/@apollo/utils.logger@2.0.1None07.64 kBapollo-bot
npm/@apollo/utils.printwithreducedwhitespace@2.0.1None06.83 kBapollo-bot
npm/@apollo/utils.removealiases@2.0.1None04.95 kBapollo-bot
npm/@apollo/utils.sortast@2.0.1None08.93 kBapollo-bot
npm/@apollo/utils.stripsensitiveliterals@2.0.1None09.43 kBapollo-bot
npm/@apollo/utils.usagereporting@2.1.0None026.7 kBapollo-bot
npm/@audius/fetch-nft@0.2.7network+21.12 MBmarcus_audius
npm/@audius/hedgehog@3.0.0-alpha.1Transitive: filesystem+4403 kBaudius-project
npm/@babel/cli@7.7.0Transitive: environment, filesystem, shell, unsafe+81.79 MBnicolo-ribaudo
npm/@babel/code-frame@7.23.5None023.3 kBnicolo-ribaudo
npm/@babel/compat-data@7.23.5None064.6 kBnicolo-ribaudo
npm/@babel/generator@7.23.6None0492 kBnicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6Transitive: environment, filesystem, unsafe+71.75 MBnicolo-ribaudo
npm/@babel/helper-define-polyfill-provider@0.3.3unsafe Transitive: environment, filesystem+71.89 MBnicolo-ribaudo
npm/@babel/helper-environment-visitor@7.22.20None06.56 kBnicolo-ribaudo
npm/@babel/helper-function-name@7.23.0None021.6 kBnicolo-ribaudo
npm/@babel/helper-module-imports@7.22.15None054.4 kBnicolo-ribaudo
npm/@babel/helper-validator-identifier@7.22.20None049.1 kBnicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5None011.7 kBnicolo-ribaudo
npm/@babel/highlight@7.23.4None018.4 kBnicolo-ribaudo
npm/@babel/parser@7.24.1None01.88 MBnicolo-ribaudo
npm/@babel/plugin-proposal-class-static-block@7.21.0Transitive: environment, filesystem, unsafe+132 MBnicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.21.0Transitive: environment, filesystem, unsafe+81.78 MBnicolo-ribaudo
npm/@babel/plugin-transform-runtime@7.18.2unsafe Transitive: environment, filesystem+71.71 MBnicolo-ribaudo
npm/@babel/preset-env@7.22.15environment Transitive: filesystem, unsafe+903.73 MBnicolo-ribaudo
npm/@babel/preset-typescript@7.22.15Transitive: environment, filesystem, unsafe+162.19 MBnicolo-ribaudo
npm/@babel/register@7.7.0environment, filesystem Transitive: unsafe+71.7 MBnicolo-ribaudo
npm/@babel/template@7.22.15None069.2 kBnicolo-ribaudo
npm/@babel/traverse@7.23.6None0610 kBnicolo-ribaudo
npm/@babel/types@7.23.6environment02.41 MBnicolo-ribaudo
npm/@changesets/cli@2.27.1environment, filesystem, shell+271.43 MBchangesets-release-bot
npm/@cloudflare/kv-asset-handler@0.3.1None+1126 kBwrangler-publisher
npm/@coinbase/cbpay-js@1.2.0None0172 kBlachiet
npm/@coinflowlabs/react@3.1.5network+2222 kBmeeder-coinflow
npm/@coral-xyz/anchor@0.29.0environment, filesystem, network+22.21 MBacheroncrypto
npm/@coral-xyz/borsh@0.29.0None022.2 kBacheroncrypto
npm/@elastic/elasticsearch@8.1.0Transitive: network+12.45 MBdelvedor
npm/@emotion/babel-plugin@11.11.0environment+3283 kBemotion-release-bot
npm/@emotion/babel-preset-css-prop@11.11.0environment Transitive: filesystem, unsafe+91.73 MBemotion-release-bot
npm/@emotion/css@11.11.2environment+6516 kBemotion-release-bot
npm/@emotion/eslint-plugin@11.11.0environment0101 kBemotion-release-bot
npm/@emotion/native@11.11.0environment+175.3 kBemotion-release-bot
npm/@emotion/react@11.11.1environment+7845 kBemotion-release-bot
npm/@emotion/server@11.11.0environment+277.7 kBemotion-release-bot
npm/@emotion/styled@11.11.0environment+4271 kBemotion-release-bot
npm/@emotion/unitless@0.8.1environment07.05 kBemotion-release-bot
npm/@esbuild-plugins/node-globals-polyfill@0.2.3None0105 kBxmorse
npm/@escape.tech/mookme@2.4.1environment, filesystem, shell+4271 kBsteffthestunt
npm/@eslint-community/regexpp@4.10.0None0431 kBeslint-community-bot
npm/@ethereumjs/common@3.2.0None+2585 kBholgerd77
npm/@ethereumjs/tx@4.2.0None0275 kBholgerd77
npm/@fingerprintjs/fingerprintjs-pro-server-api@4.1.2network0184 kBfp-pro
npm/@fingerprintjs/fingerprintjs-pro@3.5.6eval, network+1852 kBsurgie
npm/@google/model-viewer@3.3.0network030.9 MBgoogle-wombot
npm/@gorhom/bottom-sheet@4.6.4None+11.43 MBgorhom
npm/@gorhom/portal@1.0.9None089.6 kBgorhom
npm/@graphql-tools/merge@8.4.2None0100 kBardatan
npm/@graphql-tools/schema@9.0.19None069.6 kBardatan
npm/@graphql-tools/utils@9.2.1None0495 kBardatan
npm/@graphql-typed-document-node/core@3.2.0None02.96 kBdotansimha
npm/@hcaptcha/react-hcaptcha@0.3.6None030.8 kBbrdlyptrs
npm/@humanwhocodes/config-array@0.11.13None+1110 kBnzakas
npm/@isaacs/cliui@8.0.2None+6171 kBisaacs
npm/alchemy-sdk@2.0.1None01.44 MBbrian-alchemy
npm/prom-client@14.0.1filesystem, network, unsafe0105 kBsimenb

🚮 Removed packages:npm/@audius/sdk@3.0.8-beta.11, npm/@aws-sdk/client-sns@3.245.0, npm/@jest/globals@29.3.1, npm/@optimizely/optimizely-sdk@4.9.4, npm/@sendgrid/mail@7.7.0, npm/@tsconfig/node14@1.0.3, npm/@tsconfig/node16-strictest@1.0.4, npm/@types/express@4.17.17, npm/@types/jest@29.2.5, npm/@types/lodash@4.14.182, npm/@types/node@17.0.29, npm/@types/pg@8.6.5, npm/@types/supertest@2.0.12, npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/commander@9.2.0, npm/eslint-config-prettier@8.8.0, npm/eslint-plugin-prettier@4.2.1, npm/eslint@8.44.0

View full report↗︎

@audius-infra

Copy link
Copy Markdown
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype

Comment threadpackages/mobile/package.json Outdated
"@reduxjs/toolkit": "1.6.1",
"@sayem314/react-native-keep-awake": "1.2.2",
"@sentry/react-native": "5.19.3",
"@sentry/react-native": "^5.33.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin these?

]

apply from: "../../node_modules/@sentry/react-native/sentry.gradle"
apply from: "../../../../node_modules/@sentry/react-native/sentry.gradle"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, why is this required?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the reinstall happened, looks like react-native/sentry got moved to the root node_modules

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it only have to go up 3 levels? maybe I'm just looking at it wrong

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i could be wrong, but its up 2 to go from build.gradle to mobile/node_modules, and then two more to go to root modules, cause its ../packages ../../root

@dylanjeffers
dylanjeffers merged commit 0513301 into mainSep 23, 2024
@dylanjeffers
dylanjeffers deleted the fix-xcode-16 branch September 23, 2024 21:13
audius-infra pushed a commit that referenced this pull request Sep 28, 2024
[d2b0b5e] [C-5037] Optimistically update comment count (#9852) JD Francis
[9b58792] Return sparse data from users/tracks/remixed (#9886) Andrew Mendelsohn
[55523a5] Release v0.7.0: Community treasury collects 10% of payment volume (#9872) Raymond Jacobson
[64d800c] [QA-1740] Prevent upload progress from jumping backwards on retries (#9888) Randy Schott
[7b6e048] [C-4996] Linkify web comments (#9883) Sebastian Klingler
[fcf9777] [QA-1739] Better logic for empty states on playlists (#9881) Randy Schott
[6ee5f42] Fix claiming rewards w/ all attestations (#9884) Marcus Pasell
[e2d6c1f] [PAY-3445] Fix Chat Blast CTA footer positioning (#9869) Andrew Mendelsohn
[1edbd65] [C-5067] Update ComposerInput to not highlight timestamps for users without premium access (#9877) Kyle Shanks
[ebb6ae3] [C-5034] Remove comments components from harmony (#9878) Sebastian Klingler
[357b03d] [C-4995] Create mobile ComposerInput component for DMs and comments (#9866) Kyle Shanks
[905187c] [PAY-3461] Fix missing submit button on select audience (mobile) (#9854) Andrew Mendelsohn
[2e310f3] [C-4997] Linkify mobile comments (#9853) Sebastian Klingler
[e0826c1] [PAY-3457] Fix chat blast triggering chatlist resort (#9864) Reed
[48b2b71] Add new Messages icon to harmony (#9857) Andrew Mendelsohn
[4e8317d] [PAY-3447] Fix empty parens on audience count (#9855) Andrew Mendelsohn
[08949e2] [PAY-3454] Cursor pointer on profile picture list items (#9856) Andrew Mendelsohn
[482b564] Remove harmony contributing guidelines (#9858) Dylan Jeffers
[2a68630] [C-5032] Add mention notifications (#9824) Dylan Jeffers
[a786685] [C-5031] Add comment reply notifications (#9823) Dylan Jeffers
[d970b6d] [C-5041] Update comment id types (#9851) Dylan Jeffers
[e571d88] PAY-3428 Support network cut in pay-with-anything (#9848) Marcus Pasell
[235b9ca] Add new shortened Challenge IDs to valid ID list on mobile (#9841) Marcus Pasell
[d13679d] [PAY-3433] Center the chat blast audience display (#9839) Andrew Mendelsohn
[3d3106a] [PAY-3435] Select first available audience in create blast (#9838) Andrew Mendelsohn
[c5120bc] [C-5045] Fix TextLink positioning and styling (#9834) Sebastian Klingler
[09dad70] Only show blast audience list once users have loaded (#9835) Reed
[6a15d49] [PAY-3441] Cursor: pointer on chat blast modal (#9833) Reed
[e6b9423] Fix typo (#9831) Raymond Jacobson
[0513301] [C-5042] Fix react-native on xcode16 (#9830) Dylan Jeffers
[d02c16c] [PAY-3419] Fetch chat if necessary on chat reaction (#9832) Reed
[e39f313] Update mobile apps to 443 (#9827) Dylan Jeffers
[ce6210f] [C-5050] Comments disabled qa fixes (#9826) JD Francis
[3260bf0] [PAY-3217] DM share button for mobile upload (#9821) Andrew Mendelsohn
[4ed86a7] [C-5026] Mobile disable optimistic comments (#9818) JD Francis
[99414e9] Update comment header counts (#9819) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dylanjeffers@audius-infra@sliptype