Uh oh!
There was an error while loading. Please reload this page.
Return sparse data from users/tracks/remixed - #9886
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 969a83c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
amendelsohn
commented
Sep 26, 2024
| user_id=decoded_id, | ||
| current_user_id=get_current_user_id(args), | ||
| limit=get_default_max(args.get("limit"), 10, 100), | ||
| limit=get_default_max(args.get("limit"), 10, 10000), |
ContributorAuthor
There was a problem hiding this comment.
thoughts on whether we can just remove pagination outright?
rickyrombo
approved these changes
Sep 27, 2024
rickyrombo
left a comment
Contributor
There was a problem hiding this comment.
Had this made it out yet to an SDK release?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| from typing import TypedDict # pylint: disable=C0302 | ||
| from typing import TypedDict | ||
| from sqlalchemy import func # pylint: disable=C0302 |
Contributor
There was a problem hiding this comment.
is this pylint comment switching lines intentional?
dharit-tan
approved these changes
Sep 27, 2024
dharit-tan
left a comment
Contributor
There was a problem hiding this comment.
fyre
do we still need accompanying client changes?
audius-infra pushed a commit
that referenced
this pull request
Sep 28, 2024
[d2b0b5e] [C-5037] Optimistically update comment count (#9852) JD Francis [9b58792] Return sparse data from users/tracks/remixed (#9886) Andrew Mendelsohn [55523a5] Release v0.7.0: Community treasury collects 10% of payment volume (#9872) Raymond Jacobson [64d800c] [QA-1740] Prevent upload progress from jumping backwards on retries (#9888) Randy Schott [7b6e048] [C-4996] Linkify web comments (#9883) Sebastian Klingler [fcf9777] [QA-1739] Better logic for empty states on playlists (#9881) Randy Schott [6ee5f42] Fix claiming rewards w/ all attestations (#9884) Marcus Pasell [e2d6c1f] [PAY-3445] Fix Chat Blast CTA footer positioning (#9869) Andrew Mendelsohn [1edbd65] [C-5067] Update ComposerInput to not highlight timestamps for users without premium access (#9877) Kyle Shanks [ebb6ae3] [C-5034] Remove comments components from harmony (#9878) Sebastian Klingler [357b03d] [C-4995] Create mobile ComposerInput component for DMs and comments (#9866) Kyle Shanks [905187c] [PAY-3461] Fix missing submit button on select audience (mobile) (#9854) Andrew Mendelsohn [2e310f3] [C-4997] Linkify mobile comments (#9853) Sebastian Klingler [e0826c1] [PAY-3457] Fix chat blast triggering chatlist resort (#9864) Reed [48b2b71] Add new Messages icon to harmony (#9857) Andrew Mendelsohn [4e8317d] [PAY-3447] Fix empty parens on audience count (#9855) Andrew Mendelsohn [08949e2] [PAY-3454] Cursor pointer on profile picture list items (#9856) Andrew Mendelsohn [482b564] Remove harmony contributing guidelines (#9858) Dylan Jeffers [2a68630] [C-5032] Add mention notifications (#9824) Dylan Jeffers [a786685] [C-5031] Add comment reply notifications (#9823) Dylan Jeffers [d970b6d] [C-5041] Update comment id types (#9851) Dylan Jeffers [e571d88] PAY-3428 Support network cut in pay-with-anything (#9848) Marcus Pasell [235b9ca] Add new shortened Challenge IDs to valid ID list on mobile (#9841) Marcus Pasell [d13679d] [PAY-3433] Center the chat blast audience display (#9839) Andrew Mendelsohn [3d3106a] [PAY-3435] Select first available audience in create blast (#9838) Andrew Mendelsohn [c5120bc] [C-5045] Fix TextLink positioning and styling (#9834) Sebastian Klingler [09dad70] Only show blast audience list once users have loaded (#9835) Reed [6a15d49] [PAY-3441] Cursor: pointer on chat blast modal (#9833) Reed [e6b9423] Fix typo (#9831) Raymond Jacobson [0513301] [C-5042] Fix react-native on xcode16 (#9830) Dylan Jeffers [d02c16c] [PAY-3419] Fetch chat if necessary on chat reaction (#9832) Reed [e39f313] Update mobile apps to 443 (#9827) Dylan Jeffers [ce6210f] [C-5050] Comments disabled qa fixes (#9826) JD Francis [3260bf0] [PAY-3217] DM share button for mobile upload (#9821) Andrew Mendelsohn [4ed86a7] [C-5026] Mobile disable optimistic comments (#9818) JD Francis [99414e9] Update comment header counts (#9819) JD Francis
audius-infra pushed a commit
that referenced
this pull request
Sep 30, 2024
[35f7c78] Fix rate limiting of viewing notifications (#9890) Marcus Pasell [9b58792] Return sparse data from users/tracks/remixed (#9886) Andrew Mendelsohn [55523a5] Release v0.7.0: Community treasury collects 10% of payment volume (#9872) Raymond Jacobson [4487422] Audius Protocol v0.6.200 audius-infra [3708c65] Absorb uptime code into shared golang structure, remove uptime CI build (#9887) Danny [34469d7] ddex genre mapping (#9862) Steve Perkins [3b5e98b] [C-5054] Fix tombstone comments + add tests (#9865) JD Francis [776c988] Audius Protocol v0.6.199 audius-infra [d59ac89] Fix comment reply test (#9875) Dylan Jeffers [40c2980] [C-5039] Fix comment reports pkey (#9859) Dylan Jeffers [e68a764] Support lookup table in rewards indexing (#9873) Marcus Pasell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
users/user-id/tracks/remixedendpoint to return sparse data:This will allow us to fetch large pages of data instead of small ones.
How Has This Been Tested?
working locally