Skip to content

[PAY-3439] Add hono to create-audius-app - #9840

Merged
raymondjacobson merged 16 commits into
mainfrom
rj-pay-3439
Oct 1, 2024
Merged

[PAY-3439] Add hono to create-audius-app#9840
raymondjacobson merged 16 commits into
mainfrom
rj-pay-3439

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Sep 24, 2024

Copy link
Copy Markdown
Member

Description

npx create-audius-app

Will by default now give you a full-stack framework with a cloudflare-ready deployable serverless backend

  • Add additional example called react-hono and make that the default.
  • Slim down existing react to not do writes.
  • Add AuthContext for the hono example, so there's session login built-in
  • Add hook for useSdk
  • Update tests & CI

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran both examples locally and ran tests

For the react-hono one, to test

# copy example.env to .env
npm i
npm run dev
# or
npm run start # previews with wrangler

@changeset-bot

changeset-botBot commented Sep 24, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a974494

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@audius/sdkPatch
create-audius-appPatch
@audius/sp-actionsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3439

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3439

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3439

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3439

@gitguardian

gitguardianBot commented Sep 26, 2024

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
11648675TriggeredGeneric High Entropy Secret34423d4mediorum/mediorum_pkg/run.goView secret
11648675TriggeredGeneric High Entropy Secret34423d4mediorum/main.goView secret
11648678TriggeredGeneric High Entropy Secret34423d4mediorum/main.goView secret
11648678TriggeredGeneric High Entropy Secret34423d4mediorum/mediorum_pkg/run.goView secret
11648679TriggeredGeneric High Entropy Secret34423d4core/infra/dev_config/standalone-console.envView secret
11648679TriggeredGeneric High Entropy Secret34423d4mediorum/main.goView secret
11648679TriggeredGeneric High Entropy Secret34423d4mediorum/mediorum_pkg/run.goView secret
11648680TriggeredGeneric High Entropy Secret34423d4mediorum/mediorum_pkg/run.goView secret
11648680TriggeredGeneric High Entropy Secret34423d4mediorum/main.goView secret
11648681TriggeredGeneric High Entropy Secret34423d4mediorum/mediorum_pkg/run.goView secret
11648681TriggeredGeneric High Entropy Secret34423d4mediorum/main.goView secret
2416685TriggeredGeneric High Entropy Secrete16593apackages/libs/src/sdk/config/staging.tsView secret
2460750TriggeredGeneric High Entropy Secrete16593apackages/libs/src/sdk/config/production.tsView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sliptypesliptype left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many small details to get this working! Nice job

@samgutentagsamgutentag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@socket-security

socket-securityBot commented Oct 1, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@audius/harmony@0.2.0environment Transitive: eval, filesystem, network, unsafe+14064.7 MBsliptype
npm/@audius/sdk@5.1.0eval Transitive: environment, filesystem, network, shell, unsafe+431201 MBsliptype
npm/@tanstack/react-query@5.32.0environment+13.84 MBtannerlinsley
npm/@types/react-dom@18.2.0None029.1 kBtypes
npm/@types/react@18.2.0None+31.61 MBtypes
npm/@typescript-eslint/eslint-plugin@6.0.0Transitive: environment, filesystem+458.12 MBjameshenry
npm/@typescript-eslint/parser@6.0.0Transitive: environment, filesystem+312.94 MBjameshenry
npm/@vitejs/plugin-react@4.0.3Transitive: environment, filesystem, shell, unsafe+5211.7 MBvitebot
npm/env-cmd@10.1.0environment, filesystem Transitive: shell+5170 kBtoddbluhm
npm/eslint-plugin-react-hooks@4.6.0environment0118 kBgnoff
npm/eslint-plugin-react-refresh@0.4.3None011.6 kBarnaud-barre
npm/eslint@8.56.0environment, filesystem Transitive: eval, shell, unsafe+9210.7 MBeslintbot
npm/react-dom@18.2.0environment+34.62 MBgnoff
npm/react@18.2.0environment+2337 kBgnoff
npm/typescript@5.0.2None039.2 MBtypescript-bot
npm/vite@4.4.5environment, eval, filesystem, network, shell, unsafe+32252 MBvitebot

🚮 Removed packages:npm/@alch/alchemy-web3@1.4.6, npm/@amplitude/node@1.9.2, npm/@amplitude/react-native@2.17.2, npm/@apollo/client@3.3.7, npm/@apollo/protobufjs@1.2.7, npm/@apollo/usage-reporting-protobuf@4.1.1, npm/@apollo/utils.dropunuseddefinitions@2.0.1, npm/@apollo/utils.keyvaluecache@2.1.1, npm/@apollo/utils.logger@2.0.1, npm/@apollo/utils.printwithreducedwhitespace@2.0.1, npm/@apollo/utils.removealiases@2.0.1, npm/@apollo/utils.sortast@2.0.1, npm/@apollo/utils.stripsensitiveliterals@2.0.1, npm/@apollo/utils.usagereporting@2.1.0, npm/@audius/fetch-nft@0.2.7, npm/@babel/cli@7.7.0, npm/@babel/code-frame@7.23.5, npm/@babel/compat-data@7.23.5, npm/@babel/generator@7.23.6, npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-compilation-targets@7.23.6, npm/@babel/helper-define-polyfill-provider@0.3.3, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/helper-validator-option@7.23.5, npm/@babel/highlight@7.23.4, npm/@babel/parser@7.24.1, npm/@babel/plugin-transform-react-jsx@7.21.0, npm/@babel/plugin-transform-runtime@7.18.2, npm/@babel/preset-env@7.22.15, npm/@babel/preset-typescript@7.22.15, npm/@babel/register@7.7.0, npm/@babel/template@7.22.15, npm/@babel/traverse@7.23.6, npm/@babel/types@7.23.6, npm/@changesets/cli@2.27.1, npm/@coinbase/cbpay-js@1.2.0, npm/@coinflowlabs/react@3.1.5, npm/@elastic/elasticsearch@8.1.0, npm/@emotion/babel-plugin@11.11.0, npm/@emotion/babel-preset-css-prop@11.11.0, npm/@emotion/css@11.11.2, npm/@emotion/eslint-plugin@11.11.0, npm/@emotion/is-prop-valid@1.2.1, npm/@emotion/memoize@0.8.1, npm/@emotion/native@11.11.0, npm/@emotion/react@11.11.1, npm/@emotion/server@11.11.0, npm/@emotion/styled@11.11.0, npm/@emotion/unitless@0.8.1, npm/@escape.tech/mookme@2.4.1, npm/@eslint-community/regexpp@4.10.0, npm/@ethereumjs/common@3.2.0, npm/@ethereumjs/tx@4.2.0, npm/@fingerprintjs/fingerprintjs-pro-server-api@4.1.2, npm/@fingerprintjs/fingerprintjs-pro@3.5.6, npm/@google/model-viewer@3.3.0, npm/@gorhom/bottom-sheet@4.6.4, npm/@gorhom/portal@1.0.9, npm/@graphql-tools/merge@8.4.2, npm/@graphql-tools/schema@9.0.19, npm/@graphql-tools/utils@9.2.1, npm/@graphql-typed-document-node/core@3.2.0, npm/@hcaptcha/react-hcaptcha@0.3.6, npm/@humanwhocodes/config-array@0.11.13, npm/@isaacs/cliui@8.0.2, npm/@josephg/resolvable@1.0.1, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@jridgewell/trace-mapping@0.3.20, npm/@juggle/resize-observer@3.3.1, npm/@jup-ag/api@6.0.6, npm/alchemy-sdk@2.0.1, npm/prom-client@14.0.1

View full report↗︎

@socket-security

socket-securityBot commented Oct 1, 2024

Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

AlertPackageNoteSourceCI
AI-detected potential code anomaly npm/esm@3.2.25
  • Notes: The code exhibits behavior that allows for the dynamic loading and execution of untrusted code, which poses a significant security risk. The use of 'proto' directly on objects and manipulation of 'module' properties further increases the risk.
  • Confidence: 1.00
  • Severity: 0.60
🚫
Protestware or potentially unwanted behavior npm/es5-ext@0.10.64
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎

View full report↗︎

Next steps

What is an AI-detected potential code anomaly?

AI has identified unusual behaviors that may pose a security risk.

An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esm@3.2.25
  • @SocketSecurity ignore npm/es5-ext@0.10.64

@raymondjacobson
raymondjacobson merged commit 0c3f791 into mainOct 1, 2024
@raymondjacobson
raymondjacobson deleted the rj-pay-3439 branch October 1, 2024 04:31
schottra added a commit that referenced this pull request Oct 1, 2024
* origin/main: (27 commits)
[C-5022] Fix cached-image artwork and avatar (#9898)
[C-5058] Close reply input on submit (#9897)
[C-5028] Hide sort buttons with 1 or fewer comments (#9896)
[C-5070] Add comment count to artist dashboard (#9895)
updated hackathon banner (#9811)
Version Packages (#9822)
[PAY-3439] Add hono to create-audius-app (#9840)
Update minimal audiusd example (#9905)
endl/audiusd (#9870)
[QA-1750] Fix race cond in cc flow with token account creation (#9902)
Fixes zodError when purchasing album with Coinflow (#9903)
E2E muting users from comments (#9844)
[PAY-3344] Chat blast notifications (#9880)
fix sdk remixed tracks usage (#9901)
Disable payment router tests temporarily to unblock staging deploys (#9899)
Add recommended ddex docs (#9891)
Fix comment optimistic writes (#9876)
[PROTO-1935] Always relaunch under the hood in audius-ctl up (#9892)
[PAY-3198] New inbox settings modal layout (#9893)
Audius Protocol v0.7.1
...
audius-infra pushed a commit that referenced this pull request Oct 1, 2024
[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson
[9750c85] endl/audiusd (#9870) endline
[a7cc761] E2E muting users from comments (#9844) Isaac Solo
[b6106f3] [PAY-3344] Chat blast notifications (#9880) Reed
[fffb0a5] Disable payment router tests temporarily to unblock staging deploys (#9899) Marcus Pasell
schottra added a commit that referenced this pull request Oct 2, 2024
* origin/main:
[PAY-3455] Update unread element scroll function and fix chat page styling again (#9904)
Bump harmony by minor version (#9907)
[QA-1522] Update web scrubber to track audio player directly (#9894)
Audius Protocol v0.7.2
[C-5022] Fix cached-image artwork and avatar (#9898)
[C-5058] Close reply input on submit (#9897)
[C-5028] Hide sort buttons with 1 or fewer comments (#9896)
[C-5070] Add comment count to artist dashboard (#9895)
updated hackathon banner (#9811)
Version Packages (#9822)
[PAY-3439] Add hono to create-audius-app (#9840)
Update minimal audiusd example (#9905)
endl/audiusd (#9870)
[QA-1750] Fix race cond in cc flow with token account creation (#9902)
Fixes zodError when purchasing album with Coinflow (#9903)
E2E muting users from comments (#9844)
[PAY-3344] Chat blast notifications (#9880)
fix sdk remixed tracks usage (#9901)
Disable payment router tests temporarily to unblock staging deploys (#9899)
Add recommended ddex docs (#9891)
audius-infra pushed a commit that referenced this pull request Oct 5, 2024
[efdc0b2] Fix bottom sheet keyboard avoiding + compose ui (#9964) Sebastian Klingler
[235406d] [C-5097] Add backspace handling back to mobile ComposerInput (#9962) Kyle Shanks
[2e3a4db] [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Kyle Shanks
[160df4e] [QA-1748] Fix misc sign up issues (#9957) Raymond Jacobson
[5969168] [PAY-3493] Fix download gating on usdc feature flag (#9945) Raymond Jacobson
[f96333a] [C-5025] Add compose ui helper text (#9955) Sebastian Klingler
[d8db7ab] [C-5082] Comments desktop replies tweaks (#9954) JD Francis
[5bdf8ce] [C-5068] Convert comments a-query to tanstack-query (#9944) JD Francis
[17fb40e] Revert "[C-4493] Don't show deleted track rows in collections (#9209)" (#9951) Raymond Jacobson
[1ab28c9] [C-5071] Scroll to top for new comments on mobile (#9947) Sebastian Klingler
[2f2f187] [C-5072] Comment timestamp seeking (#9935) Sebastian Klingler
[0ba81b4] [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939) Kyle Shanks
[e569aac] [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924) Raymond Jacobson
[e6ad563] Version Packages (#9914) github-actions[bot]
[143c9d4] [QA-875] Fix short feed on web sign in (#9943) Isaac Solo
[65762e8] Fix composer position for comments (#9937) Sebastian Klingler
[a73cd6e] [C-4998] Add timestamp highlighting to mobile composer input (#9930) Kyle Shanks
[b408810] [QA-1749] Fix help alignment (#9923) Raymond Jacobson
[ea69846] [PAY-3199] Inbox Settings UI (mobile) (#9922) Andrew Mendelsohn
[4851999] [C-5002] Empty comments state for track owner (#9928) Sebastian Klingler
[371c9fd] [C-5057] Make comment overflow actions consistent with designs (#9920) Sebastian Klingler
[4d646d6] [PAY-3477] Initialize Hedgehog directly in client (#9909) Randy Schott
[57666cb] Move debug to externals (#9917) Randy Schott
[ce35265] Upgrade mobile apps to 116 (#9927) Dylan Jeffers
[0a2fe3d] Notify Slack on new purchases (#9921) Marcus Pasell
[9d02b9f] [PAY-3329] Remove monetization beta waitlist (#9913) Raymond Jacobson
[220ed1d] [QA-1724] Fix broken insta links (#9911) Raymond Jacobson
[b8c3171] Unblock CI (#9915) Raymond Jacobson
[969fd1f] Migrate to new user/tracks/remixed endpoint (#9900) Andrew Mendelsohn
[7d2233d] [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Kyle Shanks
[91f2e59] [QA-1522] Update web scrubber to track audio player directly (#9894) Randy Schott
[e69a986] [C-5022] Fix cached-image artwork and avatar (#9898) Dylan Jeffers
[5e764e6] [C-5058] Close reply input on submit (#9897) Dylan Jeffers
[5bc9a19] [C-5028] Hide sort buttons with 1 or fewer comments (#9896) Dylan Jeffers
[d2c0a82] [C-5070] Add comment count to artist dashboard (#9895) Dylan Jeffers
[3d84ce1] Version Packages (#9822) github-actions[bot]
[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson
[1260471] [QA-1750] Fix race cond in cc flow with token account creation (#9902) Raymond Jacobson
[9694ea4] Fixes zodError when purchasing album with Coinflow (#9903) Marcus Pasell
[a7cc761] E2E muting users from comments (#9844) Isaac Solo
[981d8f9] fix sdk remixed tracks usage (#9901) Andrew Mendelsohn
[dd52ab0] Fix comment optimistic writes (#9876) JD Francis
[8f4314f] [PAY-3198] New inbox settings modal layout (#9893) Andrew Mendelsohn
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
[efdc0b2] Fix bottom sheet keyboard avoiding + compose ui (#9964) Sebastian Klingler
[235406d] [C-5097] Add backspace handling back to mobile ComposerInput (#9962) Kyle Shanks
[2e3a4db] [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Kyle Shanks
[160df4e] [QA-1748] Fix misc sign up issues (#9957) Raymond Jacobson
[5969168] [PAY-3493] Fix download gating on usdc feature flag (#9945) Raymond Jacobson
[f96333a] [C-5025] Add compose ui helper text (#9955) Sebastian Klingler
[d8db7ab] [C-5082] Comments desktop replies tweaks (#9954) JD Francis
[5bdf8ce] [C-5068] Convert comments a-query to tanstack-query (#9944) JD Francis
[17fb40e] Revert "[C-4493] Don't show deleted track rows in collections (#9209)" (#9951) Raymond Jacobson
[1ab28c9] [C-5071] Scroll to top for new comments on mobile (#9947) Sebastian Klingler
[2f2f187] [C-5072] Comment timestamp seeking (#9935) Sebastian Klingler
[0ba81b4] [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939) Kyle Shanks
[e569aac] [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924) Raymond Jacobson
[e6ad563] Version Packages (#9914) github-actions[bot]
[143c9d4] [QA-875] Fix short feed on web sign in (#9943) Isaac Solo
[65762e8] Fix composer position for comments (#9937) Sebastian Klingler
[a73cd6e] [C-4998] Add timestamp highlighting to mobile composer input (#9930) Kyle Shanks
[b408810] [QA-1749] Fix help alignment (#9923) Raymond Jacobson
[ea69846] [PAY-3199] Inbox Settings UI (mobile) (#9922) Andrew Mendelsohn
[4851999] [C-5002] Empty comments state for track owner (#9928) Sebastian Klingler
[371c9fd] [C-5057] Make comment overflow actions consistent with designs (#9920) Sebastian Klingler
[4d646d6] [PAY-3477] Initialize Hedgehog directly in client (#9909) Randy Schott
[57666cb] Move debug to externals (#9917) Randy Schott
[ce35265] Upgrade mobile apps to 116 (#9927) Dylan Jeffers
[0a2fe3d] Notify Slack on new purchases (#9921) Marcus Pasell
[9d02b9f] [PAY-3329] Remove monetization beta waitlist (#9913) Raymond Jacobson
[220ed1d] [QA-1724] Fix broken insta links (#9911) Raymond Jacobson
[b8c3171] Unblock CI (#9915) Raymond Jacobson
[969fd1f] Migrate to new user/tracks/remixed endpoint (#9900) Andrew Mendelsohn
[7d2233d] [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Kyle Shanks
[91f2e59] [QA-1522] Update web scrubber to track audio player directly (#9894) Randy Schott
[e69a986] [C-5022] Fix cached-image artwork and avatar (#9898) Dylan Jeffers
[5e764e6] [C-5058] Close reply input on submit (#9897) Dylan Jeffers
[5bc9a19] [C-5028] Hide sort buttons with 1 or fewer comments (#9896) Dylan Jeffers
[d2c0a82] [C-5070] Add comment count to artist dashboard (#9895) Dylan Jeffers
[3d84ce1] Version Packages (#9822) github-actions[bot]
[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson
[1260471] [QA-1750] Fix race cond in cc flow with token account creation (#9902) Raymond Jacobson
[9694ea4] Fixes zodError when purchasing album with Coinflow (#9903) Marcus Pasell
[a7cc761] E2E muting users from comments (#9844) Isaac Solo
[981d8f9] fix sdk remixed tracks usage (#9901) Andrew Mendelsohn
[dd52ab0] Fix comment optimistic writes (#9876) JD Francis
[8f4314f] [PAY-3198] New inbox settings modal layout (#9893) Andrew Mendelsohn
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@raymondjacobson@audius-infra@samgutentag@sliptype