E2E muting users from comments by isaacsolo · Pull Request #9844 · AudiusProject/apps

isaacsolo · 2024-09-24T15:32:33Z

Description

E2E muting on web/mobile. Muting via comment will hide all comments from that user. The settings page has a comment settings modal where you can unmute users.

TODO mobile.

Fixes C-5043, C-5044

How Has This Been Tested?

Ran locally and confirmed muting and unmuting works with multiple comments and users.

Screen.Recording.2024-09-24.at.8.52.01.AM.mov

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

changeset-bot · 2024-09-24T15:32:37Z

⚠️ No Changeset found

Latest commit: a030c35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-09-24T15:32:39Z

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9412812	Triggered	Generic Password	`0264e8c`	packages/discovery-provider/ddl/docker-compose.yml	View secret
11648676	Triggered	Generic High Entropy Secret	`e2f478a`	dev-tools/templates/devnet.yaml	View secret
11648679	Triggered	Generic High Entropy Secret	`5b8e1c0`	core/infra/dev_config/standalone-console.env	View secret
11648680	Triggered	Generic High Entropy Secret	`e2f478a`	dev-tools/templates/devnet.yaml	View secret
13858032	Triggered	Generic Private Key	`e2f478a`	dev-tools/tls/devnet-key.pem	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-09-25T20:21:46Z

Preview this change https://demo.audius.co/is-e2e-mute

dylanjeffers

nice work!

DejayJD · 2024-09-27T23:15:04Z

+ {
+ userId: currentUserId!
+ },
+ { force: true }


Is this how you solved the stale data problem?

DejayJD · 2024-09-27T23:18:40Z

 {messages.notificationsDescription}
 </SettingsRowDescription>
 </SettingsRow>
+ <SettingsRow onPress={handlePressCommentSettings}>


I think you want to move the isCommentsEnabled here? Not sure how this looks but I would imagine we remove the whole row if it's not enabled

DejayJD

Re-reviewed just the mobile stuff; its looking real good but just a few changes and its ready!
The main blocker is that the feature flag comment. The common move would also be good but not technically a blocker

sliptype

Huge lift! I agree with jd's comments/qs

audius-infra · 2024-09-30T21:54:42Z

Preview this change https://demo.audius.co/is-e2e-mute

audius-infra · 2024-09-30T22:26:08Z

Preview this change https://demo.audius.co/is-e2e-mute

* origin/main: (27 commits) [C-5022] Fix cached-image artwork and avatar (#9898) [C-5058] Close reply input on submit (#9897) [C-5028] Hide sort buttons with 1 or fewer comments (#9896) [C-5070] Add comment count to artist dashboard (#9895) updated hackathon banner (#9811) Version Packages (#9822) [PAY-3439] Add hono to create-audius-app (#9840) Update minimal audiusd example (#9905) endl/audiusd (#9870) [QA-1750] Fix race cond in cc flow with token account creation (#9902) Fixes zodError when purchasing album with Coinflow (#9903) E2E muting users from comments (#9844) [PAY-3344] Chat blast notifications (#9880) fix sdk remixed tracks usage (#9901) Disable payment router tests temporarily to unblock staging deploys (#9899) Add recommended ddex docs (#9891) Fix comment optimistic writes (#9876) [PROTO-1935] Always relaunch under the hood in audius-ctl up (#9892) [PAY-3198] New inbox settings modal layout (#9893) Audius Protocol v0.7.1 ...

[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson [9750c85] endl/audiusd (#9870) endline [a7cc761] E2E muting users from comments (#9844) Isaac Solo [b6106f3] [PAY-3344] Chat blast notifications (#9880) Reed [fffb0a5] Disable payment router tests temporarily to unblock staging deploys (#9899) Marcus Pasell

* origin/main: [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Bump harmony by minor version (#9907) [QA-1522] Update web scrubber to track audio player directly (#9894) Audius Protocol v0.7.2 [C-5022] Fix cached-image artwork and avatar (#9898) [C-5058] Close reply input on submit (#9897) [C-5028] Hide sort buttons with 1 or fewer comments (#9896) [C-5070] Add comment count to artist dashboard (#9895) updated hackathon banner (#9811) Version Packages (#9822) [PAY-3439] Add hono to create-audius-app (#9840) Update minimal audiusd example (#9905) endl/audiusd (#9870) [QA-1750] Fix race cond in cc flow with token account creation (#9902) Fixes zodError when purchasing album with Coinflow (#9903) E2E muting users from comments (#9844) [PAY-3344] Chat blast notifications (#9880) fix sdk remixed tracks usage (#9901) Disable payment router tests temporarily to unblock staging deploys (#9899) Add recommended ddex docs (#9891)

[efdc0b2] Fix bottom sheet keyboard avoiding + compose ui (#9964) Sebastian Klingler [235406d] [C-5097] Add backspace handling back to mobile ComposerInput (#9962) Kyle Shanks [2e3a4db] [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Kyle Shanks [160df4e] [QA-1748] Fix misc sign up issues (#9957) Raymond Jacobson [5969168] [PAY-3493] Fix download gating on usdc feature flag (#9945) Raymond Jacobson [f96333a] [C-5025] Add compose ui helper text (#9955) Sebastian Klingler [d8db7ab] [C-5082] Comments desktop replies tweaks (#9954) JD Francis [5bdf8ce] [C-5068] Convert comments a-query to tanstack-query (#9944) JD Francis [17fb40e] Revert "[C-4493] Don't show deleted track rows in collections (#9209)" (#9951) Raymond Jacobson [1ab28c9] [C-5071] Scroll to top for new comments on mobile (#9947) Sebastian Klingler [2f2f187] [C-5072] Comment timestamp seeking (#9935) Sebastian Klingler [0ba81b4] [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939) Kyle Shanks [e569aac] [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924) Raymond Jacobson [e6ad563] Version Packages (#9914) github-actions[bot] [143c9d4] [QA-875] Fix short feed on web sign in (#9943) Isaac Solo [65762e8] Fix composer position for comments (#9937) Sebastian Klingler [a73cd6e] [C-4998] Add timestamp highlighting to mobile composer input (#9930) Kyle Shanks [b408810] [QA-1749] Fix help alignment (#9923) Raymond Jacobson [ea69846] [PAY-3199] Inbox Settings UI (mobile) (#9922) Andrew Mendelsohn [4851999] [C-5002] Empty comments state for track owner (#9928) Sebastian Klingler [371c9fd] [C-5057] Make comment overflow actions consistent with designs (#9920) Sebastian Klingler [4d646d6] [PAY-3477] Initialize Hedgehog directly in client (#9909) Randy Schott [57666cb] Move debug to externals (#9917) Randy Schott [ce35265] Upgrade mobile apps to 116 (#9927) Dylan Jeffers [0a2fe3d] Notify Slack on new purchases (#9921) Marcus Pasell [9d02b9f] [PAY-3329] Remove monetization beta waitlist (#9913) Raymond Jacobson [220ed1d] [QA-1724] Fix broken insta links (#9911) Raymond Jacobson [b8c3171] Unblock CI (#9915) Raymond Jacobson [969fd1f] Migrate to new user/tracks/remixed endpoint (#9900) Andrew Mendelsohn [7d2233d] [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Kyle Shanks [91f2e59] [QA-1522] Update web scrubber to track audio player directly (#9894) Randy Schott [e69a986] [C-5022] Fix cached-image artwork and avatar (#9898) Dylan Jeffers [5e764e6] [C-5058] Close reply input on submit (#9897) Dylan Jeffers [5bc9a19] [C-5028] Hide sort buttons with 1 or fewer comments (#9896) Dylan Jeffers [d2c0a82] [C-5070] Add comment count to artist dashboard (#9895) Dylan Jeffers [3d84ce1] Version Packages (#9822) github-actions[bot] [0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson [1260471] [QA-1750] Fix race cond in cc flow with token account creation (#9902) Raymond Jacobson [9694ea4] Fixes zodError when purchasing album with Coinflow (#9903) Marcus Pasell [a7cc761] E2E muting users from comments (#9844) Isaac Solo [981d8f9] fix sdk remixed tracks usage (#9901) Andrew Mendelsohn [dd52ab0] Fix comment optimistic writes (#9876) JD Francis [8f4314f] [PAY-3198] New inbox settings modal layout (#9893) Andrew Mendelsohn

isaac added 7 commits September 17, 2024 15:30

wip
aff744e

wip
0bb50a0

Merge branch 'main' into is-e2e-mute
0264e8c

looking right
c74d576

pre merge
85eb60c

Merge branch 'main' into is-e2e-mute
e2f478a

working
95388b0

pull-request-sizeBot added the size/XL label Sep 24, 2024

isaacsolo force-pushed the is-e2e-mute branch 4 times, most recently from 28511f7 to cafbe52Compare September 24, 2024 15:43

pull-request-sizeBot added size/L and removed size/XL labels Sep 24, 2024

isaacsolo requested review from DejayJD and dylanjeffers September 24, 2024 15:43

clean
c513a9d

isaacsolo force-pushed the is-e2e-mute branch from cafbe52 to c513a9dCompare September 24, 2024 15:57

pull-request-sizeBot added size/XL and removed size/L labels Sep 24, 2024

fix up setting text
0d48595

isaacsolo force-pushed the is-e2e-mute branch from d7dd759 to 0d48595Compare September 24, 2024 17:38

isaac added 3 commits September 24, 2024 10:50

clean up imports
bf05121

Merge branch 'main' into is-e2e-mute
ee929e4

merge
8cc62b9

DejayJD reviewed Sep 24, 2024
View reviewed changes

Comment threadpackages/common/src/api/comments.ts

DejayJD reviewed Sep 24, 2024
View reviewed changes

Comment threadpackages/common/src/context/comments/commentsHooks.ts

DejayJD reviewed Sep 24, 2024
View reviewed changes

Comment threadpackages/discovery-provider/src/api/v1/users.py Outdated

isaac added 2 commits September 26, 2024 12:46

wip
86a452d

looks right
10b7790

dylanjeffers approved these changes Sep 27, 2024
View reviewed changes

working
917f193

pull-request-sizeBot added size/XL and removed size/L labels Sep 27, 2024

isaacsolo changed the title ~~E2E muting on web~~E2E muting users from commentsSep 27, 2024

DejayJD reviewed Sep 27, 2024
View reviewed changes

Comment threadpackages/mobile/src/screens/settings-screen/CommentSettingsScreen.tsx Outdated

DejayJD reviewed Sep 27, 2024
View reviewed changes

Comment threadpackages/mobile/src/screens/settings-screen/CommentSettingsScreen.tsx Outdated

DejayJD reviewed Sep 27, 2024
View reviewed changes

Comment threadpackages/web/src/components/comment-settings-modal/CommentSettingsModal.tsx

sliptype approved these changes Sep 30, 2024
View reviewed changes

Comment threadpackages/mobile/src/screens/settings-screen/CommentSettingsScreen.tsx Outdated
Comment threadpackages/web/src/components/comment-settings-modal/CommentSettingsModal.tsx
Comment threadpackages/web/src/pages/settings-page/components/desktop/SettingsCard.module.css

address more comments
b955056

isaacsolo force-pushed the is-e2e-mute branch from 1450f07 to b955056Compare September 30, 2024 21:14

isaac added 2 commits September 30, 2024 14:20

Merge branch 'main' into is-e2e-mute
5b8e1c0

fix type
8decf38

fix tombstoned
a030c35

isaacsolo enabled auto-merge (squash) September 30, 2024 22:15

isaacsolo merged commit a7cc761 into mainSep 30, 2024

isaacsolo deleted the is-e2e-mute branch September 30, 2024 22:43

Uh oh!

Conversation

isaacsolo commented Sep 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Sep 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardianBot commented Sep 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Sep 25, 2024

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DejayJDSep 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DejayJDSep 27, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Sep 30, 2024

Uh oh!

audius-infra commented Sep 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isaacsolo commented Sep 24, 2024•
edited
Loading

changeset-botBot commented Sep 24, 2024•
edited
Loading

gitguardianBot commented Sep 24, 2024•
edited
Loading