{Resource} Remove Virtual Terminal related code - #23531
Merged
Merged
Conversation
Jiashuo Li (jiasli)
removed request for
Yong Zhang (yonzhan) and
Xing Zhou (zhoxing-ms)
August 15, 2022 07:53
Jiashuo Li (jiasli)
force-pushed
the
vt
branch
from
August 15, 2022 08:09
948483a to
db56222
Compare
Collaborator
|
Resource |
Shenglong Li (shenglol)
approved these changes
Aug 15, 2022
Contributor
There was a problem hiding this comment.
Looks good! But it would be great if we can run a few What-If commands to test it once https://github.com/microsoft/knack/pull/265/files is merged and released.
Contributor
Author
|
Shenglong Li (@shenglol), thanks for the confirmation. Actually, you may install the dev version of knack using |
Jiashuo Li (jiasli)
marked this pull request as ready for review
August 18, 2022 04:01
Jiashuo Li (jiasli)
requested review from
Yu Chen (jsntcy) and
Xing Zhou (zhoxing-ms)
as code owners
August 18, 2022 04:01
Yishi Wang (evelyn-ys)
approved these changes
Aug 18, 2022
Jiashuo Li (jiasli)
requested review from
Zhiyi Huang (calvinhzy),
kai ru (kairu-ms) and
Ethan Yang (necusjz)
as code owners
August 19, 2022 06:09
Xing Zhou (zhoxing-ms)
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az deployment sub what-ifaz deployment group what-ifDescription
Require microsoft/knack#265
microsoft/knack#265 moves Virtual Terminal related code (introduced by Shenglong Li (@shenglol) in #12942) to Knack. Big thanks to Shenglong Li (@shenglol).
Since VT mode in now globally enabled,
resourcemodule doesn't need to enable it specifically.