Enable Virtual Terminal mode on legacy Windows terminal to support ANSI escape sequences - #265
Merged
Merged
Conversation
Comment on lines
-252
to
-255
| if self._should_init_colorama: | ||
| import colorama | ||
| colorama.deinit() | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I don't see any side effect if we don't disable it.
Yishi Wang (evelyn-ys)
approved these changes
Aug 15, 2022
Xing Zhou (zhoxing-ms)
approved these changes
Aug 18, 2022
Jiashuo Li (jiasli)
marked this pull request as ready for review
August 18, 2022 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from Azure/azure-cli#12942
This PRs totally removes colorama, getting us rid of colorama bugs.
Windows versions before Windows 10 1607 are not supported anymore. Colors are automatically disabled on those jurassic period terminals 🦖.
When Windows Terminal becomes universal, even
_win_vt.pyshould be dropped.