Table format revisions - #748
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
command_table[args.command].simple_output_query [](start = 33, length = 47)
Will you have a separate PR to remove all existing simple_output_queries or are you going to do that as an iteration on this PR? #Resolved
Member
Author
There was a problem hiding this comment.
Separate #Resolved
Derek Bekoe (derekbekoe)
force-pushed
the
better-table
branch
from
August 25, 2016 22:21
edf4014 to
2cca8c9
Compare
Member
|
How do we choose which properties to display if there are too many for the screen width? Is there some kind of priority heuristic or is it the order they appear in the results? #Resolved |
Member
Author
|
It's the order they appear in the results. #Resolved |
Member
There was a problem hiding this comment.
If simple output query is just the callable, why not rename it "table_transformer" or something. The old name was always pretty vague and now it's REALLY vague considering it only does that one thing. You shouldn't need the callable check on it now since we're saying that the callable is the only supported thing. If a dev passed a query string he should be given an error message he can debug rather than have it simply ignore him (or her). :) #Resolved
Member
Author
There was a problem hiding this comment.
Yep agreed but since I plan to remove the jmespath queries in another PR, I still needed the if statement.
The name will also change from simple_output_query. #Resolved
Member
|
|
- Table output is generic and automatically extracts fields from the result. - No longer use simple_output_query as it was specific for commands and as packages will support multiple API versions, this solution is no longer feasible.
When a callable is set for a command, it will be used as long as there is no query active. If there's a query active, the callable will not be used so the user has to specify a full query that can generate an appropriate table.
Derek Bekoe (derekbekoe)
force-pushed
the
better-table
branch
from
August 26, 2016 21:25
2cca8c9 to
de02821
Compare
Johan Stenberg (ex-msft) (johanste)
added a commit
that referenced
this pull request
Aug 31, 2016
* Provide support for reading a single parameter value from file Values prefixed with @ will be replaced with the content of the file immediately following the @-sign. The pseudo-name '-' is used to indicate stdin. * Fix accidentally deleted space (which made pylint angry) * enable diagnostics and extensions in vmss profile (#737) * Expose generic update parameters on existing custom updates (#735) * Convert all updates to cli_generic_update_commands. * Code review fixes. * Remove inline CliArgumentType(...) registrations (#744) * Eliminates anti-pattern of creating CliArgumentTypes inline during parameter registration. * Minor fixes. * Add NAT Rules to VMSS create that allow SSH/RDP by default (#743) * Update regular expression to fix issue #147 (#747) * Support colored output on Windows (#756) * [Help] Help Fixes and Enhancements (#736) * Fix issue #680. * Initial version of help dump. Logic to extract summary. * Fix issues #365 and #447. * Code review fixes. * Code review fixes. * Fix folded parameter logic to make new optional. Update existing uses to (#766) work with new logic. * Treat CloudError like a CLIError (don't print stack trace) (#759) * 'az configure' experience (default output format) (#739) * 'az configure' experience - Allows user to set default output type. - Infrastructure for CLI configurations also implemented. * Add license header & fix deprecated method * Wrap SafeConfigParser instead of extending from it * Code review feedback changes * Table format revisions (#748) * Table format revisions - Table output is generic and automatically extracts fields from the result. - No longer use simple_output_query as it was specific for commands and as packages will support multiple API versions, this solution is no longer feasible. * Support callable again for table format after discussion When a callable is set for a command, it will be used as long as there is no query active. If there's a query active, the callable will not be used so the user has to specify a full query that can generate an appropriate table. * Remove 'starting' message for long running operations (#767) * Remove 'starting' message for long running operations * Change name of poll_interval_ms as ambiguous and also change logger messages that referred to this interval * Catch EOF to minimize stack trace craziness. (#768) * Change simple_output_query to be table_transformer (#771) * [Resource] Resource Tag Fix (issue 763) (#765) * Use 'ignore_type' within resource module. Fix issue 763. * Code review fixes. * Only delete certain files in yml output folder during Document CI (#762) * Update README Docker instructions. (#776) * Fixes #772 (#779) * Handle BrokenPipeError (#775) * Fix issue 770. * Fix undeclared-variable * update a few command descriptions (#781) * VM issue: fix #749, #753, #575 (#778) * Add commands for Azure IoT (#730) * Add commands for Azure IoT * 1.Include files into azure-cli.pyproj; 2. Update license info in setup.py * add missing pylint directive * resolve review comments * resolve comments * fix typo * [Document CI] Handle Robocopy exit code (#786) * Generic Update enhancements. (#740) * Fix issues #728 and #686 * Code review fixes. * Fix Error if Non-existent Storage Account Specified (#787) * Fix issue #784. * Code review fix. * vm: enable autoUpgradeMinorVersion by default (#791) * cmd: use plurals for list-* command naming (#792) Committer: yugangw-msft * Ensure docstring help with unrecognized unicode characters still displays correctly. (#795) * Provide support for reading a single parameter value from file Values prefixed with @ will be replaced with the content of the file immediately following the @-sign. The pseudo-name '-' is used to indicate stdin. * Fix accidentally deleted space (which made pylint angry)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #705, fixes #704, fixes #652