Skip to content

Remove 'starting' message for long running operations - #767

Merged
Derek Bekoe (derekbekoe) merged 2 commits into
Azure:masterfrom
derekbekoe:fix-lro-start-msg
Aug 26, 2016
Merged

Derek Bekoe (derekbekoe) merged 2 commits into
Azure:masterfrom
derekbekoe:fix-lro-start-msg

Conversation

@derekbekoe

Copy link
Copy Markdown
Member

Fixes #764

@tjprescott

Travis Prescott (tjprescott) commented Aug 26, 2016

Copy link
Copy Markdown
Member
def __init__(self, start_msg='', finish_msg='', poll_interval_ms=1000.0):

Is there any reason to keep these around? #Resolved


Refers to: src/azure/cli/commands/init.py:87 in 49bf67f. [](commit_id = 49bf67f66262f9d8461440ee2ee02f523b331264, deletion_comment = True)

@tjprescott

Travis Prescott (tjprescott) commented Aug 26, 2016

Copy link
Copy Markdown
Member
def __init__(self, start_msg='', finish_msg='', poll_interval_ms=1000.0):

Johan talked about changing this name (poll_interval_ms), because it doesn't do what it sounds like it does. #Resolved


Refers to: src/azure/cli/commands/init.py:87 in e78364d. [](commit_id = e78364d, deletion_comment = True)

@derekbekoe

Derek Bekoe (derekbekoe) commented Aug 26, 2016

Copy link
Copy Markdown
Member Author

start_msg is used for the log messages. #Resolved

@derekbekoe

Copy link
Copy Markdown
Member Author

Travis Prescott (@tjprescott) Isn't it the interval for checking when the poller is done?
Or is the confusion that it could be interpreted as the interval that the poller itself makes requests.

@johanste

Copy link
Copy Markdown
Contributor

The latter. Yes. It would very likely be interpreted as how often the client/CLI pings the service.

From: Derek Bekoe [mailto:notifications@github.com]
Sent: Friday, August 26, 2016 2:23 PM
To: Azure/azure-cli azure-cli@noreply.github.com
Subject: Re: [Azure/azure-cli] Remove 'starting' message for long running operations (#767)

@tjprescotthttps://github.com/tjprescott Isn't it the interval for checking when the poller is done?
Or is the confusion that it could be interpreted as the interval that the poller itself makes requests.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/767#issuecomment-242855260, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOaPghLp-Q-GcRCV1Or9rGMuV2kup39sks5qj1kvgaJpZM4Jud7G.

@derekbekoe

Copy link
Copy Markdown
Member Author

@tjprescott

Copy link
Copy Markdown
Member

:shipit:

@derekbekoe
Derek Bekoe (derekbekoe) merged commit 8000d63 into Azure:master Aug 26, 2016
@derekbekoe
Derek Bekoe (derekbekoe) deleted the fix-lro-start-msg branch August 26, 2016 22:08
Johan Stenberg (ex-msft) (johanste) added a commit that referenced this pull request Aug 31, 2016
* Provide support for reading a single parameter value from file

Values prefixed with @ will be replaced with the content of the file immediately following the @-sign.

The pseudo-name '-' is used to indicate stdin.

* Fix accidentally deleted space (which made pylint angry)

* enable diagnostics and extensions in vmss profile (#737)

* Expose generic update parameters on existing custom updates (#735)

* Convert all updates to cli_generic_update_commands.

* Code review fixes.

* Remove inline CliArgumentType(...) registrations (#744)

* Eliminates anti-pattern of creating CliArgumentTypes inline during parameter registration.

* Minor fixes.

* Add NAT Rules to VMSS create that allow SSH/RDP by default (#743)

* Update regular expression to fix issue #147 (#747)

* Support colored output on Windows (#756)

* [Help] Help Fixes and Enhancements (#736)

* Fix issue #680.

* Initial version of help dump. Logic to extract summary.

* Fix issues #365 and #447.

* Code review fixes.

* Code review fixes.

* Fix folded parameter logic to make new optional. Update existing uses to (#766)

work with new logic.

* Treat CloudError like a CLIError (don't print stack trace) (#759)

* 'az configure' experience (default output format) (#739)

* 'az configure' experience

- Allows user to set default output type.
- Infrastructure for CLI configurations also implemented.

* Add license header & fix deprecated method

* Wrap SafeConfigParser instead of extending from it

* Code review feedback changes

* Table format revisions (#748)

* Table format revisions

- Table output is generic and automatically extracts fields from the result.
- No longer use simple_output_query as it was specific for commands and as packages will support multiple API versions, this solution is no longer feasible.

* Support callable again for table format after discussion

When a callable is set for a command, it will be used as long as there is no query active.
If there's a query active, the callable will not be used so the user has to specify a full query that can generate an appropriate table.

* Remove 'starting' message for long running operations (#767)

* Remove 'starting' message for long running operations

* Change name of poll_interval_ms as ambiguous and also change logger messages that referred to this interval

* Catch EOF to minimize stack trace craziness. (#768)

* Change simple_output_query to be table_transformer (#771)

* [Resource] Resource Tag Fix (issue 763) (#765)

* Use 'ignore_type' within resource module. Fix issue 763.

* Code review fixes.

* Only delete certain files in yml output folder during Document CI (#762)

* Update README Docker instructions. (#776)

* Fixes #772 (#779)

* Handle BrokenPipeError (#775)

* Fix issue 770.

* Fix undeclared-variable

* update a few command descriptions (#781)

* VM issue: fix #749, #753, #575 (#778)

* Add commands for Azure IoT (#730)

* Add commands for Azure IoT

* 1.Include files into azure-cli.pyproj; 2. Update license info in setup.py

* add missing pylint directive

* resolve review comments

* resolve comments

* fix typo

* [Document CI] Handle Robocopy exit code (#786)

* Generic Update enhancements. (#740)

* Fix issues #728 and #686

* Code review fixes.

* Fix Error if Non-existent Storage Account Specified (#787)

* Fix issue #784.

* Code review fix.

* vm: enable autoUpgradeMinorVersion by default (#791)

* cmd: use plurals for list-* command naming (#792)

Committer: yugangw-msft

* Ensure docstring help with unrecognized unicode characters still displays correctly. (#795)

* Provide support for reading a single parameter value from file

Values prefixed with @ will be replaced with the content of the file immediately following the @-sign.

The pseudo-name '-' is used to indicate stdin.

* Fix accidentally deleted space (which made pylint angry)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants