disable warning from Functional header - #2352
Merged
Victor Vazquez (vhvb1989) merged 2 commits intoMay 26, 2021
Merged
Conversation
Victor Vazquez (vhvb1989)
requested review from
Rick Winter (RickWinter),
Ahson Khan (ahsonkhan) and
Anton Kolesnyk (antkmsft)
as code owners
May 26, 2021 19:17
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ahson Khan (ahsonkhan)
approved these changes
May 26, 2021
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Victor Vazquez (vhvb1989)
enabled auto-merge (squash)
May 26, 2021 22:32
| # Disable warnings: | ||
| # - C6285: (<non-zero constant> || <non-zero constant>) -> VBProject static analysis on Functional header: | ||
| # _Is_large, regression from VS version 19.28.29915.0 to 19.29.30037.0 | ||
| target_compile_options(azure-core PUBLIC /wd6285) |
There was a problem hiding this comment.
Is there a bug we can track for the fix, i.e. when can we turn this back on?
Contributor
There was a problem hiding this comment.
Presumably the change that triggered this is microsoft/STL#698? The documentation suggests this warning should never fire for <boolean constant expression> || <boolean constant expression>, so I can't see this as anything other than a compiler bug. Please file a bug report with a minimal repro on Developer Community.
Member
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2351