Skip to content

<functional>: std::function doesn't handle over-aligned types - #698

Merged
Stephan T. Lavavej (StephanTLavavej) merged 28 commits into
microsoft:masterfrom
AlexGuteniev:function_alinged
Apr 22, 2020
Merged

<functional>: std::function doesn't handle over-aligned types#698
Stephan T. Lavavej (StephanTLavavej) merged 28 commits into
microsoft:masterfrom
AlexGuteniev:function_alinged

Conversation

@AlexGuteniev

@AlexGuteniev Alex Guteniev (AlexGuteniev) commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

#690 , starting with tests to make sure they fail

@AlexGuteniev Alex Guteniev (AlexGuteniev) mentioned this pull request Apr 9, 2020
Closed
AlexGuteniev
Alex Guteniev (AlexGuteniev) commented Apr 9, 2020
View reviewed changes
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
@AlexGuteniev
Alex Guteniev (AlexGuteniev) marked this pull request as ready for review April 9, 2020 05:26
@AlexGuteniev
Alex Guteniev (AlexGuteniev) requested a review from a team as a code owner April 9, 2020 05:26
@miscco

Michael Schellenberger Costa (miscco) commented Apr 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Could you please move development offline?

I try to follow the development of the STL and if you push every single commit it really spams my inbox. This PR alone was 6 mails

It would be great if you could finish a task and then push that for review not every step in between.

@AlexGuteniev

Alex Guteniev (AlexGuteniev) commented Apr 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It would be great if you could finish a task and then push that for review not every step in between.

I'll try, but it is not always possible.

I did make this change locally working, including local test run. Test failure on CI was unexpected, but that's what CI is about - to run more tests under more conditions than I would do locally.

Also I deliberately added tests before the fix to make sure that if tests pass, they really pass, not ignored. This caused extra commit.

@CaseyCarter Casey Carter (CaseyCarter) added the bug Something isn't working label Apr 9, 2020
@CaseyCarter Casey Carter (CaseyCarter) linked an issue Apr 9, 2020 that may be closed by this pull request
<functional>: std::function doesn't handle over-aligned types #690
Closed
CaseyCarter
Casey Carter (CaseyCarter) suggested changes Apr 9, 2020
View reviewed changes
Comment thread stl/inc/functional Outdated
Comment thread tests/std/test.lst Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
BillyONeal
Billy O'Neal (BillyONeal) approved these changes Apr 9, 2020
View reviewed changes
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/VSO_1062649_overaligned_function/test.cpp Outdated
CaseyCarter
Casey Carter (CaseyCarter) suggested changes Apr 9, 2020
View reviewed changes

@CaseyCarter Casey Carter (CaseyCarter) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last static_assert issue here and this looks good to me.

Comment thread tests/std/tests/GH_000690_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/GH_000690_overaligned_function/test.cpp Outdated
CaseyCarter
Casey Carter (CaseyCarter) reviewed Apr 9, 2020
View reviewed changes
Comment thread stl/inc/functional Outdated
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) requested changes Apr 9, 2020
View reviewed changes
Comment thread stl/inc/functional Outdated
Comment thread stl/inc/functional Outdated
Comment thread tests/std/tests/GH_000690_overaligned_function/test.cpp Outdated
Comment thread tests/std/tests/GH_000690_overaligned_function/test.cpp Outdated
BillyONeal
Billy O'Neal (BillyONeal) reviewed Apr 10, 2020
View reviewed changes
Comment thread stl/inc/atomic Outdated
@AlexGuteniev
Revert "Removing macros, now I have ICE"
01d8f43 
This reverts commit 76bfccb.
It was meant for another branch
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) approved these changes Apr 21, 2020
View reviewed changes

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I pushed very small edits to the comments. Now I'll mirror this to the Microsoft-internal repo and merge this soon.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 97f9a2c into microsoft:master Apr 22, 2020
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Apr 22, 2020

Copy link
Copy Markdown
Member

Thanks for this significant bugfix! 🎉

@AlexGuteniev
Alex Guteniev (AlexGuteniev) deleted the function_alinged branch April 23, 2020 14:40
@CaseyCarter Casey Carter (CaseyCarter) mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal Billy O'Neal (BillyONeal) BillyONeal approved these changes
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+1 more reviewer
@CaseyCarter Casey Carter (CaseyCarter) CaseyCarter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<functional>: std::function doesn't handle over-aligned types

5 participants

@AlexGuteniev @miscco @StephanTLavavej @CaseyCarter @BillyONeal