Skip to content

Include Exception Types at FailureDetails - #1237

Merged
Naiyuan Tian (nytian) merged 13 commits into
mainfrom
nytian/failure-details-excep
Oct 3, 2025
Merged

Include Exception Types at FailureDetails#1237
Naiyuan Tian (nytian) merged 13 commits into
mainfrom
nytian/failure-details-excep

Conversation

@nytian

@nytianNaiyuan Tian (nytian) commented Sep 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR introduces support for including custom exception properties in FailureDetails.

Customers can register the interface IExceptionPropertiesProvider at TaskhubWorker that specifies which exception types and properties should be included.

IExceptionPropertiesProvider is a property on TaskHubWorker. We pass the provider to each dispatcher and then to the TaskContext. As a result, when orchestration or activity tasks are executed, use the provided implementation at TaskContext to generate FailureDetails to include the specified exception properties.

cgillum
Chris Gillum (cgillum) reviewed Sep 3, 2025
View reviewed changes
Comment threadsrc/DurableTask.Core/FailureDetails.cs Outdated
Comment threadsrc/DurableTask.Core/ExceptionPropertiesProviderRegistry.cs Outdated
Comment threadsrc/DurableTask.Core/ExceptionPropertiesProviderRegistry.cs Outdated
@nytian
Naiyuan Tian (nytian) marked this pull request as draft September 29, 2025 23:17
@nytian
Naiyuan Tian (nytian) marked this pull request as ready for review September 30, 2025 01:29
nytian
Naiyuan Tian (nytian) commented Sep 30, 2025
View reviewed changes
Comment threadsrc/DurableTask.Core/FailureDetails.cs Outdated
cgillum
Chris Gillum (cgillum) reviewed Oct 1, 2025
View reviewed changes

@cgillumChris Gillum (cgillum) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some small simplifications and refactoring.

Comment threadsrc/DurableTask.Core/FailureDetails.cs Outdated
Comment threadsrc/DurableTask.Core/FailureDetails.cs Outdated
Comment threadsrc/DurableTask.Core/ReflectionBasedTaskActivity.cs Outdated
Comment threadsrc/DurableTask.Core/TaskActivityDispatcher.cs
Comment threadsrc/DurableTask.Core/TaskEntityDispatcher.cs
Comment threadsrc/DurableTask.Core/TaskOrchestrationContext.cs Outdated
Comment threadsrc/DurableTask.Core/TaskOrchestrationDispatcher.cs
@nytianNaiyuan Tian (nytian) mentioned this pull request Oct 2, 2025
Merged
@nytian
Naiyuan Tian (nytian) merged commit 04290b7 into mainOct 3, 2025
44 checks passed
@nytian
Naiyuan Tian (nytian) deleted the nytian/failure-details-excep branch October 3, 2025 15:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgillumChris Gillum (cgillum)cgillum approved these changes
@bachuvVarshitha Bachu (bachuv)Awaiting requested review from bachuv
@andystaplesandystaplesAwaiting requested review from andystaples
@sophiatevsophiatevAwaiting requested review from sophiatev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nytian@cgillum