Include Exception Properties at FailureDetails by nytian · Pull Request #474 · microsoft/durabletask-dotnet

Naiyuan Tian (nytian) · 2025-10-02T15:25:00Z

This PR supports register custom provider that help include exception properties at TaskFailureDetails. Supports include running with both DurableTaskWorker and Durable Functions (.NET Isolated).

Note: related PR :

durabletask.core : Include Exception Types at FailureDetails Azure/durabletask#1237
durabletask.protobuf: Add properties Field to TaskFailureDetails durabletask-protobuf#45

Naiyuan Tian (nytian) · 2025-10-02T16:38:03Z

 }
 }

- static P.TaskFailureDetails? GetFailureDetails(FailureDetails? failureDetails)


remove this because we will call the one at ptobufutils instead

Naiyuan Tian (nytian) · 2025-10-02T17:50:15Z

 exception.StackTrace,
- FromExceptionRecursive(exception.InnerException));
+ FromExceptionRecursive(exception.InnerException),
+ null);// might need to udpate this later 


Question for the public static TaskFailureDetails FromException(Exception exception)
I checked all the reference, and it seems all the cases we called this is when the exception is a DTCore.OrchestrationExcep, which means it should already have properties included. Thus currently we don't need to extract properties here.
But I am not sure if there might be a case when the exception is not from dt.core and this return new FailureDetails block is reached. If so, then we need to extract properties in this repo, which means I need to update OrchestrationContextWrapper class etc. But I didn't find a case like this from current code path. Let me know if there is any other thought on this.

…rosoft/durabletask-dotnet into nytian/failure-details-excep

Naiyuan Tian (nytian) · 2025-10-06T04:00:14Z

+ ? new(new(p.Name), p.OrchestrationInstance.InstanceId)
+ : null;
+
+ DurableTaskShimFactory factory = services is null


I only updated line 211 to 226.. the whole file changed because of the VS outlining thing

I was able to read it properly if I turned off whitespace in the diff view. This can happen sometimes if VS or the git client changes the line endings.

Chris Gillum (cgillum)

A few initial comments. Haven't reviewed everything yet.

Chris Gillum (cgillum) · 2025-10-07T00:49:31Z

@@ -1,2 +1,2 @@
-# The following files were downloaded from branch main at 2025-09-17 01:45:58 UTC
-https://raw.githubusercontent.com/microsoft/durabletask-protobuf/f5745e0d83f608d77871c1894d9260ceaae08967/protos/orchestrator_service.proto
+# The following files were downloaded from branch nytian/failure-details at 2025-10-01 21:51:24 UTC


Reminder to update this to main once the protobuf changes in durabletask-protobuf are merged.

Phillip Hoff (philliphoff)

LGTM, apart from the note about updating the protobuf definitions once that related change is committed.

Chris Gillum (cgillum)

I finished reviewing everything and have a few more minor comments.

Chris Gillum (cgillum) · 2025-10-10T19:35:24Z

 /// </remarks>
 public class DurableTaskShimFactory
 {
+ public readonly IExceptionPropertiesProvider? exceptionPropertiesProvider;


Was making this public an accident? We should never have public fields.

oh thanks for reminding. I added these at first because I thought we need this when using with durable functions isolated. But the test turns out actually we don't need to propagate provider from worker extensions to here. I just deleted these.

Chris Gillum (cgillum) · 2025-10-10T19:42:15Z

+ ? new(new(p.Name), p.OrchestrationInstance.InstanceId)
+ : null;
+
+ DurableTaskShimFactory factory = services is null


I was able to read it properly if I turned off whitespace in the diff view. This can happen sometimes if VS or the git client changes the line endings.

Chris Gillum (cgillum) · 2025-10-10T19:43:08Z

- if (orchestrationActivity is null)
- {
- return null;
+ return DateTime.Parse(stringValue[3..], CultureInfo.InvariantCulture, DateTimeStyles.RoundtripKind);


Same comment about TryParse instead of Parse, though I wonder why we have this same logic in two places?

The grpc integration test will not use the ProtoUtils under folder src/shared/grpc but will use the one at it's own folder which is test/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs

initial commit
c8ff67f

Naiyuan Tian (nytian) changed the title ~~Include Exception Properties at FailueDetails~~Include Exception Properties at FailureDetailsOct 2, 2025

Naiyuan Tian (nytian) commented Oct 2, 2025
View reviewed changes

update
3d4e485

Naiyuan Tian (nytian) commented Oct 2, 2025
View reviewed changes

Comment threadsrc/Worker/Core/IExceptionPropertiesProvider.cs

Naiyuan Tian (nytian) commented Oct 2, 2025
View reviewed changes

Naiyuan Tian (nytian)and others added 3 commits October 3, 2025 10:24

Update Microsoft.Azure.DurableTask.Core to version 3.5.0
8636a3d

add factory change support for df support
c4321e4

Merge branch 'nytian/failure-details-excep' ofhttps://github.com/mic…
e3a7f8a
…rosoft/durabletask-dotnet into nytian/failure-details-excep

Naiyuan Tian (nytian) commented Oct 6, 2025
View reviewed changes

Naiyuan Tian (nytian) added 3 commits October 6, 2025 10:49

update test and version
e98024b

udpate test
121a605

fix issue
c34de93

Naiyuan Tian (nytian) requested review from wangbill (YunchuWang) and Chris Gillum (cgillum)October 6, 2025 19:34

udpate commment
c084057

Chris Gillum (cgillum) reviewed Oct 7, 2025
View reviewed changes

Naiyuan Tian (nytian) added 3 commits October 7, 2025 20:48

udpate protoutils
d5f45fe

update dictionary to be object? and update test to include more types
15c8393

udpate comment
221bc3d

Naiyuan Tian (nytian) requested a review from Chris Gillum (cgillum)October 8, 2025 17:15

Naiyuan Tian (nytian) mentioned this pull request Oct 8, 2025
Include Exception Properties at FailureDetails via Custom Provider Azure/azure-functions-durable-extension#3215
Merged
15 tasks

Phillip Hoff (philliphoff) reviewed Oct 9, 2025
View reviewed changes

Comment threadsrc/Abstractions/TaskFailureDetails.cs Outdated

Phillip Hoff (philliphoff) reviewed Oct 9, 2025
View reviewed changes

Comment threadtest/Grpc.IntegrationTests/GrpcSidecar/Grpc/ProtobufUtils.cs

udpate by comemnt
e155c7e

Naiyuan Tian (nytian) requested a review from Phillip Hoff (philliphoff)October 9, 2025 20:38

Phillip Hoff (philliphoff) approved these changes Oct 10, 2025
View reviewed changes

Chris Gillum (cgillum) reviewed Oct 10, 2025
View reviewed changes

udpate bu comment
edb5504

Naiyuan Tian (nytian) requested a review from Chris Gillum (cgillum)October 13, 2025 15:56

Chris Gillum (cgillum) approved these changes Oct 13, 2025
View reviewed changes

udpate grpc
15c86e5

Phillip Hoff (philliphoff) approved these changes Oct 13, 2025
View reviewed changes

Naiyuan Tian (nytian) merged commit 6a1f434 into mainOct 13, 2025
4 checks passed

Naiyuan Tian (nytian) deleted the nytian/failure-details-excep branch October 13, 2025 18:44

Naiyuan Tian (nytian) mentioned this pull request Mar 6, 2026
Include Exception Properties at FailureDetails microsoft/durabletask-java#263
Merged

andystaples mentioned this pull request Jul 28, 2026
Add support for custom properties in FailureDetails microsoft/durabletask-python#67
Open

Uh oh!

Conversation

Naiyuan Tian (nytian) commented Oct 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Naiyuan Tian (nytian)Oct 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chris Gillum (cgillum) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Phillip Hoff (philliphoff) left a comment

Choose a reason for hiding this comment

Uh oh!

Chris Gillum (cgillum) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Naiyuan Tian (nytian) commented Oct 2, 2025•
edited
Loading

Naiyuan Tian (nytian)Oct 2, 2025•
edited
Loading