Skip to content

Supporting POST requests and request headers - #1

Merged
bghgary merged 13 commits into
BabylonJS:mainfrom
lmaskati:lmaskati/test
Mar 7, 2023
Merged

Supporting POST requests and request headers#1
bghgary merged 13 commits into
BabylonJS:mainfrom
lmaskati:lmaskati/test

Conversation

@lmaskati

@lmaskatilmaskati commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

This PR adds support for making POST requests and setting request headers. The added changes include:

  • The setRequestMethod (part of the HttpUrlConnection class) to specify the request method (currently only POST and GET supported).
  • The setDoOutput, getDoOutput and getOutputStream methods (part of the UrlConnection class), and the OutputStream and OutputStreamWriter classes to write the body of the POST request.
  • The SetRequestProperty method to add request headers.

@sebavan
sebavan requested review from bghgary and richma-msMarch 3, 2023 23:52
@lmaskatilmaskati mentioned this pull request Mar 6, 2023
Merged
bghgary
bghgary approved these changes Mar 6, 2023
View reviewed changes

@bghgarybghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments.

Comment threadSource/JavaWrappers.cpp Outdated
Comment threadSource/JavaWrappers.cpp Outdated
Comment threadSource/JavaWrappers.cpp Outdated
Comment threadSource/JavaWrappers.cpp Outdated
Comment threadSource/JavaWrappers.cpp Outdated
@bghgary

bghgary commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Title could be updated :-)

bghgary
bghgary reviewed Mar 6, 2023
View reviewed changes
Comment threadInclude/AndroidExtensions/JavaWrappers.h Outdated
Comment threadInclude/AndroidExtensions/JavaWrappers.h Outdated
bghgary
bghgary reviewed Mar 6, 2023
View reviewed changes
Comment threadSource/JavaWrappers.cpp Outdated
@lmaskatilmaskati changed the title Lmaskati/testSupporting POST requests and request headesrMar 6, 2023
@lmaskatilmaskati changed the title Supporting POST requests and request headesrSupporting POST requests and request headersMar 6, 2023
lmaskatiand others added 9 commits March 6, 2023 17:57
@lmaskati@bghgary
Use truthy/falsy response of std::string.compare directly
9ed530f
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Add const keyword in SetRequestProperty
4e6db3c
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Add const keyword in SetRequestMethod
f52f009
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
0acbee5
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
9c04da1
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
164e776
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
0c0d243
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati
remaining formatting fixes
392151a
@lmaskati
fix method signature
1802b4f
@lmaskatilmaskati closed this Mar 7, 2023
@lmaskatilmaskati reopened this Mar 7, 2023
@lmaskati

lmaskati commented Mar 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@bghgary ready to merge.

bghgary
bghgary reviewed Mar 7, 2023
View reviewed changes
Comment threadSource/JavaWrappers.cpp Outdated
@bghgary
bghgary merged commit 4a54e63 into BabylonJS:mainMar 7, 2023
@lmaskati
lmaskati deleted the lmaskati/test branch May 15, 2023 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bghgarybghgarybghgary approved these changes
@richma-msrichma-msAwaiting requested review from richma-ms

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmaskati@bghgary