Skip to content

POST requests and setting request headers. - #1

Merged
bghgary merged 26 commits into
BabylonJS:mainfrom
lmaskati:main
Mar 7, 2023
Merged

POST requests and setting request headers.#1
bghgary merged 26 commits into
BabylonJS:mainfrom
lmaskati:main

Conversation

@lmaskati

@lmaskatilmaskati commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

This PR adds support for making POST requests and setting request headers. This PR is a draft until BabylonJS/AndroidExtensions#1 is merged, after which it needs to be tested with an updated CMake.

@lmaskatilmaskati mentioned this pull request Mar 6, 2023
Merged
bghgary
bghgary reviewed Mar 6, 2023
View reviewed changes

@bghgarybghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I will probably review more once the first pass is fixed.

Comment threadSource/UrlRequest_Android.cpp Outdated
Comment threadSource/UrlRequest_Apple.mm Outdated
Comment threadSource/UrlRequest_Apple.mm Outdated
Comment threadSource/UrlRequest_Apple.mm Outdated
Comment threadSource/UrlRequest_Base.h Outdated
Comment threadSource/UrlRequest_Android.cpp Outdated
Comment threadSource/UrlRequest_Windows.cpp Outdated
Comment threadSource/UrlRequest_Windows.cpp Outdated
Comment threadSource/UrlRequest_Windows.cpp Outdated
Comment threadSource/UrlRequest_Windows.cpp Outdated
bghgary
bghgary reviewed Mar 6, 2023
View reviewed changes

@bghgarybghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I will probably review more once the first pass is fixed.

lmaskatiand others added 13 commits March 7, 2023 09:53
@lmaskati
modify CMake to point at original repo
9b6d530
@lmaskati@bghgary
Update Source/UrlRequest_Android.cpp
e5131d0
Formatting
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Update Source/UrlRequest_Apple.mm
3bb7230
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
82e863b
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
aa2c525
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Formatting
fa41404
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
formatting
d949839
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati@bghgary
Remove unnecessary string copies
ca9cde7
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati
process content type response header outside for loop
a473d09
@lmaskati
Merge branch 'main' ofhttps://github.com/lmaskati/UrlLib
7d4c5a9
@lmaskati@bghgary
Automatically sets to empty string
424f481
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati
avoid copying for GetAllResponseHeaders
826d4cb
@lmaskati
Merge branch 'main' ofhttps://github.com/lmaskati/UrlLib
89f30f7
@lmaskati
lmaskati marked this pull request as ready for review March 7, 2023 19:08
bghgary
bghgary reviewed Mar 7, 2023
View reviewed changes
Comment threadSource/UrlRequest_Windows.cpp Outdated
@bghgary
bghgary merged commit 58b2e8f into BabylonJS:mainMar 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bghgarybghgarybghgary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmaskati@bghgary