Uh oh!
There was an error while loading. Please reload this page.
Release 4.8.5 - #183
Merged
Merged
Conversation
The floating jitpack snapshot v1.21-SNAPSHOT resolves to an ephemeral git-described build whose jar/POM get evicted, breaking CI even on unchanged commits. Switch to the equivalent stable Maven Central coordinates (org.mockbukkit.mockbukkit:mockbukkit-v1.21:4.110.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Brings the supported-versions list in line with the other addons (1.21.5-1.21.11, 26.1, 26.1.1, 26.1.2). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Update Modrinth game-versions to current MC range
Publish the jar attached to each GitHub release to CurseForge via the shared BentoBoxWorld/.github reusable workflow, downloading the release asset instead of rebuilding from source. Mirrors the BentoBox core setup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin bentoboxworld/.github publish-platforms.yml to commit e0c5d98f5e6ef9ea7c9a28afad05f4c07bcde898 (Sonar githubactions:S7637) and set the Hangar slug so releases publish to Hangar alongside CurseForge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…944b98b9 Picks up the split into independent CurseForge and Hangar jobs so neither platform can block the other. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add CurseForge publish workflow (publishes the release asset)
…e4b1f0 ci: bump pinned reusable workflow to fe4b1f0
…ca2dcd1 ci: bump pinned publish-platforms.yml to ca2dcd1
The permissions the commands actually check were missing from addon.yml, so they had no declared default and fell back to op only - which contradicts the documentation and stops a player from using /[gamemode] border color at all. [gamemode].bordertype was declared but never checked: BorderTypeCommand asks for border. + its label, i.e. [gamemode].border.bordertype. Found while tracing #179. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6rYr6Z66LQz9XTbnbUupy
…declarations Declare the border colour and bordertype permissions
The pinned SHA predates BentoBoxWorld/.github#13, which moved the CurseForge metadata and Hangar versionUpload JSON out of inline curl -F values and into files. curl treats a ';' in an inline -F value as the start of a type= attribute, so a release body containing a semicolon truncates the JSON and both platforms reject the upload. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SAQ3YQkcfRoCZEwa6SPJcp
ci: bump publish-platforms pin to the multipart-JSON fix
The death drop protection added in 8d88d9a took the items out of the PlayerDeathEvent at NORMAL priority, dropped them by hand, and cleared the drops list. Any plugin that stores death drops - DeathChest, graves, keep-inventory - then ran on an empty event while the items lay on the ground, so with the default bounce-back: true, Border 4.7.0+ silently broke every such plugin. Leave the event alone: note the death spot at MONITOR, after those plugins have decided what happens to the items, and apply the bounce-back tracking to whatever the server then actually spawns, caught through ItemSpawnEvent in the same tick. If another plugin keeps the items, nothing spawns and there is nothing to track. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013RPEWFAQcCivzQqB4L72Bx
Stop death bounce-back from hijacking the drops
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 4.8.5 — compatibility and permissions patch.
Bug Fixes
PlayerDeathEvent.getDrops()at NORMAL priority, silently breaking DeathChest, grave plugins and keep-inventory features.onPlayerDeathnow runs at MONITOR and only records the death spot; a newItemSpawnEventhandler bounces back the items the server actually spawns. [Stop death bounce-back from hijacking the drops #182][gamemode].border.colorwas undeclared, so it fell back to op-only and players could not use the colour command. Declaredtrue, with the individual colours gatedopas documented.[gamemode].bordertype(declared but never checked) renamed to[gamemode].border.bordertype. [Declare the border colour and bordertype permissions #180], found while investigating Unhandled CommandSyntaxException from DidYouMeanListener when using /oneblock border color green #179Other
Draft release notes for 4.8.5 are prepared on GitHub for review.