feat: island trophies and titles (foundation for #31) by tastybento · Pull Request #36 · BentoBoxWorld/ChunkBlock

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

tastybento · 2026-08-15T02:17:07Z

Closes#31. Stacked on #35 — based on feature/activity-counters and containing only the trophy layer as its own commit; when #35 merges this retargets to develop automatically.

The reward layer the ring milestones (#3), relay (#9) and leagues (#10) all asked for independently: one persistent, visible trophy system instead of three. It earns its place over the existing chunkblock.rings.commands by being persistent and visible — the island keeps the trophy and can show the title — rather than running a command once and forgetting.

Shape, as specified in the issue

Config-defined, not hardcoded. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING: ring N complete) or the [foundation] Per-member island activity counters #30 counters (COUNTER with counter/scope/threshold/window-days, where scope is the island total or any single member).
Earned once, stays earned. Earned trophy ids persist on OneBlockIslands; only an island create or reset clears them. Re-locking a ring on level loss and claiming it back never re-awards — the highestRingRewarded lesson applied.
A cancellable award event.TrophyAwardEvent mirrors RingCompleteEvent: the trophy is persisted whether or not the event is cancelled (so it can never fire twice), and cancelling suppresses only the addon's own handling — messages, sound, title grant and reward commands — so another plugin can take the reward over entirely.
Titles are the display half. One active title per island, chosen from earned trophies with the new /ch title command (list, set, none to clear, tab-complete), surfaced as %chunkblock_island_title% plus a %chunkblock_island_trophies% count. The first titled trophy auto-becomes the title until the island picks another. Titles are purely cosmetic for now; showing them next to the island name in listings is left open, as the issue suggests.
The balance constraint.trophies.yml opens with the prominent warning: never reward island levels from trophy commands — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Economy/console-command payouts are fine.

What earns a trophy

Deliberately not decided here, per the issue's "not in scope". The shipped defaults are three benign examples (ring 1, ten distinct chunks, ten thousand magic blocks); ring milestones (#3), relay streaks (#9) and competition placements (#10) become condition sources in their own issues.

Tests

22 new tests: TrophyManagerTest (parsing/validation, criteria over rings and counters incl. member scope, award-once, cancellation semantics, titles), IslandTitleCommandTest, plus the ActivityManager→TrophyManager hook test. Full suite: 723 tests, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- recordActivity instead of record: 'record' is a restricted identifier - pin LocalDate.now to the system zone explicitly - static imports and an unused import in the new tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

The reward layer over the activity counters: config-defined trophies an island earns once and keeps, and the titles they carry. One system for the ring milestones (#3), relay scores (#9) and competition placements (#10) to emit into, instead of three unrelated ones. A trophy in trophies.yml is a name, an icon, a condition and what it grants. Conditions read the ring state (RING) or the activity counters (COUNTER, island total or any single member, lifetime or windowed). Earned trophies persist on the island and only an island create or reset clears them — the highestRingRewarded lesson: re-locking a ring on level loss and claiming it back never re-awards. TrophyAwardEvent mirrors RingCompleteEvent: cancellable, and the trophy stays earned either way, so another plugin can take the reward over entirely without the addon also acting. trophies.yml carries the warning against paying out island levels — levels buy chunks, so a level-granting trophy makes each milestone buy the next one. Titles are the display half: one active title per island chosen from earned trophies with /ch title, surfaced as the %chunkblock_island_title% placeholder (plus %chunkblock_island_trophies%). Foundation for #31; builds on the #30 counters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

- guard execute() against a null island instead of trusting canExecute - constants for the repeated '[title]' and "Trophy '" literals - make the COUNTER criteria's non-null counter explicit for analysis - never map a nullable trophy title into the active-title text - suppress S9149 on getHandlerList: Bukkit's event bus requires the exact static method name on every event class Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8GghDu6oXiUf6eCoimJqD

sonarqubecloud · 2026-08-15T02:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tastybento · 2026-08-15T03:00:00Z

All 7 SonarCloud findings on this PR are fixed and the analysis is now green (0 open issues, all checks pass).

Note on the stack: #35 merged just before its own SonarCloud fix commit landed, so develop currently carries 4 minor findings from the counters PR (the record restricted-identifier rename, the explicit ZoneId on LocalDate.now, and two test import nits). This branch was rebased on that fix commit, so merging this PR also clears those 4 findings on develop. The re-created feature/activity-counters branch on the remote is now redundant and can be deleted.

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Base automatically changed from feature/activity-counters to developAugust 15, 2026 02:50

tastybentoand others added 3 commits August 14, 2026 19:54

tastybento force-pushed the feature/island-trophies branch from a98ba25 to 20a714fCompare August 15, 2026 02:56

tastybento merged commit 1bf8dfa into developAug 15, 2026
3 checks passed

tastybento deleted the feature/island-trophies branch August 15, 2026 03:59

tastybento mentioned this pull request Aug 16, 2026
Release 1.2.0 #40
Merged

Uh oh!

Uh oh!

Conversation

tastybento commented Aug 15, 2026

Shape, as specified in the issue

What earns a trophy

Tests

Uh oh!

sonarqubecloudBot commented Aug 15, 2026

Quality Gate passed

Uh oh!

tastybento commented Aug 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

tastybento commented Aug 15, 2026

Shape, as specified in the issue

What earns a trophy

Tests

Uh oh!

sonarqubecloudBot commented Aug 15, 2026

Quality Gate passed

Uh oh!

tastybento commented Aug 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

tastybento commented Aug 15, 2026

Shape, as specified in the issue

What earns a trophy

Tests

Uh oh!

sonarqubecloudBot commented Aug 15, 2026

Quality Gate passed

Uh oh!

tastybento commented Aug 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

tastybento commented Aug 15, 2026

Shape, as specified in the issue

What earns a trophy

Tests

Uh oh!

sonarqubecloudBot commented Aug 15, 2026

Quality Gate passed

Uh oh!

tastybento commented Aug 15, 2026

Uh oh!

Uh oh!