Organize dirty work: codex/config-reconciliation - #1328
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:18 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:e9743550f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const canonical = new Set([ | ||
| ...parseEnvSchemaNames(envTs), | ||
| ...parseCiEnvNames(ciEnv), | ||
| ...envExampleConfigNames, |
There was a problem hiding this comment.
Keep examples out of the canonical consumer set
When a variable remains only in .env.example because its runtime/CI consumer was removed or misspelled, adding envExampleConfigNames to canonical makes both unknownExpected and unknownLive accept it, so check:env-parity can report success even though no application or CI code reads the variable. Keep the example names solely for the missingFromExample check and derive the canonical set from actual consumers; a focused test where OPENAI_API_KEY exists only in example text reproduces the false success.
Useful? React with 👍 / 👎.
This PR organizes local dirty work for branch codex/config-reconciliation.