CI: enforce reproducible dependency installs - #1360
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe PR replaces cached ChangesDependency installation and validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Summary
npm ci --include=devon every CI runner.Sources reviewed
#1313, #1328, #1329, #1346, #1350.
Retained
Reproducible installs, explicit dev-dependency installs, npm cache safety, installed-toolchain parity, and the valid ops preflight wording.
Rejected
Fail-open upload auditing, duplicate/image-contaminated assets, unused image APIs, visual-regression machinery without baselines, test-coordinator bypasses, and the primary-checkout guard whose stale-owner recovery had a lease-deletion race.
Verification
git diff --checknpm run check:github-actionsnpm run check:installed-lock-paritynpm run verify:cheap: passed; 412 test files, 4199 tests passed, 3 skippedNot run
No hosted CI reruns and no provider-backed checks.
Risk
CI jobs now reinstall node_modules on each fresh runner, trading some runtime for deterministic lockfile proof.
RAG impact: no retrieval behaviour change - the eval workflow change only makes dependency installation explicit.
Summary by CodeRabbit
CI Improvements
Bug Fixes
Documentation
Tests