Organize dirty work from codex/universal-ledger-hook-review-fix-472f10 - #1345
Organize dirty work from codex/universal-ledger-hook-review-fix-472f10#1345BigSimmo wants to merge 7 commits into
Conversation
…r-security-followup-082afe
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:17 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d06ca5d008
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while IFS=$'\t' read -r order id acuity timing estimate; do | ||
| [ -z "$order" ] && continue | ||
| if [ "$shown" -lt "$limit" ]; then | ||
| echo " ${order} ${id} ${acuity} — ${timing} · ${estimate}" |
There was a problem hiding this comment.
On every SessionStart with the new queue, this prints entries such as 1 #057 A1 / Operator security ... but omits the outcome column that explains what #057 actually is. The hook therefore no longer gives a fresh session enough information to identify any surfaced task without manually invoking /issues, defeating its automatic task-awareness purpose; parse and display the recommended outcome, truncating it if compactness is required.
AGENTS.md reference: AGENTS.md:L470-L473
Useful? React with 👍 / 👎.
| - **`/issues done <id> [outcome]`** — move that row from **Open items** to **Resolved / archive** | ||
| with today's date and a one-line outcome. Archive, never delete. | ||
| with today's date and a one-line outcome, remove it from the recommended execution queue, and | ||
| close the order gap. Archive, never delete. |
There was a problem hiding this comment.
When /issues done #051 is used, the active queue contains a single source row for ``#51+#23```; following this instruction literally removes that entire row and silently drops still-open #23 from the active recommendation view, while retaining it would leave resolved #51 active. Require one open ID per queue row or explicitly require partially rewriting and reordering a combined row when only one referenced ID is closed.
AGENTS.md reference: AGENTS.md:L460-L462
Useful? React with 👍 / 👎.
| inrecommended && /^\|[[:space:]]*[0-9]+[[:space:]]*\|/ { | ||
| n=split($0, c, "|") | ||
| order=c[2]; id=c[3]; acuity=c[5]; timing=c[6]; estimate=c[7] |
There was a problem hiding this comment.
The writing rules explicitly permit escaped \| characters in cells, but split($0, c, "|") treats those as delimiters too. Once a recommended outcome contains an escaped pipe—for example, two alternative commands—the outcome fragments shift c[5], c[6], and c[7], so the hook reports arbitrary text as acuity, timing, and effort; use an escape-aware Markdown-table parser or protect escaped pipes before splitting.
AGENTS.md reference: AGENTS.md:L470-L473
Useful? React with 👍 / 👎.
Organizes current dirty work collected on branch codex/universal-ledger-hook-review-fix-472f10.