Skip to content

fix: reconcile redesign and restore lint - #23

Merged
BigSimmo merged 1 commit into
mainfrom
codex/redesign-reconciliation
Jun 13, 2026
Merged

fix: reconcile redesign and restore lint#23
BigSimmo merged 1 commit into
mainfrom
codex/redesign-reconciliation

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Reconciles the final redesign merge regressions on main by restoring the compact mobile search header, removing duplicate hidden query/filter merge debris, and scoping the document-search smoke locator.
  • Adds the redesign verification report for the reconciliation pass.
  • Restores clean-install lint compatibility by pinning ESLint to the latest compatible 9.x range for eslint-config-next@16.2.7 and its bundled React lint plugin.

Validation

  • npm ci under Node 22.22.3
  • npm run lint
  • npm run typecheck
  • npm run test (341/341)
  • npm run build
  • npm run format:check
  • npx playwright test tests/ui-smoke.spec.ts --project=chromium (22/22)
  • In-app browser check against http://localhost:4298 after /api/local-project-id confirmed Clinical KB

Audit

  • npm audit --audit-level=high still reports one high-severity esbuild advisory. No audit fix was applied because that would broaden the dependency change beyond the targeted ESLint compatibility repair.

Local files intentionally left out

  • .claude/** remains untracked local tool state.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@BigSimmo
BigSimmo merged commit 292cb4d into mainJun 13, 2026
4 checks passed
@BigSimmo
BigSimmo deleted the codex/redesign-reconciliation branch June 13, 2026 07:55
BigSimmo pushed a commit that referenced this pull request Jul 22, 2026
…cile issue IDs
Review findings on PR #1050 (Codex P2 + CodeRabbit major, converged): a case
that attempted generation but lost the provider response (timeout, missing
output) has real-but-unrecorded token spend — keying $0 off hasOpenAIUsage
alone would report those as fully priced. $0 now applies only when no request
id, no model, and no generation time were recorded; provider-attempted cases
without usage metadata stay null (n/a total). Also resolves the ledger merge
conflict against #1049's concurrent ID allocation: main's #12-#17 stand, this
session's six items renumber to #18-#23 (next-id 024), the cost-readout row
is rewritten as post-fix validation only (CodeRabbit), and the unbalanced
strikethrough tildes in the E-3d row are fixed (CodeRabbit).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EXsJcLrbZUXwnBeG91cVo9
BigSimmo pushed a commit that referenced this pull request Jul 30, 2026
main's #1418 (ledger merge dedupe + L4 quarterly archive rotation) and #1413
both edited docs/outstanding-issues.md, so this was a real content conflict
rather than staleness: git merge-tree --write-tree confirmed CONFLICT before
any resolution was attempted.
Resolved by taking main's version of the ledger wholesale and re-applying this
branch's five-row archive move on top, so neither side's work is lost:
- from main: #88 and #97 archived, new open row #126 (quarterly ledger
rotation) with queue order 35, the #23 "When" update (release-browser-matrix
no longer blocked by pr-required), the #86 detail update, and the
issues:next-id bump to 127.
- from this branch: #95, #96, #104, #109 and #115 moved from Open items to
Resolved / archive.
No row from either side was dropped, and no id appears in both tables.
Verified: 121 rows (52 open, 69 archived), marker next-id=127 above the highest;
each of #88, #97, #95, #96, #104, #109, #115 resolves to exactly one archive
row and #126 to one open row; zero conflict markers remain.
npm run verify:cheap -> EXIT=0; "Gate-manifest OK: all 29 verify:cheap gates are
enforced in CI"; "Test Files 431 passed (431)"; "Tests 4496 passed | 4 skipped
(4500)". npx prettier --check . -> "All matched files use Prettier code style!"
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011YdPS2KhKqz2buzsUgmX3c
BigSimmo added a commit that referenced this pull request Aug 27, 2026
… and operator governance sweep (#50QRCF, #TYZK23, #KFRC3H, #TF6TPJ, #23, #S4K1GA, #9X40BT, #HVTYAT, #102) (#2406)
* docs(governance): close quality gate, mobile/performance, and operator governance tasks (#50QRCF, #TYZK23, #KFRC3H, #TF6TPJ, #23, #S4K1GA, #9X40BT, #HVTYAT, #102)
* fix(pr-2406): resolve main merge and address review findings
Merge origin/main (scripts-index count conflict). Restore conditional provider-retention wording on /privacy, sync AGENTS.md branching limit to 1, reclassify #102 as an update request, and restore truncated inbox outcomes.
* fix(pr-2406): keep branching-cap limit unverified, regenerate stale snapshot
- AGENTS.md / docs/operator-supabase-branching-cap.md: the automatic-branching
limit reduction (3 -> 1) has no available independent evidence it was
actually applied in the Supabase dashboard. The only check we can run
(zero active preview branches) is equally consistent with the limit still
being 3, so AGENTS.md keeps documenting 3 as the authoritative, verifiable
state, and the operator doc is reframed as a recommended action pending an
operator-supplied durable record (screenshot or exported settings value).
- data/outstanding-issues-snapshot.json: regenerate after the #102 inbox
record changed from done to update, which changed the ledger's pending
count (22 -> 31). `node scripts/check-outstanding-issues-snapshot.mjs`
now reports in step.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0196uN8MrcdNMC3siuR94THX
* fix(pr-2406): regenerate stale repo-awareness snapshot
AGENTS.md and docs/operator-supabase-branching-cap.md content changes in the
prior commit left data/repo-awareness-snapshot.json behind. Regenerated with
npm run snapshot:repo-awareness; npm run check:repo-awareness-snapshot and
npm run check:outstanding-issues-snapshot both report in step.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0196uN8MrcdNMC3siuR94THX
---------
Co-authored-by: Claude <noreply@anthropic.com>
BigSimmo pushed a commit that referenced this pull request Aug 27, 2026

PR #2406 (merged to main) independently closed #S4K1GA, #50QRCF, #KFRC3H,
#102, #23, and #TYZK23 with its own inbox records. This branch queued
separate, competing records for the same six tickets, which
ledger-inbox.mjs correctly refuses to reconcile automatically. Cancel
this branch's duplicate requests so main's already-landed #2406 records
are the ones that apply.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo