Reapply API contract semantics and pagination metadata - #153
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:9ab3a037aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
13 tasks
BigSimmo
enabled auto-merge
July 2, 2026 10:45
Uh oh!
There was an error while loading. Please reload this page.
BigSimmo pushed a commit
that referenced
this pull request
Jul 30, 2026
Fourth ledger id collision on this branch: main allocated #149 (check:installed-lock-parity only compares seven top-level packages) and #150 (CodeRabbit reviewed none of a full day's PRs) while this branch held #149-#151 for the answer-home notice capture. main's rows are kept and the incoming rows renumber per the ledger's own rule: #151 adopt a consolidated answer-home notice block, #152 answer mode ships no verify-before-use caveat, #153 verify:pr-local exits 0 when its build step refuses to run. Their three cross-references and the marker (154) follow. check:outstanding-issues: 151 rows (58 open, 93 archived), unique ids, next-id=154 above the highest, no ids deleted from base 4312a21. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPyFcMfn1jMmphr6AqiWBg
BigSimmo added a commit
that referenced
this pull request
Jul 30, 2026
…closed (#1508) PR #1490 was closed unmerged, so none of its content reached main. Confirmed by content rather than id: main's #149 and #150 are unrelated rows (installed-lock parity and CodeRabbit rate limits) that happened to take those ids, so an id-presence check reported them as landed when they were not. - #151 corrects the earlier claim that CI is unreadable. The PAT lacks Checks: read but has Actions: read, so workflow runs are queryable; the endpoint that looked authoritative returns an empty result rather than an error, which is what made it read as a hard wall. - #152 re-lands the at-risk worktree inventory together with the four preservation snapshots taken on 2026-07-31, which existed in no other record. - #153 archives the pre-commit fail-open as resolved by PR #1494. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
BigSimmo pushed a commit
that referenced
this pull request
Jul 31, 2026
Three conflicts, resolved by evidence rather than by side-preference. scripts/ensure-codex-cloud-git-remote.mjs and tests/codex-cloud-setup.test.ts: took main's version. The branch carried its own fix for the same defect (5aa3d6c, judging origin safety from the configured remote URL) on top of main's #1497, so neither side was obviously newer. main's version introduces a configuredOriginUrl() helper, already covers the url.*.insteadOf case the branch's extra test was written for, and passes 12/12 locally — verified before choosing, since taking a side wholesale is only safe when the other side's content is genuinely subsumed. This also clears the two codex-cloud-setup failures this branch has carried all session. docs/outstanding-issues.md: fifth id collision on this branch. main has since claimed #151-#153 — the exact ids these rows previously held — and now runs to #164. main's rows are kept and the follow-ups renumber to #165 (adopt a consolidated answer-home notice block), #166 (answer mode ships no verify-before-use caveat) and #167 (verify:pr-local exits 0 when its build step refuses to run), with their three cross-references and the marker (168) following. check:outstanding-issues: 165 rows (50 open, 115 archived), unique ids, next-id=168 above the highest, no ids deleted from base 23465d5. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPyFcMfn1jMmphr6AqiWBg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extOffset, hasMore) on jobs/batches feeds
Validation