Skip to content

issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix - #1490

Merged
BigSimmo merged 20 commits into
mainfrom
claude/capture-session-followups
Jul 30, 2026
Merged

issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix#1490
BigSimmo merged 20 commits into
mainfrom
claude/capture-session-followups

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

Ledger-only. Three findings from the 2026-07-30 organisation session were recorded nowhere durable — they existed solely in chat context, which is exactly what docs/outstanding-issues.md exists to prevent.

  • #149 — CI verdicts are unreadable with the current GitHub token. The session PAT lacks Checks: Read. gh pr checks fails per context and /check-runs returns 403; /commits/:sha/statussucceeds but reports total: 0, because this repo reports through Actions check-runs rather than legacy commit statuses. The working endpoint is therefore silent rather than erroring, which reads like "no checks" instead of "no permission". Both docs: file loose dated records and close the docs index gaps #1436 and docs: close stale hook and script-count records #1458 were handed off with every local gate green and the hosted verdict unverifiable. Fix is a permission on the token; nothing in the repo changes.

  • #150 — uncommitted work in worktrees whose branches are already merged. Four of them, so the changes exist in no branch and no PR: codex/reconcile-immediate-20260730 (+395/-200 across 19 files, including .github/workflows/ci.yml and package.json), codex/document-results-mockup-20260730, codex/chat-ledger-triage-d344, and claude/section-spy-browser-coverage. Recorded rather than actioned, because each needs a per-worktree commit-or-discard decision. This is also the check that stopped the 2026-07-30 cleanup from removing more than one of its two "safe" candidates.

  • #151 — the #143 pre-commit fail-open exists only on a never-pushed branch.git branch -r --contains d2fd16d54 is empty. That branch is additionally 17 behind main and conflicts on docs/scripts-index.md, since main has landed both the rewritten index and the docs:update generator that owns its count sentence.

Verification

  • npm run check:outstanding-issues149 rows (60 open, 89 archived), unique ids, next-id=152 above the highest
  • npm run docs:check-links1415 repo path references resolve (first run failed on one path: #150 originally named an untracked mockup file that does not resolve in this repo, so it is now named without a full path)
  • npm run docs:check-indexcoverage OK: all 49 repository roots/modules/routes and all schema tables are indexed
  • Prettier — clean, in the unpadded table style Stop Prettier padding the issues ledger table, closing #133 #1479 established

Rows follow the compact post-#1479 format; no other file is touched.

Note on #1458

#1458 is now redundant and should be closed rather than merged: main landed the same repo-root coverage pass in #1480 (same root kind, same ${name}/ candidate, same allowlist handling, same message, same all 49 result), the docs:update generator supersedes its hand-corrected counts, and its CLAUDE.md wording is already on main verbatim. Closing a PR needs owner confirmation, so it is left open.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the branch-review ledger with new follow-up review records for outstanding capture-session items, including CI token permission constraints, worktree/uncommitted-change tracking, and a pre-commit-hook fix note.
    • Reordered and reconciled related entries to improve clarity on which PRs/issues own each portion of the review and to correct main-sync archival details.
    • Advanced the outstanding-issues sequence and added new open items for unreadable CI verdicts and preserved-but-uncommitted worktree changes.
    • Refreshed resolved/archive wording to reflect the corrected scope and remaining snapshot text.

…he unpushed hook fix
Three findings from the 2026-07-30 organisation session that were recorded
nowhere durable:
- #149 the session GitHub PAT lacks Checks: Read, so no agent can confirm a PR
is green. The endpoint that does work returns an empty result rather than an
error, so it reads like an absence of checks rather than an absence of
permission.
- #150 four worktrees on already-merged branches hold uncommitted work that
exists in no branch and no PR, the largest being +395/-200 across 19 files
including CI config.
- #151 the pre-commit fail-open for #143 lives only on a never-pushed local
branch, which is also 17 behind main and conflicts on the file whose count
sentence main's new docs:update generator now owns.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:33 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a6081725-1f8c-42f4-8cf9-b8ad90225898

📥 Commits

Reviewing files that changed from the base of the PR and between ad71cf2 and 9a356b4.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
📝 Walkthrough

Walkthrough

The PR updates outstanding-issue records for CI token access and preserved worktree changes, clarifies pre-commit-hook issue resolution, and appends corresponding branch review ledger reconciliation and follow-up records.

Changes

Issue Ledger Reconciliation

Layer / File(s)Summary
Outstanding issue records
docs/outstanding-issues.md
Advances the next issue ID to 154, adds open issues #152 and #153, and updates the archived records for #143 and #151.
Capture-session reconciliation
docs/branch-review-ledger.md
Records CI token limitations, preserved worktree changes, the issue #148 deletion guard, and ownership corrections for issues #143 and #151.
Main-sync follow-ups
docs/branch-review-ledger.md
Records issue closure and archiving, ID-collision renumbering, snapshot wording clarification, and the relocated PR #1433 review entry.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers:claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title is concise and accurately summarizes the main ledger updates about unreadable CI, at-risk worktrees, and the hook fix.
Description check✅ PassedThe description covers summary and verification well, but the template's Risk/Rollout and Notes sections are only partially filled or implicit.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbc5d4625a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threaddocs/outstanding-issues.md Outdated
Comment threaddocs/outstanding-issues.md Outdated
@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 19:42
Main resolved#148 via #1491 and moved it to the archive table, so its side of
the open-items hunk was empty. Resolution keeps main's archival and re-adds only
#149, #150 and #151; the next-id marker stays at 152, which is the value this
branch allocated and is still above main's highest.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@BigSimmo
BigSimmo disabled auto-merge July 30, 2026 19:44
@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 19:45
cursoragentand others added 4 commits July 30, 2026 19:46
Correct archived #143: PR #1442 tracked the hook/script but did not
land fail-open (pre-commit still invokes the inventory script at L97).
#151 owns that remaining half and now says not to discard the unpushed
branch. Separate #149's Checks: Read remedy from #132's missing-gh path.
Merge origin/main so #148 stays archived from #1491.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Parallel remote merge of #1491 kept the uncorrected #149/#151 text.
Keep this branch's reconciled wording and the corrected #143 archive.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo disabled auto-merge July 30, 2026 19:49

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 264: Update the PR `#1458` wording in the ledger entry to state that it
should be closed after owner confirmation, preserving the surrounding
reconciliation details and avoiding an unconditional closure instruction.
In `@docs/outstanding-issues.md`:
- Line 158: Update the issue `#149` documentation entry to remove the partial
`github_pat_11AU2...` credential prefix, while retaining the generic
“fine-grained PAT” description and all unrelated troubleshooting details
unchanged.
- Around line 158-160: Update the dates for ledger rows `#149`, `#150`, and `#151`,
plus the “CORRECTED” date associated with `#143`, so they reflect the documented
July 30, 2026 capture/reconciliation unless a later event is explicitly
recorded. Preserve the audit chronology and ensure no July 31 date remains
unsupported by the entry’s event details.
🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b4da99c3-ff0e-4be3-a032-b2518836f24c

📥 Commits

Reviewing files that changed from the base of the PR and between ee34b4d and 5af405b.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md

Comment threaddocs/branch-review-ledger.md Outdated
Comment threaddocs/outstanding-issues.md Outdated
Comment threaddocs/outstanding-issues.md Outdated
BigSimmoand others added 2 commits July 31, 2026 03:54
#150 — the four at-risk worktrees were snapshotted onto their own already-merged
branches (748ef018f, 5dbd9f965, b7eae51a4, d949859c3), so the work survives a
worktree reclaim. All four are clean now. None is pushed or reviewed; the next
action is per-snapshot promote-or-reset.
#151 — the never-pushed branch is superseded rather than salvageable: its script
and hook reached main by other routes, so the fail-open guard was applied to
main's committed hook in PR #1494 instead.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
 edits
Another session reconciled the same three rows while this one snapshotted the
worktrees. Resolution keeps this side for #149 and #150 (theirs carried no
snapshot SHAs) and unions #151: their PR #1442 provenance plus the correction
that the archived #143 row implied the fail-open was durable when only the hook
and script had landed, kept alongside this side's redirect to PR #1494.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 19:58
@BigSimmo
BigSimmo disabled auto-merge July 30, 2026 19:58
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent resolve failing CI, comments and merge conflict

@cursor

cursorBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

PR #1490 is green and mergeable at 55cc3f91.

Did not merge into main.

Open in WebOpen in Cursor

@coderabbitai

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

cursoragentand others added 5 commits July 30, 2026 20:41
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
PR #1494 landed the fail-open guard on main, so close the open salvage
row and update the #143 archive from PARTIAL to resolved across #1442
and #1494. Also carries the merge of origin/main that cleared the
GitHub DIRTY mergeability state.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Main's #1496 reused #149/#150 for lock-parity scope and CodeRabbit
spending-cap findings. Rebuild from main, keep those rows, archive
#151 for the #1494 fail-open landing, and re-home this PR's open
findings as #152 (CI Checks: Read) and #153 (merged-worktree WIP).
Correct #143 to fully resolved across #1442+#1494.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor

cursorBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Resolved on 55cc3f91:

Did not merge the PR into main.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/outstanding-issues.md`:
- Line 158: Clarify the `#153` entry that each branch was already fully merged
into origin/main before its preservation snapshot commit was created.
Distinguish the pre-snapshot merged state from the current branch tips, which
now contain unpushed WIP commits and therefore are not fully merged; update the
cleanup guidance to inspect and preserve those snapshot commits before deleting
worktrees.
🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e052568d-c493-4204-9781-25b048a57d17

📥 Commits

Reviewing files that changed from the base of the PR and between 5af405b and 55cc3f9.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md

Comment threaddocs/outstanding-issues.md Outdated
@BigSimmoBigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 30, 2026
@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Cannot run autofix: This PR has merge conflicts.

Please resolve the conflicts with the base branch and try again.

Alternatively, use @coderabbitai resolve merge conflict to automatically resolve the conflicts.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent resolve merge conflict

@cursor

cursorBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Merge conflict resolved on ad71cf29.

Local merge-tree was already clean — GitHub’s DIRTY was merge=ledger staleness. Merged origin/main (9af15e1f); #152/#153 kept (including the snapshot wording fix). PR is MERGEABLE again and PR mergeability passed.

Open in WebOpen in Cursor

cursoragentand others added 2 commits July 30, 2026 22:03
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor

cursorBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Resolved merge conflict on ad71cf29 by merging origin/main (9af15e1f).

Local git merge-tree was already clean — GitHub DIRTY was the usual merge=ledger staleness on docs/branch-review-ledger.md. Kept #152/#153 (including the pre-snapshot wording fix) and main’s archived CI/#132 closeouts. check:outstanding-issues and docs:check-links pass; PR is MERGEABLE again.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

Temporarily paused during the owner-authorized ordered merge sweep so main cannot move between exact-head review and merge. The branch and all commits are preserved; this PR will be reopened at its verified place in the queue.

BigSimmo added a commit that referenced this pull request Jul 30, 2026
…closed (#1508)
PR #1490 was closed unmerged, so none of its content reached main. Confirmed by
content rather than id: main's #149 and #150 are unrelated rows (installed-lock
parity and CodeRabbit rate limits) that happened to take those ids, so an
id-presence check reported them as landed when they were not.
- #151 corrects the earlier claim that CI is unreadable. The PAT lacks Checks:
read but has Actions: read, so workflow runs are queryable; the endpoint that
looked authoritative returns an empty result rather than an error, which is
what made it read as a hard wall.
- #152 re-lands the at-risk worktree inventory together with the four
preservation snapshots taken on 2026-07-31, which existed in no other record.
- #153 archives the pre-commit fail-open as resolved by PR #1494.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@BigSimmoBigSimmo reopened this Jul 30, 2026
@supabase

supabaseBot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent resolve merge conflicts please and fix CI failure

@cursor

cursorBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Merge conflict resolved and CI is green — PR #1490 also merged at 9a356b4f.

What was wrong
Real conflict in docs/outstanding-issues.md: main had already re-landed the same findings via #1508 under different IDs (#151/#152/#153), while this branch still had its older #152/#153 rows.

Resolution

  • Kept main’s ID scheme (#151 CI/Actions, #152 worktrees, #153 archived pre-commit)
  • Kept this PR’s clearer pre-snapshot wording on #152
  • Pointed archived #143 at #153 (not open #151)
  • Dropped the duplicate archived #151 pre-commit row

Checks

  • check:outstanding-issues — passed (151 rows … next-id=154)
  • docs:check-links — passed
  • Hosted: PR mergeability / Static PR checks / PR required all pass
Open in WebOpen in Cursor

@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 23:31
@coderabbitai

Copy link
Copy Markdown
Contributor

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

cursoragentand others added 2 commits July 30, 2026 23:34
Resolve docs/outstanding-issues.md against #1508's re-land: keep
main's #151/#152/#153 IDs, fold in the pre-snapshot wording for #152,
and point #143 at archived #153.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo merged commit c101137 into mainJul 30, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the claude/capture-session-followups branch July 30, 2026 23:38
BigSimmo added a commit that referenced this pull request Jul 31, 2026
* issues: capture the unreadable-CI token, at-risk worktree work, and the unpushed hook fix
Three findings from the 2026-07-30 organisation session that were recorded
nowhere durable:
- #149 the session GitHub PAT lacks Checks: Read, so no agent can confirm a PR
is green. The endpoint that does work returns an empty result rather than an
error, so it reads like an absence of checks rather than an absence of
permission.
- #150 four worktrees on already-merged branches hold uncommitted work that
exists in no branch and no PR, the largest being +395/-200 across 19 files
including CI config.
- #151 the pre-commit fail-open for #143 lives only on a never-pushed local
branch, which is also 17 behind main and conflicts on the file whose count
sentence main's new docs:update generator now owns.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs(ledger): record the session-followup capture review for PR #1490
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs(ledger): record #143/#151/#149 reconciliation for PR #1490
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): supersede PR #1490 reconciliation after remote sync
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* issues: record the worktree snapshots and redirect #151 to PR #1494#150 — the four at-risk worktrees were snapshotted onto their own already-merged
branches (748ef018f, 5dbd9f965, b7eae51a4, d949859c3), so the work survives a
worktree reclaim. All four are clean now. None is pushed or reviewed; the next
action is per-snapshot promote-or-reset.
#151 — the never-pushed branch is superseded rather than salvageable: its script
and hook reached main by other routes, so the fail-open guard was applied to
main's committed hook in PR #1494 instead.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs: remove credential metadata and correct audit dates
* docs: consolidate session follow-up findings
* docs: record consolidated follow-up review
* issues: record that #101 hydration shipped
PR #1463 merged as dba7356, so #86's "Next X3 unit — rag-hydration.ts" is
now stale. The row records the extraction as shipped and keeps the corrected
boundary: hydration re-homed only two of prepareCoverageGateResults's five
rag.ts-only dependencies, so it did not unblock that function — exactly as the
Codex review on PR #1461 predicted.
This row was deliberately dropped from #1463 itself (commit 6290d02) after
docs/outstanding-issues.md conflicted on five consecutive main syncs. Recording
it separately here is the same pattern used for #1454 via #1461.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS
* docs(ledger): record the landed X3 hydration review
Appended with npm run ledger:append (never hand-written), keyed to the squash
commit dba7356 so ledger:lookup can resolve it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS
* docs: fix the #101 mislabel and key the ledger row to a resolvable ref
Both defects were raised by Codex on PR #1495 and both are real; verified
against the files before accepting.
1. #101 is NOT this extraction. docs/outstanding-issues.md:138 shows #101 is
"Canary-gated retrieval parallelisation candidates" (P3, rec) — a separate,
still-open recommendation gated on a live canary pair. Calling the hydration
extraction "#101" marked that unrelated work as shipped and could have caused
the live-evaluation work to be skipped. The label came from the original task
brief and was propagated without checking it against the ledger. Both the
#86 row and the X3 work-order entry now identify the change as the X3
hydration unit (PR #1463) instead. #101's own row is untouched and still open.
2. The ledger row did not resolve. `npm run ledger:lookup --
dba7356` returned NOT REVIEWED, because the
ref cell held only the slash-form branch token and that branch no longer
resolves locally, so the throttling record could not prevent a repeat review.
Appended a superseding record keyed to the landed SHA; the same lookup now
returns ALREADY REVIEWED. The original row is retained, per the ledger's
append-only rule.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS
* docs: record consolidated PR reviews
* docs: record ingestion recovery review
* docs(visual): document the platform-scoped baseline layout and how to seed it
`playwright.visual.config.ts` records snapshots under
`__screenshots__/{platform}/`, so a baseline taken on Windows lands in `win32/`
and is never consulted by the `ubuntu-24.04` CI job, which reads `linux/`.
Nothing said so, and committing `win32/` images looks like protection while
providing none.
Records the constraint, names the CI artifact as the supported recorder for
`linux/` baselines, and notes that comparison stays advisory until the jobs come
off `continue-on-error`. Also creates the tracked directory `.gitignore` already
claims exists, which sets `ui_changed=true` (`scripts/ci-change-scope.mjs`) so
the visual job can run and produce that first artifact.
No baselines are added here — they cannot be produced on this platform.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs: correct visual baseline adoption steps
* docs: record visual baseline guidance review
* fix(ui): repair mockup accent token references
* docs: record token-reference repair review
* docs: archive advisory UI scoping task
* docs: record advisory UI closure review
* issues: archive #151 after #1494 and mark #143 fully resolved
PR #1494 landed the fail-open guard on main, so close the open salvage
row and update the #143 archive from PARTIAL to resolved across #1442
and #1494. Also carries the merge of origin/main that cleared the
GitHub DIRTY mergeability state.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): record PR #1490 main-sync and #151 closeout
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): record #1496 id-collision renumber for PR #1490
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* issues: record the withdrawn live-region finding as #151 so it is not re-filed
Archive-only row. There is no defect and no work to do — the row exists purely
as a guard rail against repeating a misreading that already happened once.
search-results-header-band.tsx sets aria-live={faulted ? "off" : "polite"} on
its count/status span, which reads like a silenced failure announcement. It is
not: the band mounts a separate fault panel with role="alert" carrying the
failure title, body and Retry, and the mute is deliberate so the two do not both
speak. The reasoning is in a comment directly above the attribute, and
tests/search-results-header-band.dom.test.tsx pins it with singular role queries
that throw on duplicates.
During session 2026-07-30 (PR #1481) this was filed as a real P2 defect on the
strength of the attribute alone, and the proposed fix — escalating the count span
to role="alert"/aria-live="assertive" — would have produced a duplicate
announcement and a red test, making it worse than no change. Codex caught it.
An earlier withdrawal row was then lost to the squash that merged #1481, which
is the row-deletion shape #148 now guards against.
Also records that the mockup's escalation is correct in the mockup and must not
be ported: search-refine-adaptive-mockups.tsx has no fault panel, so there the
count span is the only announcement channel.
#148 needed no work — the merge-base deletion check landed on main
independently, and its output now reports the base it compared against.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JdPa3mHCX5ZQZZvU5GHU3r
* docs(rag): record refuted lexical probe collapse (#98)
* issues: capture the residual id-allocation hazard as #151#133 is resolved: #1444 removed merge=union and #1479 excluded the ledger from
Prettier, which together fixed conflict frequency. Neither changes id
allocation, which is still read-modify-write against the next-id marker, so
concurrent branches still claim the same number.
Measured on PR #1451: one row was renumbered #135 -> #141 -> #145 -> #147 ->
#149 across four sync cycles. The sharper finding is that GitHub's Update-branch
button resolved one such collision into duplicate #141 rows with the marker left
below main's highest id — git reported success and only
check:outstanding-issues caught it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs(issues): attribute the mobile CLS breach — a 128px reserve round trip
#147 asked which elements shift. Driving Chromium against the same
offline production build with a PerformanceObserver on layout-shift
(Lighthouse mobile emulation, reading entry.sources[].node) gives one
dominant cause on all four breaching routes: the entire main content
region moves down 128px and straight back up 128px within 15-60ms. Both
moves score, so it is pure cost with zero net movement — 100% of
/documents/search's 0.220 and about 75% of /dsm's.
The shifting element is the max-sm:pt-[var(--phone-overlay-chrome-h)]
wrapper around <main>. A MutationObserver timeline on the root style
attribute pins the mechanism rather than inferring it: the property goes
CSS seed -> 200px -> 72px, and the 200px is written when the header
stack ALREADY measures 72px (t=1552ms reserve=200px stack=72, corrected
at t=1612ms). usePhoneOverlayChromeReserve reads stack.offsetHeight
while the stack is transiently tall, publishes a value that is stale by
the time it lands, and its ResizeObserver then corrects it.
The CSS seed at globals.css:375 is correct for the settled stack, which
corrects the mechanism recorded on the now-archived #130 — that framed
the defect as the seed under-reserving by 0-8px. Measured, the driver is
a 128px transient over-reserve written by the hook, not the seed. / is
the control: it never writes the property and is the one clean route.
Variance is stated rather than smoothed: /dsm measured 0.363 and 0.219
across two runs, and this harness has no network throttling so /forms
and /therapy-compass run high locally. Only /dsm, /documents/search and
/ reproduced the live dispatch exactly.
Also recorded: attaching a MutationObserver to document.documentElement
inside a Playwright addInitScript throws before the document element
exists, silently killing the CLS observer and reporting a uniform
CLS=0.000 — a false clean bill that voided one run of this harness.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01361jh3eYVjJCzXWjAhdZiF
* docs(ledger): record the #151 capture review for PR #1506
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* docs(review): clarify snapshot branch state
* docs(ledger): record PR #1490 main sync after snapshot wording
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs: archive rendered style contract task
* docs: record style contract closure review
* docs: record synced style contract review
* docs: record post-121 style closure review
* docs: normalize style review ledger after sync
* docs: record post-1490 style closure review
* docs: record consolidated PR 1490 review
* docs: record replacement consolidation review
* docs: record reconciled consolidation review
* docs: record post-1511 consolidation review
* docs: normalize PR 1510 ledger after main sync
* docs: record PR 1510 post-sync review
* docs: correct false #98 canary evidence and NOTES triage
Remove the incorrect probe-collapse canary attribution from #98 and
point the unread --med-accent-soft note at #157 without breaking the
seven-token TOKENS_MISSING accounting.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): record PR #1510 evidence-correction review
Supersede the prior approve-with-no-findings row after correcting the
false #98 canary attribution and NOTES triage drift.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs: keep concurrency note inside issue table
* docs: record post-1513 consolidation review
* docs: address CodeRabbit notes on PR #1510
Fix the computed-value-time wording in design-sync notes, give #33 a
unique recommended-queue order, and drop the duplicated #98 Done block.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): record PR #1510 CodeRabbit fix review
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-syncOpt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent