Skip to content

Phone Choose mode: dense title-only glance list (production) - #1648

Merged
cursor[bot] merged 26 commits into
mainfrom
cursor/phone-mode-dense-production-05c0
Aug 8, 2026
Merged

Phone Choose mode: dense title-only glance list (production)#1648
cursor[bot] merged 26 commits into
mainfrom
cursor/phone-mode-dense-production-05c0

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Apply the dense glance list to the production phone Choose mode sheet (MasterSearchHeader) — not a mockup study.
  • Title-only mode rows (min-h-12); descriptions stay in aria-label so assistive tech keeps them.
  • Sheet description is Currently · {mode} instead of generic “Switch the clinical workspace mode.”
  • Stronger selected state (soft fill + left rail + check) without section organisation or roomy subtitle chrome.
  • Closed mockup-only PR Phone Choose mode: dense glance list (no Find/Diagnose/Care) #1644 per feedback.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed — UI chrome only; no clinical decision-support behaviour change

Test plan

  • npx eslint on master-search-header.tsx
  • Phone: open Mode → denser title-only list; pick Tools navigates
  • Desktop: mode dropdown still usable with title-only rows
  • CI: ui-smoke phone mode menu sheet tests

RAG impact

RAG impact: no retrieval behaviour change — mode-menu presentation only; no RAG surfaces touched.

Open in WebOpen in Cursor

Drop subtitle chrome from mode rows so more of the catalogue is visible
at once. Sheet header shows Currently · {mode}; selection keeps a left
rail and check. Descriptions remain in aria-label for assistive tech.
@coderabbitai

coderabbitaiBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:18 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9598598f-73a0-4547-8766-4a531ff9f046

📥 Commits

Reviewing files that changed from the base of the PR and between fc508dd and a942e56.

📒 Files selected for processing (1)
  • src/components/clinical-dashboard/master-search-header.tsx

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Change scopeneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #8434 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

cursoragentand others added 20 commits August 6, 2026 16:15
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Empty commit — prior CI run for this tip disappeared during the
GitHub Actions major outage (jobs timing out while queued).
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Prior CI run cancelled/timed out while queued during the GitHub
Actions major outage. Empty commit to re-fire checks on current tip.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

Autopilot + Bugbot — PR #1648

Tip:8100d3315b058f482baa1d87e7171e36d324ff1b (was 4e0cca2ccbc19ed676765b029642da0afea6215a)
Draft: yes | mergeable: MERGEABLE | mergeStateStatus: BLOCKED (draft + post-sync checks)

Sync / merge-tree

  • Pre-sync: merge-tree clean; then origin/main advanced (+2) → GitHub mergeStateStatus: BEHIND.
  • One late sync via authenticated update-branch (local push blocked by sibling worktree heavy lock + guard-push Prettier env fault).
  • Post-sync: merge-tree clean vs origin/main; behind 0 / ahead 21.

Threads

  • Unresolved review threads: 0 (no Bugbot/CodeRabbit inline findings on tip).
  • Issue comments only: CodeRabbit draft-skip, Supabase ignore, stale CI triage.

Review

  • Bugbot subagent: unavailable (usage limit). Manual delta review instead.
  • Delta: src/components/clinical-dashboard/master-search-header.tsx only — phone Choose-mode sheet densified to title-only rows; descriptions retained in aria-label; active left rail + check; min-h-12 preserved; sheet description Currently · {mode}.
  • Fixed: none (no P0/P1).
  • Dispositioned: shared renderModeMenuOptions() also densifies the desktop dropdown (scope bleed vs phone-only title). Residual UX note, not a correctness blocker.
  • RAG/ranking surfaces: not touched.

Required CI

  • On pre-sync tip 4e0cca2: PR required, Production UI critical, Production UI (1)(2)(3), Static PR, Build, Unit coverage, Safety — all pass.
  • Post-sync tip 8100d331: required checks re-running / in progress (expected after update-branch). Advisory ignored.

Local gates

  • verify:pr-local --dry-run selected lint/typecheck/test/build for the header file.
  • Focused Vitest not run — repository heavy lock held by C:\Dev\Apps\Database-wt-ds-a5 (vitest run).
  • verify:cheap / verify:pr-local not executed for the same lock reason; CI on the pre-sync tip covered the product delta.

Residual risks / blockers

  • Draft remains (merge left to user).
  • Desktop mode menu loses visible descriptions via shared renderer.
  • Post-sync required CI must finish green on 8100d331.
  • Ledger row appended locally only (not pushed — no ledger-only tip).

No product fix commits. Merge left to user.

Resolve master-search-header conflict: keep phone dense title-only
rows (PR) with main's full-height sheet and desktop min-height split.
Extract usesPhoneSearchLayout ? "min-h-12" : "min-h-[3.25rem]" as its own
cn() argument so audit-navigation-auth-regressions and mode-nav contracts pass
after merge conflict resolution, while keeping PR dense phone row padding.
cursorBot pushed a commit that referenced this pull request Aug 8, 2026
BigSimmo added a commit that referenced this pull request Aug 8, 2026
* docs(ledger): record Run PR sweep outcomes for open PRs
Append one superseding Run PR sweep row per PR touched in this pass
(conflict syncs, CI fixes, and review-thread code fixes).
* docs(ledger): supersede Run PR rows for #1648 and #1686 post-merge CI fixes
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursorBot marked this pull request as ready for review August 8, 2026 23:35
@cursor
cursorBot enabled auto-merge (squash) August 8, 2026 23:35
@cursor
cursorBot merged commit 2c04571 into mainAug 8, 2026
26 checks passed
@cursor
cursorBot deleted the cursor/phone-mode-dense-production-05c0 branch August 8, 2026 23:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent