Skip to content

Route mode-specific Search/Find tabs to the universal search (/?mode=…) - #1811

Merged
BigSimmo merged 1 commit into
mainfrom
codex/update-search-page-routing-to-new-version
Aug 11, 2026
Merged

Route mode-specific Search/Find tabs to the universal search (/?mode=…)#1811
BigSimmo merged 1 commit into
mainfrom
codex/update-search-page-routing-to-new-version

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Motivation

  • The Search/Find tabs in several mode navs still pointed at legacy mode-owned search pages; the goal is to open the new universal search page and preserve the active mode in the URL so the shared composer is used consistently.

Description

  • Use the universal selection href for mode search tabs by switching to appModeSelectionHref(...) for Differentials, DSM, Specifiers and Formulation in src/lib/mode-secondary-navigation.ts so those tabs open /?mode=<id>&focus=1 instead of their legacy mode-owned routes.
  • When returning to the universal composer, preserve the prior query as an editable draft but deliberately drop run=1 so the legacy redirect does not re-open the old mode-specific results page; keep per-mode selection-preservation logic for other in-mode destinations.
  • Add/adjust unit/DOM assertions to cover the new behaviour in tests/mode-secondary-navigation.test.ts and tests/page-secondary-navigation.dom.test.tsx to assert the registry hrefs and the rendered Find link for Specifiers.
  • Files changed: src/lib/mode-secondary-navigation.ts, tests/mode-secondary-navigation.test.ts, tests/page-secondary-navigation.dom.test.tsx.

Testing

  • Ran focused unit/DOM tests for the modified scope: tests/mode-secondary-navigation.test.ts and tests/page-secondary-navigation.dom.test.tsx, and all assertions in those files passed.
  • Performed a live local smoke check with the app (npm run ensure) and a Playwright phone flow that loaded /specifiers?q=pain&run=1, clicked the Specifiers "Find" link, and confirmed the browser routed to /?mode=specifiers&focus=1&q=pain (no run=1 bounce); a screenshot was captured for evidence.
  • Ran formatting (npm run format), lint, and typecheck as part of the PR-local verification and those stages passed.
  • Ran the repository PR-local verification (verify:pr-local) which completed the policy/format/lint/typecheck stages, but the full test run encountered 5 unrelated failures in tests/pr-handoff-stop.test.ts; these failures are not related to the routing changes introduced here and blocked the remaining build/verification stages.

If you want, I can open a PR with this patch and include the screenshot and test evidence, or I can (optionally) investigate the unrelated failing tests blocking the full PR-local gate before raising the PR.


Codex Task

@supabase

supabaseBot commented Aug 11, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:7 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab9cb73e-b637-4d3f-9607-270c769c1e81

📥 Commits

Reviewing files that changed from the base of the PR and between e8b61d8 and 4dbb5a4.

📒 Files selected for processing (3)
  • src/lib/mode-secondary-navigation.ts
  • tests/mode-secondary-navigation.test.ts
  • tests/page-secondary-navigation.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit cb23f86 into mainAug 11, 2026
25 of 26 checks passed
@BigSimmo
BigSimmo deleted the codex/update-search-page-routing-to-new-version branch August 11, 2026 08:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo