Route mode-specific Search/Find tabs to the universal search (/?mode=…) - #1811
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:7 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Motivation
Description
appModeSelectionHref(...)for Differentials, DSM, Specifiers and Formulation insrc/lib/mode-secondary-navigation.tsso those tabs open/?mode=<id>&focus=1instead of their legacy mode-owned routes.run=1so the legacy redirect does not re-open the old mode-specific results page; keep per-mode selection-preservation logic for other in-mode destinations.tests/mode-secondary-navigation.test.tsandtests/page-secondary-navigation.dom.test.tsxto assert the registry hrefs and the rendered Find link for Specifiers.src/lib/mode-secondary-navigation.ts,tests/mode-secondary-navigation.test.ts,tests/page-secondary-navigation.dom.test.tsx.Testing
tests/mode-secondary-navigation.test.tsandtests/page-secondary-navigation.dom.test.tsx, and all assertions in those files passed.npm run ensure) and a Playwright phone flow that loaded/specifiers?q=pain&run=1, clicked the Specifiers "Find" link, and confirmed the browser routed to/?mode=specifiers&focus=1&q=pain(norun=1bounce); a screenshot was captured for evidence.npm run format), lint, and typecheck as part of the PR-local verification and those stages passed.verify:pr-local) which completed the policy/format/lint/typecheck stages, but the full test run encountered 5 unrelated failures intests/pr-handoff-stop.test.ts; these failures are not related to the routing changes introduced here and blocked the remaining build/verification stages.If you want, I can open a PR with this patch and include the screenshot and test evidence, or I can (optionally) investigate the unrelated failing tests blocking the full PR-local gate before raising the PR.
Codex Task