docs(issues): capture the merge-loss findings as inbox requests - #1934
Conversation
Four merge-safe intake requests, no canonical ledger edit: - P1 rec: no gate detects a merged PR whose content is silently reverted by a later merge resolution. Blob sweep over origin/main found seven such PRs since 2026-08-06, six first wiped at one commit in the PR #1815 unblock chain. The reverts took each PR's tests in the same stroke, which is why nothing went red. - P2 task: re-land PR #1800 (fuzzy catalogue search) with the #310 one-edit cap applied in the same commit. - P2 task: re-land PR #1803 (--shadow-tight retirement); 67 files on main still reference the retired alias. - update #310: re-scoped. The defect is not reachable on main because the matcher is absent, not because it was fixed, so the row must not be closed and the fix belongs in the #1800 re-land. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:16 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:6f1cd23a34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #10733 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Four merge-safe ledger intake requests under
docs/outstanding-issues-inbox/. No canonical ledger edit —docs/outstanding-issues.mdis untouched, and the rows are allocated atnpm run issues:reconcileafter this lands.origin/main(for each file a merged PR changed, compareorigin/main's blob against the file's pre-merge parent blob; equality means the PR's change is gone) returned seven positives since 2026-08-06: Add conservative typo-tolerant fuzzy matching to catalogue searches #1800, Retire the --shadow-tight role alias onto the --e1 elevation tier #1803, Replace specifiers page breadcrumb/header with compactSpecifierToolHeader#1809, Route mode-specific Search/Find tabs to the universal search (/?mode=…) #1811, Remove cross-mode “Also matches in other modes” panel and related mounts/tests #1804, chore(deps): bump node from 24-bookworm-slim to 26-bookworm-slim in the docker-images group #1796, Tighten the mode-home hero rhythm and put its glyphs on the icon scale #1815. Six first show the wiped state at one commit,acf78bf("Merge remote-tracking branch 'origin/main' into probe2-1815"), part of the PR Tighten the mode-home hero rhythm and put its glyphs on the icon scale #1815 unblock chain. The reverts took each PR's tests in the same stroke, which is why no gate went red. This is#311's ledger loss-detector generalised from docs to source.#310one-edit cap in the same commit rather than re-landing the known defect.--shadow-tightretirement onto--e1).git grep -l shadow-tightoversrc/onmainstill returns 67 files, which confirms the loss without relying on blob identity.#310— re-scoped. The cross-drug match is not reachable onmainbecause the matcher is absent, not because it was fixed, so the row must not be closed and the fix belongs in the Add conservative typo-tolerant fuzzy matching to catalogue searches #1800 re-land.Each item is its own request file and its own bullet, per the PR-bundling rule; all four are append-only ledger intake, no product behaviour.
Note on branch history: PR #1920 merged and its branch was deleted while this session held a stale remote ref, so the branch was restarted from
origin/mainand force-with-lease pushed. It now carries exactly one commit — the four JSON files — and none of #1920's already-merged history.Verification
npm run verify:pr-localAdditionally, the pending batch was dry-applied against
origin/main's ledger to prove it reconciles cleanly: 23 requests, 114 open rows → 118, marker advances toissues:next-id=320, andcheckIssuesreports 5 problems before and 5 after — the same pre-existingprettier-ignorefindings already present onmain, so this change introduces none.UI verification not run: no UI, routing, styling, or browser behaviour changed.
Risk and rollout
issues:reconcileruns.ledger-inbox.mjs cancelbefore reconciliation.Notes
The two re-land tasks are deliberately filed as separate rows rather than one, because they need separate PRs:
catalog-search.tsisclinicalRisk: trueunderclassifyPullRequestFiles(it feedsmedications.tsand prescribing) and carries a Clinical Governance Preflight, while the token retirement does not. Re-landing #1803 should also move thelegacyShadowAliasesmeasurement that open row#302records as pinned at 220 against a measured 193, so#302wants re-measuring afterwards rather than actioning on its current numbers.The remaining five flagged PRs (#1809, #1811, #1804, #1796, #1815) are blob-evidence only. They are recorded inside the detector row as the sweep's output, not filed as individual re-land tasks, because a deliberate later revert is indistinguishable from a merge loss at blob level and each needs a human look first.
Generated by Claude Code