Close the resolved ranking snapshot refresh task accurately - #1932
Conversation
…artifact The snapshot's generatedAt (2026-07-20) was 24 days old and about to trip the 30-day freshness gate in tests/ranking-tuning.test.ts (~2026-08-19), which would have failed the whole unit suite on every branch. Regenerated from the eval-canary-output artifact of scheduled run 31329507691 (2026-08-09, green: 36/36 cases, doc/content recall 1.0/1.0, zero failed cases; artifact sha256 verified against the GitHub artifact digest) via npm run build:ranking-snapshot -- --source-run-id 31329507691. No new provider dispatch was needed — the weekly run's artifact was still inside the 30-day retention window. Closes /issues #304. RAG impact: no retrieval behaviour change — snapshot re-measurement from a green live canary artifact; golden fixture, ranking code, and eval harness untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoHPMZ1FinSYzH7rJ42xTo
The Codex auto-resolve pass pushed its own version of the PR #1843 review fixes after the PR had already merged with the same fixes in ea357ca (which main now carries in stronger form: separate unavailableMetrics channel and CLI exit-code tests). Content is taken wholly from the current branch; 5ef02f7 is kept in history only so the branch can push without a rewrite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoHPMZ1FinSYzH7rJ42xTo
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoHPMZ1FinSYzH7rJ42xTo
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:3b6a8a9e72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:38 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
BigSimmo
commented
Aug 13, 2026
Codex final review summaryFinal state
Issues fixed and dispositioned
Independent adversarial reviewCodeRabbit could not complete an independent review because the organisation had reached its temporary review limit and spending cap. I therefore performed a separate manual adversarial pass covering provenance semantics, generated metadata, issue-ledger schema, RAG/runtime impact, privacy and security boundaries, immutable review-record rules, scope creep and missing verification. No additional actionable P0, P1 or reproducible P2 defect was found. Review threads
Decisive verification
Exact-head required CIOn
Advisory and scope-skipped checksVisual baselines, advisory UI, build, Lighthouse, release-browser matrix, migration replay and container-image jobs were skipped by change scope. No live canary, paid/provider-backed evaluation, production test, Lighthouse run, deployment or release was performed. Limitations and residual risk
The PR was not merged. Final merge is left to the user. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
#304through the merge-safe inbox flow.mainalready contains the substantive ranking snapshot refresh from successful weekly canary run31329507691in commitd1828441.sourceRunStartedAtwas2026-08-09T18:37:32Z, so the effective 30-day boundary is2026-09-08T18:37:32Z.generatedAtre-stamp from the same source artifact. The candidate payload, source run, and provenance are unchanged, so this metadata-only delta does not extend the stricter source-run freshness gate and does not affect runtime retrieval.eval-canaryartifact and to update snapshot and provenance together.mainonce at merge commit630351c. No rebase, force-push, history rewrite, deployment, or provider-backed evaluation was performed.RAG impact: no retrieval behaviour change — the only fixture delta is
generatedAtfor an unchanged source run and unchanged candidate payload. Ranking logic, provenance, and runtime retrieval are unchanged.Verification
donerequest schema.generatedAtonly.31329507691completed successfully with 36/36 cases, document/content recall 1.0/1.0, and zero failed cases. Its artifact metadata was verified.CI,PR required,Unit coverage,Static PR checks,Safety and config checks,SAST, and secret-scanning checks completed successfully before this body-only update.Risk and follow-up
npm run issues:reconcileworkflow to apply the inbox request to the canonical outstanding-issues ledger.sourceRunStartedAt, notgeneratedAt, and use a newer successful canary artifact before the source-run freshness boundary.Clinical Governance Preflight