Remove Evidence-based and All sources chips from answer footer - #304
Merged
Conversation
BigSimmoforce-pushed
the
cursor/fix-all-db-issues-5f13
branch
from
July 5, 2026 19:11
09b3567 to
8ab94eaCompareBigSimmo
marked this pull request as ready for review
July 6, 2026 02:33
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Promote batch not transactional
- Replaced non-transactional per-document and artifact updates with a single promote_indexed_documents_public_batch RPC that atomically promotes documents and all eight artifact tables in one database transaction.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 66126e9. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
BigSimmoforce-pushed
the
cursor/remove-answer-bar-chips-8b1a
branch
from
July 6, 2026 04:47
cd7cb5b to
123bb9eCompareBigSimmoforce-pushed
the
cursor/remove-answer-bar-chips-8b1a
branch
from
July 6, 2026 04:59
123bb9e to
9ad4a30Compare…tedChipRow Align MasterSearchHeader with main after chip removal: wire onBottomComposerScrollHiddenChange for typecheck and remove the integratedChipRow prop that ModeActionPopup no longer accepts.
Take main's footer chip removal, scroll-hide composer, and follow-up suggestions. Keep branch test and capture script updates.
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Defer focus restoration until after the scope popover unmounts, and use double requestAnimationFrame in dismissable layers so Escape reliably returns focus to the answer options trigger.
Uh oh!
There was an error while loading. Please reload this page.
Merged
11 tasks
BigSimmo pushed a commit
that referenced
this pull request
Aug 12, 2026
… issues, contract pins Review of the RAG canary infrastructure (2026-08-12) found the mechanism sound but with manual/silent gaps. This change mechanizes and pins them; no retrieval behaviour changes. - compare-retrieval-eval: new per-case rr@10/contentRR@10 diff with --fail-on-regression, mechanizing the canary-pair protocol's 'zero per-case rr regressions' gate that was previously eyeballed from tee'd logs; fails closed on summary-only artifacts and non-identical case sets. - eval-canary.yml: open the failure issue on failed dispatches too (a red dispatch is usually half a canary pair), and feed answer-targeting.log, validate_override and answer_targeting outcomes into the issue body. - build-ranking-snapshot: fail loudly when a hardNegativeTemplates caseId matches no artifact case (a renamed golden case previously dropped its hard negatives silently); CLI guarded so tests can import convertArtifact. - New contract tests: hard-negative attachment guard, and a strict/wide alias-tier pin so a bulk merge of src/lib/eval-document-matching.ts into scripts/lib/clinical-aliases.ts can no longer pass CI. - docs/rag-behaviour: fix stale claims that the canary has workflow_dispatch / a ref input (both deliberately absent); document the per-case compare command. - outstanding-issues: capture the snapshot-freshness dispatch handoff (#304) and deferred canary observations (#305). RAG impact: no retrieval behaviour change — canary tooling, docs, and contract-test hardening only; golden fixture and ranking code untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoHPMZ1FinSYzH7rJ42xTo
BigSimmo pushed a commit
that referenced
this pull request
Aug 12, 2026
…d rows The conflict was one hunk. Resolved by keeping this branch's #302 (re-measured 2026-08-12, newer than main's) and all four of main's genuinely new rows (#304, #305, #306, #307), dropping only main's older #302 and its #303, which this branch had already archived as delivered after probing the CLI. Correcting an earlier claim in this branch's history: #302 and #303 were NOT lost by main. Main renumbered them to #306 and #307 after the id collision, which is exactly what the guard advises. Both are re-filings of work already done, and both are archived here with evidence — style-contracts.ts:352-354 is clean, and the marker reads 308 against a highest declared id of 307. The derived loss detector reports one exception, #262, which is intentional: main's version of that row is newer than this branch's. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017paT42ZVMf8jaLtkjFxdy5
BigSimmo pushed a commit
that referenced
this pull request
Aug 12, 2026
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
BigSimmo added a commit
that referenced
this pull request
Aug 13, 2026
… queue text (#1890) * docs(issues): retire 22 non-actionable ledger rows and correct the #231 queue text A yield review of all 114 open rows against current main. The queue had become roughly 60 tasks and 50 notes; this removes the notes and fixes two places where the ledger was actively misdirecting. The correction that matters most: the recommended-queue entry for #231, the top clinical P1, told every session to "measure and fix the fast-route budget / generation timeout" — an approach #231's own detail records as tested and rejected, because the decisive 40-second probe completed generation in 25.272s with route_deadline_exceeded=false and still failed quality. The session-start hook prints the queue, not the row, so the refuted text was the text agents read. Closed 22 rows: - #304 was already done on main (commit d182844 refreshed the ranking snapshot; generatedAt is 0 days old, not 2026-07-20), yet sat in the queue advertising a freshness fuse that is not armed. - #241#244#272#294#300#257 were standing cautions whose own text says "no action". Each one's knowledge now lives in the code it protects, so closing the row loses nothing. - #196-#200 are five steps of the disaster-recovery checklist that is canonical in docs/operator-backlog.md, with no trigger until a restore. - #86#188 were index rows over children that are individually findable. - #250#253#254 were superseded; #250 and #253 say so themselves. - #156#301#152#236#260 merged into #168, #292 and #169 respectively — each pair or group was one problem recorded two to four times. Demoted 20 rows with a stated reason (premature ops for a single-user prototype, upstream-blocked, measurement-gated, or design-system adoption competing with an open clinical P1). The Pri cell is unchanged because the writer has no --pri flag — which is now #313. Added three rows for mechanism gaps this sweep exposed: rows outliving their own completion (#312), the missing --pri flag (#313), and the queue being able to contradict the row it cites with no guard (#314). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU * docs(ledger): record the ledger yield review handoff Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYJz8hauCsCdx8r4fXiZU * Keep recovery work visible and pin forced colors --------- Co-authored-by: Claude <noreply@anthropic.com>
BigSimmo pushed a commit
that referenced
this pull request
Aug 13, 2026
…artifact The snapshot's generatedAt (2026-07-20) was 24 days old and about to trip the 30-day freshness gate in tests/ranking-tuning.test.ts (~2026-08-19), which would have failed the whole unit suite on every branch. Regenerated from the eval-canary-output artifact of scheduled run 31329507691 (2026-08-09, green: 36/36 cases, doc/content recall 1.0/1.0, zero failed cases; artifact sha256 verified against the GitHub artifact digest) via npm run build:ranking-snapshot -- --source-run-id 31329507691. No new provider dispatch was needed — the weekly run's artifact was still inside the 30-day retention window. Closes /issues #304. RAG impact: no retrieval behaviour change — snapshot re-measurement from a green live canary artifact; golden fixture, ranking code, and eval harness untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoHPMZ1FinSYzH7rJ42xTo
BigSimmo added a commit
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
verify✅ui-smoke✅main)