revert(rag): back out #2065 claim-leading condition binding after live canary regression - #2088
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:20 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 99 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Summary
fix(rag): bind claim-leading for/in conditions in the high-risk trigger check, commit18a535cde, merge964869fc3) — a single-commit revert perdocs/rag-behaviour/protocol after the post-merge live canary regressed.9904fbda8) failed the answer gate onagitation-im-po-route-short-terms("What IM or PO options are listed for agitation?"): extractive route, identicaltopFiles, but routing reason becamehigh_confidence_extractive_retrieval; claim_support_high_risk_gap; source_backed_review_fallback; extractive_quality_gate:template_like_answer; numeric_faithfulness_gate_source_gap→grounded:false, 0 citations,citation_failure_rate 0.0227. The prior canary (32052479537 on084f63799) had the same case grounded with 5 citations. Retrieval golden set: 36/36, zero per-case rr regressions in both runs.aade20aba(parent of fix(rag): bind claim-leading for/in conditions in the high-risk trigger check (S1c follow-up) #2065) → 5 citations;964869fc3(fix(rag): bind claim-leading for/in conditions in the high-risk trigger check (S1c follow-up) #2065) → 0 citations; fix: clear the theme-transition timer leak and let issues:done close ULID-id ledger rows #2063, feat(rag): tag document-summary rows with a document_context provenance origin #2053 (G1), fix(rag): recover fast-route final-gate source gaps extractively (packet S1d) #2054 (S1d) heads all inherit the failure. The regressing change is the new condition-binding regex/^\s*(?:for|in)\s+([^,;.!?]{1,60}?)\s*,/giinsrc/lib/rag/rag-claim-support.ts, which makes a claim-leading "For X, …" / "In X, …" bind X as a required condition token; on this extractive answer that flips a supported claim to high-risk-unsupported and cascades to an ungrounded review fallback.RAG impact: behaviour change — canary pair 32052479537 (last green,
084f63799) -> post-merge confirmation dispatch; this restores the claim-support behaviour that run 32052479537 measured green.Verification
"routing_reason": "high_confidence_extractive_retrieval", "citation_count": 5(was 0 on main).npx vitest run tests/rag-claim-support.test.ts—Tests 157 passed (157).npm run eval:rag:offline—Test Files 25 passed (25) · Tests 614 passed (614);Offline RAG fixture and production-contract checks passed.npm run check:rag:fixtures—Offline RAG fixture and manifest validation passed (36 golden cases, 25 suites).npm run check:production-readiness—READY: no blocking production-readiness failures.All matched files use Prettier code style!Risk and rollout
rag-claim-support.tsto the exact state the last green canary measured. The R2/R3 work from fix(rag): verify imperative dosing claims against descriptive guideline norms (packet S1c, R2+R3) #2052 and fix: clear the theme-transition timer leak and let issues:done close ULID-id ledger rows #2063 remains in place.Clinical Governance Preflight
Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
/issues).afbf14737underdocs/branch-review-records/.Opened by the RAG programme coordinator chat (Claude Code).