Fix stale shared-home CI expectations

[Copilot]

Summary

• Align stale shared-home tests with current production contracts so the failing Actions job passes again.
• Shared-home contract updates
  • accept sharedHomePresentation as { title, subtitle, suggestions }
  • expect Therapy’s shared-home heading to be Therapy, matching current user-facing copy
• Scope
  • test-only change; no runtime behavior or UI logic changed

expect(Object.keys(sharedHomePresentation[modeId]).sort()).toEqual(["subtitle","suggestions","title",]);

Verification

• npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
• npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

• npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
• npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
• npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
• npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Verification not run: npm run verify:pr-local — this fix is test-only; ran the targeted failing suite instead: npm test -- --run tests/shared-home-empty-state.dom.test.tsx tests/mode-home-no-caveat-footer.test.ts (Test Files 2 passed (2), Tests 34 passed (34)).

UI verification not run: test-only change; no UI/runtime behavior changed.

Risk and rollout

• Risk: Low — updates stale test expectations only.
• Rollback: Revert this commit.
• Provider or production effects: None
• RAG impact: none

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Clinical Governance Preflight not applicable: no clinical, data, retrieval, privacy, or production behavior changed.

Notes

• Root cause from the failing job: tests still expected ["subtitle", "title"] and Therapy Compass, while the shipped contract is ["subtitle", "suggestions", "title"] and Therapy.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.