Skip to content

Fix stale shared-home CI expectations#2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 2 commits into from
Aug 19, 2026
Merged

Fix stale shared-home CI expectations #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8254b6
Initial plan
Copilot Aug 19, 2026
fe1f15f
Fix stale shared-home test expectations
Copilot Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/mode-home-no-caveat-footer.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,10 @@ describe("mode homes carry no caveat footer", () => {

it("leaves no caveat copy in the shared-home presentation table", () => {
// The copy route into the same defect: a mode could carry the line as data
// rather than as a component. Every entry is exactly a title and a subtitle.
// rather than as a component. The table now also carries starter
// suggestions, but it must not grow any caveat/footer field.
for (const modeId of appModeIds) {
expect(Object.keys(sharedHomePresentation[modeId]).sort(), modeId).toEqual(["subtitle", "title"]);
expect(Object.keys(sharedHomePresentation[modeId]).sort(), modeId).toEqual(["subtitle", "suggestions", "title"]);
}
});
});
10 changes: 5 additions & 5 deletions tests/shared-home-empty-state.dom.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ const expectedPresentations = [
},
{
modeId: "therapy-compass",
title: "Therapy Compass",
title: "Therapy",
subtitle: "Source-grounded therapy records.",
iconClass: "lucide-compass",
},
Expand DownExpand Up@@ -129,11 +129,11 @@ describe("SharedHomeEmptyState", () => {
expect(icon).toHaveClass(iconClass);
expect(icon).toHaveAttribute("aria-hidden", "true");

// No mode home carries a caveat line under the composer any more, and no
// mode may reintroduce one as filler: the presentation table is exactly a
// title and a subtitle.
// No mode home carries a caveat line under the composer any more. The
// shared-home table now also feeds mode-specific starter suggestions, so
// the contract is title + subtitle + suggestions — and nothing else.
const presentation: SharedHomePresentation = sharedHomePresentation[modeId];
expect(Object.keys(presentation).sort()).toEqual(["subtitle", "title"]);
expect(Object.keys(presentation).sort()).toEqual(["subtitle", "suggestions", "title"]);
},
);

Expand Down