docs(issues): queue the #DREDWA residual test-coverage gap raised in review - #2224
Conversation
Codex review on PR #2217 argued #DREDWA had been closed prematurely. Verified against the code: the inbox done path IS driven with the ULID display id #6BG9X2 in tests/repo-hygiene.test.ts, and the all-digit #041061 case covers addIssue, resolveIssue, updateIssue and issueRowFingerprint, so the recorded failure mode is guarded and the closure stands. The genuine residual is narrower: the inbox update action is only ever applied against legacy #1, and ledger-inbox.mjs --self-test builds every fixture from #1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:5 minutes Limit details: You’ve used the included review currently available. Your 87 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Summary
Queues one inbox request recording the residual test-coverage gap that a Codex review raised against the
#DREDWAclosure in pull request #2217. One additive JSON file underdocs/outstanding-issues-inbox/; no other file is touched and the canonical ledger is not edited.The review argued
#DREDWAhad been closed prematurely, on two specific grounds. Both were checked against the code rather than accepted, and both turn out to be inaccurate:tests/repo-hygiene.test.tscontainsfingerprints and closes ULID-display-id rows minted by reconcile, which drivesapplyRequestwithaction: "done"against the ULID display id#6BG9X2, asserts the row is archived, and asserts the stale-fingerprint path throws. The inboxdonepath is therefore exercised with a modern id, not onlyadd.scripts/outstanding-issues.mjsself-tests driveaddIssue,resolveIssueandupdateIssueagainst#041061(done archives all-digit Crockford #041061), andscripts/check-outstanding-issues.mjsresolvesissueRowFingerprintfor#041061with an explicit failure message.#DREDWAtherefore stays closed: its recorded failure mode —issueRowFingerprintreturning null for Crockford locators, which madeissues:doneandissues:updateunusable for every row minted since the ULID migration — is guarded by tests.What the review did surface, and what this request records, is genuinely uncovered and narrower than the original row: the inbox
updateaction is only ever applied against legacy#001, since the ULID test coversdonealone; andscripts/ledger-inbox.mjs --self-testbuilds itsdone,update,canceland reconcile fixtures entirely from#001, so the self-test shipped with the writer would not catch an id-scheme regression by itself. The request names both gaps, the two places to add coverage, and the focused command that proves it.It is filed as a request rather than fixed inline because the fix is executable test code, which does not belong in a ledger-scoped change; it is a small offline job for its own pull request.
Verification
npm run check:outstanding-issues—Ledger inbox check passed: 5 pending request(s), 438 applied.andOutstanding-issues guard passed: 411 rows (61 open, 350 archived), unique display and durable ids, collision-free allocation enabled, deprecated next-id marker ignored, no merge driver, no ids deleted from base e2de814ebdb6.npx prettier --checkon the added file —All matched files use Prettier code style!UI verification not run: no executable product code, route, component, style or browser behaviour is touched.
Risk and rollout
git revertthis pull request, or delete the request file before reconciliation runs.src/lib/rag/, no retrieval RPC, no ranking configuration, no eval harness and no golden fixture is touched.Notes
The review thread on pull request #2217 has been answered with the same findings and resolved. Branch
claude/ledger-reconcile-2026-08-21was recreated by a push that raced the squash-merge of #2217; it carries no unmerged content and can be deleted.🤖 Generated with Claude Code