Skip to content

docs(issues): queue the #DREDWA residual test-coverage gap raised in review#2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Aug 21, 2026
Merged

docs(issues): queue the #DREDWA residual test-coverage gap raised in review #2224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/outstanding-issues-inbox/0de7c846-b53f-42e5-ab1d-fe43135c1eef.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
{
"version": 2,
"id": "0de7c846-b53f-42e5-ab1d-fe43135c1eef",
"createdOn": "2026-08-21",
"action": "add",
"payload": {
"pri": "P3",
"type": "task",
"summary": "Ledger inbox update path is never driven with a modern Crockford display id, and ledger-inbox.mjs --self-test uses only legacy #001",
"detail": "Residual of #DREDWA, surfaced by a Codex review finding on PR #2217 and then measured rather than accepted. WHAT IS ALREADY COVERED, so this is a narrow gap and not a reopening: tests/repo-hygiene.test.ts 'fingerprints and closes ULID-display-id rows minted by reconcile' drives applyRequest with action done against the ULID display id #6BG9X2, asserts the row is archived, and asserts the stale-fingerprint path throws; scripts/outstanding-issues.mjs self-tests drive addIssue, resolveIssue and updateIssue against the all-digit Crockford id #041061 ('done archives all-digit Crockford #041061'); and scripts/check-outstanding-issues.mjs self-tests resolve issueRowFingerprint for #041061 with an explicit failure message. The original bug and its stated failure mode are therefore guarded. WHAT IS STILL UNCOVERED: (1) the inbox update action is only ever applied against legacy #001 - the ULID test covers done alone; (2) scripts/ledger-inbox.mjs --self-test builds its done, update, cancel and reconcile fixtures entirely from #001, so the self-test that ships with the writer would not catch an id-scheme regression on its own. NEXT: add a ULID-display-id update case beside the existing done case in tests/repo-hygiene.test.ts, and give ledger-inbox.mjs --self-test one modern-id row (ideally the all-digit #041061 shape) driven through done, update and reconcile. Small and offline-testable; npm run test:focused -- --files tests/repo-hygiene.test.ts plus npm run check:outstanding-issues covers it.",
"source": "Codex review comment 3829158494 on PR #2217, verified against tests/repo-hygiene.test.ts, scripts/outstanding-issues.mjs, scripts/check-outstanding-issues.mjs and scripts/ledger-inbox.mjs on 2026-08-21",
"issueUlid": "01M0HVMDAY3SG2H9QYYC5CNNWQ"
}
}
Loading