Skip to content

Add the Tools Show all chip to Calculators pages - #2337

Merged
BigSimmo merged 9 commits into
mainfrom
cursor/calculators-show-all-mockups-7ce3
Aug 24, 2026
Merged

Add the Tools Show all chip to Calculators pages#2337
BigSimmo merged 9 commits into
mainfrom
cursor/calculators-show-all-mockups-7ce3

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Extract the Tools soft-fill well Show all chip into a shared ShowAllChip so Tools and Calculators cannot drift.
  • Place that chip on every Calculators hero and search surface: the shared home at /?mode=calculators, the catalogue at /calculators/search, CalculatorSearchHome, and the matching calculator search mockups.
  • Keep an empty /calculators/search visit on the browsable catalogue instead of bouncing back to the shared home, so Show all has a real destination.

Verification

  • Focused DOM/redirect coverage: npx vitest run tests/calculators-mode.dom.test.tsx tests/consolidated-mode-home-redirect.test.ts tests/favourites-auth-gate.dom.test.tsx tests/calculators-show-all-mockups.dom.test.tsx tests/calculator-mockup-boundary.test.ts tests/shared-home-empty-state.dom.test.tsx
    • Decisive line: Test Files 6 passed (6) / Tests 70 passed (70)
  • Phone proof at http://localhost:4461/?mode=calculators (project id clinical-kb:c52ddf65534b): Show all is under the hero; click lands on /calculators/search with the 8-calculator catalogue and does not bounce home. The same chip stays on the catalogue and on ?q=depression&run=1.
  • npm run verify:pr-local — not run; the focused suite covers the changed routing and chip contracts.
  • npm run verify:ui — not run; phone journey was exercised locally instead of the full Chromium gate.
  • npm run verify:release — not requested.

Calculators phone home with Show all chip
Calculators catalogue after Show all
calculators_phone_show_all_to_catalogue.mp4

Risk and rollout

  • Risk: An empty /calculators/search now lists the calculator catalogue instead of redirecting home. Differentials keep the no-browse redirect. The chip is a navigation control only; scoring, citations, and answer generation are unchanged.
  • Rollback: Revert this commit. The previous empty-search redirect and Tools-only chip return.
  • Provider or production effects: None
  • RAG impact: no retrieval behaviour change — this only adds a catalogue navigation chip and lets /calculators/search browse the existing fixture list. No RAG ranking, retrieval, or answer-generation surfaces are touched.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

The catalogue still presents the same source-cited scoring tools. Scores remain decision-support only and do not replace clinical judgement. Opening the full list from home does not change how a calculator scores, cites, or degrades.

Notes

The visual treatment matches the live Tools home chip: 36px tinted capsule, hairline icon well, 48px phone tap target (min-h-tap).

To show artifacts inline, enable in settings.

Open in WebOpen in Cursor

Rebuild the Tools launcher chip for a Calculators home with four interiors: the shipping transplant, a matched wordmark, a recommended icon-well capsule, and a symmetric count pair.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitaiBot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 55 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f0d1abc9-bdad-48de-9b13-5a4c68804463

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc2103 and e6888b9.

⛔ Files ignored due to path filters (3)
  • docs/search-chrome-behaviour.md is excluded by !docs/**, !**/*.md
  • docs/site-map.md is excluded by !docs/**, !**/*.md
  • mockups/README.md is excluded by !mockups/**, !**/*.md
📒 Files selected for processing (20)
  • scripts/generate-site-map.ts
  • src/app/(search-app)/calculators/search/page.tsx
  • src/app/(search-app)/differentials/search/page.tsx
  • src/app/mockups/calculators-show-all/page.tsx
  • src/app/mockups/mockups-layout-client.tsx
  • src/components/applications-launcher-page.tsx
  • src/components/calculator-mockups/index.ts
  • src/components/calculator-mockups/search-detail-mockup.tsx
  • src/components/calculator-mockups/search-page-mockup.tsx
  • src/components/calculator-mockups/show-all-directions-mockup.tsx
  • src/components/calculators/search-detail.tsx
  • src/components/calculators/search-page.tsx
  • src/components/clinical-dashboard/answer-status.tsx
  • src/components/mode-home-template.tsx
  • src/components/show-all-chip.tsx
  • src/lib/consolidated-mode-home-redirect.ts
  • tests/calculators-mode.dom.test.tsx
  • tests/calculators-show-all-mockups.dom.test.tsx
  • tests/consolidated-mode-home-redirect.test.ts
  • tests/favourites-auth-gate.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 24, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review August 24, 2026 11:00
Keep the Tools-like phone home unchanged and vary only the Show all chip: outline, soft fill, and icon well.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Add Calculators Show all chip mockup directionsAdd three Calculators Show all button phone mockupsAug 24, 2026
cursor[bot]
cursorBot previously approved these changes Aug 24, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; remaining signals and the mockup-only scope do not require human review. No reviewers assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:106f8e07d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/components/calculator-mockups/show-all-directions-mockup.tsx Outdated
@cursorcursorBot changed the title Add three Calculators Show all button phone mockupsAdd three Calculators Show all button-style phone mockupsAug 24, 2026
Keep the 48px tap target and implement a 36px soft capsule with a 28px icon well on Tools home. Add two tighter phone mockups beside the recommended style.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Add three Calculators Show all button-style phone mockupsPolish Tools Show all chip and two phone mockupsAug 24, 2026
cursor[bot]
cursorBot previously approved these changes Aug 24, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; remaining signals and the visual Show all chip plus mockup scope do not require human review. No reviewers assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #13693 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

Keep the 36px capsule and 48px tap, but tint the fill and add a hairline well so the hybrid of options 2 and 3 actually reads on the Tools home.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
cursor[bot]
cursorBot previously approved these changes Aug 24, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; remaining signals and the visual Show all chip plus mockup scope do not require human review. No reviewers assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

Extract the soft-fill well chip so Tools and Calculators share one control, place it on the Calculators home and search surfaces, and keep an empty /calculators/search visit on the catalogue instead of bouncing home.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Polish Tools Show all chip and two phone mockupsAdd the Tools Show all chip to Calculators pagesAug 24, 2026
cursor[bot]
cursorBot previously approved these changes Aug 24, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; remaining signals and current review state do not require human review. No reviewers assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

check:design-system-contract's arbitraryTracking ratchet flagged the new
Show all chip's tracking-[-0.01em]. -0.01em folds into --tracking-display
(-0.02em) per the documented letterspacing scale in globals.css, so switch
to the sanctioned tracking-[var(--tracking-display)] form.
cursor[bot]
cursorBot approved these changes Aug 24, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first check poll, so that signal was skipped; remaining signals and current review state do not require human review. No reviewers assigned.

Open in WebView Automation

Sent by Cursor Approval Agent: Pull Request Router and Approver

@BigSimmo
BigSimmo merged commit f3cd66c into mainAug 24, 2026
28 checks passed
@BigSimmo
BigSimmo deleted the cursor/calculators-show-all-mockups-7ce3 branch August 24, 2026 15:27
BigSimmo added a commit that referenced this pull request Aug 24, 2026
* Add branch review record for PR #2342 sweep
Records the Run-PR-style sweep check on PR #2342 (Improve Therapy
best-match visibility): review comments already fixed, branch synced
from main, CI green on completed checks.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
* docs(ledger): record Run PR sweep of Dependabot PRs #2296, #2297, #2325, #2326
Immutable review records for the four-PR dependency sweep: CI fix on
#2325, clean main-syncs on #2296/#2297, and diagnosis-only on #2326
(Node 26 Docker bump incompatible with the engine-strict Node 24 pin).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
* Add branch review record for PR #2339 sweep
Records the Run-PR-style sweep check on PR #2339 (therapy comparison
mobile design mockups): already fully green, only needed a main sync.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
* Add branch review records for PR #2341, #2347 sweep
Records the Run-PR-style sweep checks on #2341 (dictionary filter
band, fixed via main sync, unrelated flake confirmed) and #2347
(browser test gate handoff, fixed stale generated file + doc-link
allowlist entries; owner closed the PR mid-sweep for unrelated reasons).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
* Add branch review records for PR #2338, #2337, #2333 sweep
Records the Run-PR-style sweep checks: #2337 fixed a design-token
ratchet failure, #2333 fixed a tap-target size regression and
resolved a concurrent-push merge, #2338 was only a main sync. #2333
and #2338 still have an open PR-policy failure (missing Clinical
Governance Preflight section) left for the PR author to fill in.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
---------
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BigSimmo@cursoragent@claude