Add the Tools Show all chip to Calculators pages - #2337
Conversation
Rebuild the Tools launcher chip for a Calculators home with four interiors: the shipping transplant, a matched wordmark, a recommended icon-well capsule, and a symmetric count pair. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (20)
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Keep the Tools-like phone home unchanged and vary only the Show all chip: outline, soft fill, and icon well. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:106f8e07d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Keep the 48px tap target and implement a 36px soft capsule with a 28px icon well on Tools home. Add two tighter phone mockups beside the recommended style. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #13693 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Keep the 36px capsule and 48px tap, but tint the fill and add a hairline well so the hybrid of options 2 and 3 actually reads on the Tools home. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Extract the soft-fill well chip so Tools and Calculators share one control, place it on the Calculators home and search surfaces, and keep an empty /calculators/search visit on the catalogue instead of bouncing home. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
check:design-system-contract's arbitraryTracking ratchet flagged the new Show all chip's tracking-[-0.01em]. -0.01em folds into --tracking-display (-0.02em) per the documented letterspacing scale in globals.css, so switch to the sanctioned tracking-[var(--tracking-display)] form.
Uh oh!
There was an error while loading. Please reload this page.
* Add branch review record for PR #2342 sweep Records the Run-PR-style sweep check on PR #2342 (Improve Therapy best-match visibility): review comments already fixed, branch synced from main, CI green on completed checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1 * docs(ledger): record Run PR sweep of Dependabot PRs #2296, #2297, #2325, #2326 Immutable review records for the four-PR dependency sweep: CI fix on #2325, clean main-syncs on #2296/#2297, and diagnosis-only on #2326 (Node 26 Docker bump incompatible with the engine-strict Node 24 pin). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1 * Add branch review record for PR #2339 sweep Records the Run-PR-style sweep check on PR #2339 (therapy comparison mobile design mockups): already fully green, only needed a main sync. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1 * Add branch review records for PR #2341, #2347 sweep Records the Run-PR-style sweep checks on #2341 (dictionary filter band, fixed via main sync, unrelated flake confirmed) and #2347 (browser test gate handoff, fixed stale generated file + doc-link allowlist entries; owner closed the PR mid-sweep for unrelated reasons). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1 * Add branch review records for PR #2338, #2337, #2333 sweep Records the Run-PR-style sweep checks: #2337 fixed a design-token ratchet failure, #2333 fixed a tap-target size regression and resolved a concurrent-push merge, #2338 was only a main sync. #2333 and #2338 still have an open PR-policy failure (missing Clinical Governance Preflight section) left for the PR author to fill in. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1 --------- Co-authored-by: Claude <noreply@anthropic.com>


Summary
ShowAllChipso Tools and Calculators cannot drift./?mode=calculators, the catalogue at/calculators/search,CalculatorSearchHome, and the matching calculator search mockups./calculators/searchvisit on the browsable catalogue instead of bouncing back to the shared home, so Show all has a real destination.Verification
npx vitest run tests/calculators-mode.dom.test.tsx tests/consolidated-mode-home-redirect.test.ts tests/favourites-auth-gate.dom.test.tsx tests/calculators-show-all-mockups.dom.test.tsx tests/calculator-mockup-boundary.test.ts tests/shared-home-empty-state.dom.test.tsxTest Files 6 passed (6)/Tests 70 passed (70)http://localhost:4461/?mode=calculators(project idclinical-kb:c52ddf65534b): Show all is under the hero; click lands on/calculators/searchwith the 8-calculator catalogue and does not bounce home. The same chip stays on the catalogue and on?q=depression&run=1.npm run verify:pr-local— not run; the focused suite covers the changed routing and chip contracts.npm run verify:ui— not run; phone journey was exercised locally instead of the full Chromium gate.npm run verify:release— not requested.Calculators phone home with Show all chip
Calculators catalogue after Show all
calculators_phone_show_all_to_catalogue.mp4
Risk and rollout
/calculators/searchnow lists the calculator catalogue instead of redirecting home. Differentials keep the no-browse redirect. The chip is a navigation control only; scoring, citations, and answer generation are unchanged./calculators/searchbrowse the existing fixture list. No RAG ranking, retrieval, or answer-generation surfaces are touched.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)The catalogue still presents the same source-cited scoring tools. Scores remain decision-support only and do not replace clinical judgement. Opening the full list from home does not change how a calculator scores, cites, or degrades.
Notes
The visual treatment matches the live Tools home chip: 36px tinted capsule, hairline icon well, 48px phone tap target (
min-h-tap).To show artifacts inline, enable in settings.