Skip to content

Madc2vcf updates - #32

Merged
alex-sandercock merged 6 commits into
Updatesfrom
madc2vcf_updates
May 12, 2025
Merged

Madc2vcf updates#32
alex-sandercock merged 6 commits into
Updatesfrom
madc2vcf_updates

Conversation

@Cristianetaniguti

@CristianetanigutiCristianetaniguti commented May 12, 2025

Copy link
Copy Markdown
Collaborator
  • Change function names: madc2vcf -> madc2vcf_targets ; get_OffTargets -> madc2vcf_all
  • Add function to check if botloci file marker names match with MADC: check_botloci
    • The function also checks the padding of the position notation and try to match adding left zeros to the shortest
  • Update madc2vcf_targets to get the reverse complementary for the REF and ALT bases if marker is in botloci file
  • Expose internal alignment quality filter parameter of madc2vcf_all
  • Remove dependency of fasta db from madc2vcf_all. New Behavior:
    • If fasta db is present
      • If there is no Ref_0001 or Alt_0002 missing in the MADC - nothing happens
      • If there is Ref_0001 or Alt_0002 missing - try to find them in the fasta db, if exists, add, if not, exclude the tag
    • If fasta dp is not present
      • If there is no Ref_0001 or Alt_0002 missing in the MADC - nothing happens
      • If there is Ref_0001 or Alt_0002 missing - exclude the tag
  • bcftools query was used to match VCF REF bases to the reference genome - they are all matching for both functions

@CristianetanigutiCristianetaniguti added bug Something isn't working enhancement New feature or request labels May 12, 2025
@alex-sandercock
alex-sandercock merged commit 5761089 into UpdatesMay 12, 2025
@Cristianetaniguti
Cristianetaniguti deleted the madc2vcf_updates branch May 21, 2025 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Cristianetaniguti@alex-sandercock