Skip to content

update examples - #33

Merged
alex-sandercock merged 4 commits into
developmentfrom
Updates
May 12, 2025
Merged

update examples#33
alex-sandercock merged 4 commits into
developmentfrom
Updates

Conversation

@alex-sandercock

Copy link
Copy Markdown
Collaborator

No description provided.

@alex-sandercockalex-sandercock self-assigned this May 12, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the examples for the madc2vcf_all function. Key changes include:

  • Wrapping the example usage in both Rd and R files with a \donttest block.
  • Increasing the n.cores parameter from 1 to 2 in the examples.
  • Bumping the package version in DESCRIPTION and updating NEWS.md accordingly.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

FileDescription
man/madc2vcf_all.RdUpdated example block: wrapped in \donttest and updated n.cores.
R/madc2vcf_all.RUpdated example comments: wrapped in \donttest and updated n.cores.
NEWS.mdAdded release notes for the updated madc2vcf_all example.
DESCRIPTIONUpdated package version to 0.5.3.

Comment threadman/madc2vcf_all.Rd
\examples{
# Example usage:

\donttest{

CopilotAIMay 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment explaining why the OMP_THREAD_LIMIT is set to 2 in this example to aid user understanding.

Suggested change
\donttest{
\donttest{
# Set the maximum number of threads for OpenMP to 2 to ensure consistent behavior

Copilot uses AI. Check for mistakes.
Comment threadR/madc2vcf_all.R
#' # Example usage:
#'
#' \donttest{
#' Sys.setenv("OMP_THREAD_LIMIT" = 2)

CopilotAIMay 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] It might be helpful to include a short inline note clarifying the purpose of setting the OMP_THREAD_LIMIT environment variable in the example usage.

Suggested change
#' Sys.setenv("OMP_THREAD_LIMIT" = 2)
#' Sys.setenv("OMP_THREAD_LIMIT" = 2) # Limits the number of threads used by OpenMP to match the n.cores parameter

Copilot uses AI. Check for mistakes.
Comment threadNEWS.md

# BIGr 0.5.3

- Updated madc2vcf_all example

CopilotAIMay 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider providing more detail in the release notes about the changes in the madc2vcf_all example for clarity to end users.

Suggested change
- Updated madc2vcf_all example
- Updated madc2vcf_all example to include support for additional filtering options and improved error handling. The example now demonstrates how to use the new parameters for specifying target regions and output formats.

Copilot uses AI. Check for mistakes.
@codecov

codecovBot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (b4830a6) to head (c15f3e0).
Report is 6 commits behind head on development.

Additional details and impacted files
@@ Coverage Diff @@## development #33 +/- ##
============================================
Coverage 85.03% 85.03% ============================================
Files 16 16 Lines 1136 1136 ============================================
Hits 966 966 Misses 170 170 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex-sandercock
alex-sandercock merged commit 9440241 into developmentMay 12, 2025
@alex-sandercock
alex-sandercock deleted the Updates branch May 12, 2025 17:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-sandercock