Skip to content

[BI-2155] Cannot create a new list referencing existing GIDs - #363

Merged
dmeidlin merged 1 commit into
release/0.9.1from
bug/BI-2155
May 30, 2024
Merged

[BI-2155] Cannot create a new list referencing existing GIDs#363
dmeidlin merged 1 commit into
release/0.9.1from
bug/BI-2155

Conversation

@dmeidlin

@dmeidlindmeidlin commented May 30, 2024

Copy link
Copy Markdown
Contributor

Description

Story:BI-2155

BI-2017 inadvertently dropped the germplasmAccessionNumber field from the json string stored in the database for the germplasm import template when the germplasmName field was updated.

A migration was created to add the germplasmAccessionNumber field to the template map.

Dependencies

none

Testing

  1. Import germplasm
  2. Import a new germplasm list that references the GIDs from step 1, but with different names, sources, or methods
  3. Confirm that the import preview shows the names, sources, and methods for the GIDs from step 1, not from step 2.
  4. Complete the import from step 2 and confirm in the germplasm list details table that only germplasm with GIDs from step 1 are present.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actionsgithub-actionsBot added the bug Something isn't working label May 30, 2024
@dmeidlin
dmeidlin requested review from a team, davedrp and mlm483 and removed request for a teamMay 30, 2024 11:53

@mlm483mlm483 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working. 🚀

@dmeidlin
dmeidlin removed the request for review from davedrpMay 30, 2024 17:21
@dmeidlin
dmeidlin merged commit 4e51c9f into release/0.9.1May 30, 2024
@dmeidlin
dmeidlin deleted the bug/BI-2155 branch May 30, 2024 18:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dmeidlin@nickpalladino@mlm483@davedrp