Skip to content

[BI-2017] Change Germplasm Upload to unify with sample submission - #341

Closed
davedrp wants to merge 3 commits into
developfrom
feature/BI-2017
Closed

[BI-2017] Change Germplasm Upload to unify with sample submission#341
davedrp wants to merge 3 commits into
developfrom
feature/BI-2017

Conversation

@davedrp

@davedrpdavedrp commented Mar 20, 2024•
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Description

BI-2017 Change Germplasm Upload to unify with sample submission

Change Germplasm Template column from "Name" to "Germplasm Name"

Dependencies

bi-web: feature/BI-2017 branch

Testing

  1. Download Germplasm Import Template.
  2. Use Template format to import Germplasm.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

dmeidlin
dmeidlin requested changes Apr 3, 2024
View reviewed changes

@dmeidlindmeidlin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment for the front end PR. All tests in GermplasmFileImportTest pass.

@davedrp
davedrp changed the base branch from develop to release/0.9April 10, 2024 17:28
@davedrp
davedrp changed the base branch from release/0.9 to developApril 10, 2024 17:28
@davedrpdavedrp mentioned this pull request Apr 10, 2024
Merged
@davedrpdavedrp closed this Apr 10, 2024
@dmeidlindmeidlin mentioned this pull request May 30, 2024
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmeidlindmeidlindmeidlin approved these changes
@nickpalladinonickpalladinonickpalladino approved these changes

Assignees

@dmeidlindmeidlin

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davedrp@dmeidlin@nickpalladino