Skip to content

[BI-2017] Change Germplasm Upload to unify with sample submission - #367

Closed
davedrp wants to merge 1 commit into
developfrom
feature/BI-2017
Closed

[BI-2017] Change Germplasm Upload to unify with sample submission #367
davedrp wants to merge 1 commit into
developfrom
feature/BI-2017

Conversation

@davedrp

@davedrpdavedrp commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Description

BI-2017 Change Germplasm Upload to unify with sample submission

Change Germplasm Template column from "Name" to "Germplasm Name"

Dependencies

bi-api: feature/BI-2017 branch

Testing

  1. Download Germplasm Import Template.
  2. Use Template format to import Germplasm.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp
davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a teamMarch 20, 2024 14:23

@nickpalladinonickpalladino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops missed the backend PR

@nickpalladino
nickpalladino self-requested a review March 27, 2024 14:55

@dmeidlindmeidlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name changes appear in the germplasm table and import template. When I import
bi_germplasm_import_template_v9.xls there's a runtime error that crashes bi-api:
ERROR i.m.h.s.netty.RoutingInBoundHandler - Unexpected error occurred: it/unimi/dsi/fastutil/ints/IntIterable java.lang.NoClassDefFoundError: it/unimi/dsi/fastutil/ints/IntIterable at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151) at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:821) at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:719) at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:642) at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:600) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) at org.breedinginsight.utilities.FileUtil.parseTableFromJson(FileUtil.java:195) at org.breedinginsight.brapi.v2.dao.impl.ImportMappingDAOImpl.parseBrAPIImportMapping(ImportMappingDAOImpl.java:134) at org.breedinginsight.brapi.v2.dao.impl.ImportMappingDAOImpl.getSystemMappingByName(ImportMappingDAOImpl.java:124) at org.breedinginsight.brapps.importer.services.FileImportService.getSystemMappingByName(FileImportService.java:559) at org.breedinginsight.brapps.importer.controllers.ImportController.getSystemMappings(ImportController.java:200) at org.breedinginsight.brapps.importer.controllers.$ImportControllerDefinition$$exec6.invokeInternal(Unknown Source) at io.micronaut.context.AbstractExecutableMethod.invoke(AbstractExecutableMethod.java:151) at io.micronaut.context.DefaultBeanContext$4.invoke(DefaultBeanContext.java:482) at io.micronaut.web.router.AbstractRouteMatch.execute(AbstractRouteMatch.java:303) at io.micronaut.web.router.RouteMatch.execute(RouteMatch.java:121) at io.micronaut.http.server.netty.RoutingInBoundHandler.emitRouteResponse(RoutingInBoundHandler.java:1502) at io.micronaut.http.server.netty.RoutingInBoundHandler.access$2100(RoutingInBoundHandler.java:151) at io.micronaut.http.server.netty.RoutingInBoundHandler$6$1.request(RoutingInBoundHandler.java:1469) at io.reactivex.internal.operators.flowable.FlowableSwitchMap$SwitchMapInnerSubscriber.onSubscribe(FlowableSwitchMap.java:379) at io.micronaut.http.server.netty.RoutingInBoundHandler$6.doSubscribe(RoutingInBoundHandler.java:1457) at io.micronaut.http.server.netty.RoutingInBoundHandler$6.lambda$subscribe$0(RoutingInBoundHandler.java:1451) at io.micronaut.scheduling.instrument.InvocationInstrumenterWrappedRunnable.run(InvocationInstrumenterWrappedRunnable.java:47) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:830) Caused by: java.lang.ClassNotFoundException: it.unimi.dsi.fastutil.ints.IntIterable at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:602) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)

@mlm483

Copy link
Copy Markdown
Contributor

@davedrp could you please merge this feature branch into release/0.9 instead of develop? We have time to get this and BI-1680 into v0.9, and this PR needs to be merged before BI-1680.

@davedrp
davedrp changed the base branch from develop to release/0.9April 10, 2024 16:21
@davedrp
davedrp changed the base branch from release/0.9 to developApril 10, 2024 16:23
@davedrp
davedrp changed the base branch from develop to release/0.9April 10, 2024 17:22
@davedrp
davedrp changed the base branch from release/0.9 to developApril 10, 2024 17:22
@davedrpdavedrp closed this Apr 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@davedrp@mlm483@dmeidlin@nickpalladino