fix(football-scoreboard): give the possession ball room and let it scale

[ChuckBuilds]

Summary

The possession football was placed a fixed 3px from the down & distance text and guarded only by ball_x_center > 0 — a check that a number had not come out negative, not that the ball fit anywhere in particular. On a 64px-wide panel it landed on the timeout bars; the guard could not see the right-hand edge at all, so home possession pushed it off a narrow panel; and on the adaptive 256×128 card it was drawn at x 262–274 of a 256px card, entirely off the edge.

The ball is now placed around the text rather than the other way round.

Type of change

• Bug fix in an existing plugin

Plugin(s) affected

football-scoreboard

What changed

The ball's size is unchanged — a fixed 7×5 on the classic paths, px()-scaled radii on the adaptive card — and so is the wording beside it. Where it still fits, it lands on the same pixel it always did. Where a row genuinely cannot hold both (a 64×32 leaves ~30px between the timeout bars and the text alone wants 29) the down & distance wins and the ball is omitted, rather than the wording being shortened.

Fixed on all three paths that draw it: football.py's classic scorebug, GameRenderer's classic card (scroll mode), and its adaptive card.

Separately, the adaptive card drew the down & distance in PressStart2P, ~4× wider per character than the 4×6 face. On a 192×48 panel that rendered 3rd & 8 at KC 42 128px wide against the classic layout's 65px; on a 256×128 it reached the full 256px, clipping the line at both ends and leaving nowhere for the ball. That line alone now uses a dedicated ADAPTIVE_LADDER_DETAIL on the compact 4×6 face, both rungs verified crisp (measure_font_crispness == 0.0).

The clock, status band, records and dates are untouched — they keep ADAPTIVE_LADDER_TEXT and the face they had. Every recent and upcoming golden is pixel-identical to main; only the three live cards differ.

With the narrower face the yardage also fits where it previously did not. The long form was gated on display_width > 128 — a proxy for "is there room" that gets a 128×64 wrong, since the string is 65px in the 4×6 face and the free band there is wider. It is now preferred whenever it fits the space the timeout bars and records leave free, the same trade the classic layout already makes via _fit_text.

Shared-code note

ADAPTIVE_LADDER_TEXT and the possession helpers exist only in this plugin's game_renderer.py, so no lineage port is needed (docs/plugin-development/08-shared-sports-code.md). No shared-shape signature changed — that is why the down & distance is fitted inline rather than by adding a parameter to the shared _draw_bottom_center_adaptive.

Test plan

• Safety harness: 24/24 across all eight default sizes × live/recent/upcoming.
• Plugin suite: 26 passed, with the same two pre-existing environment failures as main (test_football_plugin.py wants a tty; test_timezone_resolution.py hits Windows cp1252 on a ✓ — both pass on CI).
• check_module_collisions.py clean.
• Adaptive goldens regenerated; recent/upcoming verified pixel-identical to origin/main.

New regression test: test_possession_ball_has_room.py

671 checks over three render paths × the harness's eight sizes × possession side × four down & distance strings (including the kickoff case) × records on and off. Each case renders twice — once capturing the ball's box, once with it suppressed — asserting the ball is on-panel, is exactly the size it always was, and covers no other element. Team logos are blanked, since the scorebug draws over them deliberately.

It pins the two properties that matter: the ball's size is unchanged, and the down & distance drawn is identical whether possession is home, away or unknown — so the ball can never be paid for out of the wording. Reintroducing a text reservation fails it.

Required for plugin changes

• Bumped version (2.27.0 → 2.27.2), new entry at the top of versions
• class_name / entry_point unchanged
• No config keys changed
• plugins.json regenerated with update_registry.py

Checklist

• Commit message follows CONTRIBUTING.md
• No secrets committed

Notes for reviewer

Rebased onto main after #336, which bumped the version and touched the same renderer.

Version coordination with #339: that PR takes football-scoreboard to 2.27.1, this one to 2.27.2, so they merge in either order without a re-bump. They touch different parts of game_renderer.py — imports there, the detail ladder here.

Known trade-off worth a second opinion: 128×64 and 128×96 now show the yardage but drop the ball. The limiting factor is the records — 10-5 in PressStart2P is 32px per corner, which eats the free band. Moving the records to the compact face would fit both, but that would change text this PR deliberately leaves alone, so I have not.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 15e519fb-0891-4c5e-91b8-97aafd02a036

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}