fix(scoreboards): import datetime, timezone and ZoneInfo in game_renderer

[ChuckBuilds]

Summary

scroll_card.date_format offers "weekday" (documented as weekday "Fri Sep 19") in every scoreboard's config_schema.json, but seven of the eight game_renderer.py copies used datetime, timezone and ZoneInfo without importing any of them. Choosing that option raised NameError, and neither helper's except catches it — _weekday_for catches (ValueError, TypeError), _card_tzinfo catches (KeyError, ValueError, TypeError, OSError) — so it propagated out of the render instead of falling back to the plain date.

Reproduced directly:

>>> GameRenderer(128, 64, {"scroll_card": {"date_format": "weekday"}})._format_game_date("10/12", game)
NameError: name 'datetime' is not defined

hockey-scoreboard already had the imports and rendered the option correctly. The other seven now match it.

Type of change

• Bug fix in an existing plugin

Plugin(s) affected

afl, baseball, basketball, football, lacrosse, nrl, soccer (all -scoreboard).

game_renderer.py is a shared-shape module, so all lineage members are fixed in this PR per docs/plugin-development/08-shared-sports-code.md. baseball needed only timezone and ZoneInfo — it already imported datetime. Hockey is untouched.

Related issues

N/A — found by pyflakes (undefined name) while reviewing a static-analysis report on #337, then traced to a reachable config path.

Why nothing caught it

The render harness and every golden image use the default abbrev format, so the weekday branch never executed. Two lines of imports were missing for as long as the feature has existed and no test touched it.

Test plan

• Safety harness green for all seven: 24/24 each (lacrosse 16/16).
• Each plugin's own suite matches its origin/main baseline exactly, pass for pass and fail for fail — baseline captured by stashing this change, so the pre-existing Windows-environment failures are accounted for rather than assumed.
• check_module_collisions.py clean across 43 plugins.
• Every other repo-level guard unchanged from baseline.

New guard: scripts/test_weekday_date_format.py

Exercises the option itself across all eight copies. Every copy is called game_renderer, so each is loaded under its own module name via importlib.util rather than imported — otherwise whichever landed in sys.modules first would be silently tested eight times. Per plugin it asserts:

• date_format: "weekday" does not raise
• it renders an actual weekday
• the configured timezone is applied — 01:00 UTC on the Tuesday is still Monday in New York, so a Tue result would mean the conversion was skipped or silently fell back to UTC
• a bogus zone name falls back instead of raising
• the default format still works

40 checks, all passing. Stripping the imports from any one plugin fails it with the original NameError. The timezone assertion self-skips where the platform has no tz database (Windows without tzdata), since the renderer correctly falls back to UTC there — an environment limitation, not a defect.

Required for plugin changes

• Bumped version in all seven manifests, new entry at the top of versions
• class_name / entry_point unchanged
• No config keys changed, so no README or schema edits
• plugins.json regenerated with update_registry.py — only the seven latest_version fields changed

Checklist

• Commit message follows CONTRIBUTING.md
• No secrets committed

Notes for reviewer

Rebuilt on main after #336 landed, which bumped all seven versions and touched the same files. Versions here are the post-#336 patch bumps (e.g. football 2.27.0 → 2.27.1).

Version coordination with #337: that PR takes football-scoreboard to 2.27.2, this one to 2.27.1, so they merge in either order without a re-bump. They are otherwise independent and touch different parts of game_renderer.py — imports here, the down & distance ladder there.

The except clauses are deliberately left alone. Once the names resolve, an unusable timezone falls back to UTC rather than raising, which the new guard asserts — so NameError was not masking a needed fallback, it was preventing one.

pyflakes reports one remaining finding in these files, 'freetype' imported but unused, which is pre-existing and looks intentional (an availability probe). Left as is.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7add6f55-df52-4096-b0eb-d3f89a094b45

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}