Skip to content

Add era to CommonParams - #1893

Merged
foriequal0 merged 3 commits into
CodeChain-io:erafrom
foriequal0:feature/era
Nov 26, 2019
Merged

Add era to CommonParams#1893
foriequal0 merged 3 commits into
CodeChain-io:erafrom
foriequal0:feature/era

Conversation

@foriequal0

@foriequal0foriequal0 commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@foriequal0foriequal0 mentioned this pull request Nov 25, 2019
Closed
4 tasks
remagpie
remagpie requested changes Nov 25, 2019
View reviewed changes

@remagpieremagpie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

era should be monotonically increasing.
I think we need a verification logic for ChangeCommonParams checking it.

kseo
kseo reviewed Nov 25, 2019
View reviewed changes
Comment threadjson/src/scheme/params.rs
sgkim126
sgkim126 requested changes Nov 26, 2019
View reviewed changes
Comment threadtypes/src/common_params.rs Outdated
@sgkim126

sgkim126 commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

I cannot find the behavior change in 59e1696.
I think the commit title should be Extract a function to verify a new CommonParams compare to the current params

@foriequal0foriequal0 mentioned this pull request Nov 26, 2019
Merged
@foriequal0

foriequal0 commented Nov 26, 2019

Copy link
Copy Markdown
ContributorAuthor

Tests are quite flaky. They are fine on my machine.

@foriequal0
foriequal0 merged commit f83de3d into CodeChain-io:eraNov 26, 2019
@foriequal0
foriequal0 deleted the feature/era branch November 26, 2019 08:54
This was referenced Dec 4, 2019
Closed
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majectymajectymajecty approved these changes
@sgkim126sgkim126sgkim126 approved these changes
@remagpieremagpieremagpie approved these changes
@kseokseoAwaiting requested review from kseo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@foriequal0@sgkim126@majecty@kseo@remagpie