Skip to content

Read term_common_params from the snapshot - #1895

Merged
foriequal0 merged 4 commits into
CodeChain-io:erafrom
foriequal0:feature/term_common_params
Nov 29, 2019
Merged

Read term_common_params from the snapshot#1895
foriequal0 merged 4 commits into
CodeChain-io:erafrom
foriequal0:feature/term_common_params

Conversation

@foriequal0

@foriequal0foriequal0 commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

Depends on: #1893

@foriequal0foriequal0 changed the title Read term_common_params from the snapshot[WIP] Read term_common_params from the snapshotNov 26, 2019
@foriequal0
foriequal0 marked this pull request as ready for review November 26, 2019 08:58
@foriequal0
foriequal0force-pushed the feature/term_common_params branch from d353f06 to c474f2dCompareNovember 26, 2019 09:13
@foriequal0foriequal0 mentioned this pull request Nov 26, 2019
Closed
4 tasks
@foriequal0foriequal0 changed the title [WIP] Read term_common_params from the snapshotRead term_common_params from the snapshotNov 26, 2019
majecty
majecty requested changes Nov 26, 2019
View reviewed changes
Comment threadcore/src/client/client.rs
remagpie
remagpie reviewed Nov 26, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs
remagpie
remagpie requested changes Nov 26, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs Outdated
remagpie
remagpie reviewed Nov 26, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs Outdated
remagpie
remagpie requested changes Nov 26, 2019
View reviewed changes
Comment threadcore/src/client/client.rs
remagpie
remagpie reviewed Nov 26, 2019
View reviewed changes
Comment threadcore/src/consensus/tendermint/engine.rs Outdated
@remagpieremagpie mentioned this pull request Nov 26, 2019
Merged
@foriequal0
foriequal0force-pushed the feature/term_common_params branch from e103418 to cb64747CompareNovember 27, 2019 05:37
@foriequal0
foriequal0force-pushed the feature/term_common_params branch 4 times, most recently from 40666c6 to 0584ff0CompareNovember 27, 2019 11:39
sgkim126
sgkim126 reviewed Nov 27, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs
sgkim126
sgkim126 reviewed Nov 27, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs
self.term_params.as_ref()
}

pub fn snapshot_term_params(&mut self) {

@sgkim126sgkim126Nov 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a more proper name than snapshot_term_params.

@foriequal0foriequal0Nov 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know snapshot is a little bit confusing. It collides with the name of the snapshot sync feature and it is awkward to use it as a verb to me, but I can't think of a better one. Can you suggest a good one? How about freeze_?

@foriequal0foriequal0Nov 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind if we change the name later? @remagpie is dependant on this PR.

@remagpieremagpieNov 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name is not a big deal in my work. You can change it now if you want.

sgkim126
sgkim126 reviewed Nov 27, 2019
View reviewed changes
Comment threadstate/src/item/metadata.rs Outdated
@foriequal0
foriequal0force-pushed the feature/term_common_params branch from acd786a to 60a235bCompareNovember 27, 2019 16:34
remagpie
remagpie reviewed Nov 28, 2019
View reviewed changes
Comment threadcore/src/consensus/tendermint/engine.rs
@remagpieremagpie mentioned this pull request Nov 28, 2019
Merged
@foriequal0foriequal0 mentioned this pull request Nov 28, 2019
Merged
@foriequal0
foriequal0force-pushed the feature/term_common_params branch from 60a235b to cd9a669CompareNovember 28, 2019 08:13
@foriequal0
foriequal0 merged commit 237b7f4 into CodeChain-io:eraNov 29, 2019
@foriequal0
foriequal0 deleted the feature/term_common_params branch November 29, 2019 01:58
This was referenced Dec 4, 2019
Closed
Merged
@remagpieremagpie mentioned this pull request Dec 20, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remagpieremagpieremagpie approved these changes
@majectymajectymajecty approved these changes
@sgkim126sgkim126sgkim126 approved these changes

Assignees

No one assigned

Labels

consensus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@foriequal0@majecty@sgkim126@remagpie