Add metadata to dlc region connections - #92
Merged
Conversation
CodeTriangle
commented
Jul 30, 2026
OwnerAuthor
Oh. Forgot this earlier: resolves #83. |
CodeTriangle
commented
Jul 30, 2026
OwnerAuthor
CRAP |
CodeTriangle
commented
Jul 30, 2026
OwnerAuthor
LEAVE ME ALONE BOT |
CodeTriangle
commented
Jul 30, 2026
OwnerAuthor
WHATEVER YOU'RE ABOUT TO SAY, DON'T |
There was a problem hiding this comment.
Pull request overview
Adds metadata.dlc: true to DLC region connection entries via the DLC input data’s _global rules, enabling downstream consumers (e.g., Archipelago integration work referenced by CodeTriangle/Archipelago#26) to identify DLC connections distinctly from base-game connections.
Changes:
- Extend
data/in/dlc/master.json_globalrules to applymetadata.dlc: trueto all entries underregions.*.connections.*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodeTriangle
commented
Jul 30, 2026
OwnerAuthor
BURN IN HELL, BOT |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support CodeTriangle/Archipelago#26.