Skip to content

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library - #554

Open
Vitalii-code wants to merge 17 commits into
CodeYourFuture:mainfrom
Vitalii-code:feature/book-library
Open

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library#554
Vitalii-code wants to merge 17 commits into
CodeYourFuture:mainfrom
Vitalii-code:feature/book-library

Conversation

@Vitalii-code

@Vitalii-codeVitalii-code commented Aug 14, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed the bugs

@Vitalii-codeVitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2026
cjyuan
cjyuan reviewed Aug 14, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 14, 2026
@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 15, 2026
@cjyuan

cjyuan commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Could you go through the guide again and make all possible improvements?

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 15, 2026
@Vitalii-code
apply suggestions fromhttps://validator.w3.org
d9215d8
@Vitalii-code
Add html validation
b9b0ab3
@Vitalii-code
Change page count to Integer
7f4447e
@Vitalii-code
Trim input text
a1f2494
@Vitalii-code
Use textContent instead of innerHTML
31bfa27
@Vitalii-code
Make render() more efficient
6a4344b
@Vitalii-code
Make variables more consistent
7cd2449
@Vitalii-code
use const instead of let for non-reassigned variables
c81cdb8
@Vitalii-code
refactor: clean up script.js per code review feedback
03672e3
- Rename DOM reference variables to signal element type (titleInput, authorInput, pagesInput, checkInput)
- Change myLibrary from let to const
- Trim title/author before storing, not just validating
- Reject non-numeric and non-positive page counts
- Replace blocking window.alert() with non-blocking showMessage() banner for delete confirmation
@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 16, 2026
cjyuan
cjyuan reviewed Aug 17, 2026
View reviewed changes
Comment threaddebugging/book-library/index.html Outdated
Comment threaddebugging/book-library/script.js Outdated
Comment threaddebugging/book-library/script.js
Comment threaddebugging/book-library/script.js Outdated
@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026
@Vitalii-code

Vitalii-code commented Aug 17, 2026

Copy link
Copy Markdown
Author

Ok, should be good now

@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2026
cjyuan
cjyuan reviewed Aug 17, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment threaddebugging/book-library/script.js
Comment on lines +49 to +52
pagesInput.value.trim() == "" ||
Number.isNaN(pageCount) ||
!Number.isInteger(pageCount) ||
pageCount <= 0

@cjyuancjyuanAug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Two of these checks are optional (redundant).

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026
@Vitalii-codeVitalii-code mentioned this pull request Aug 18, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vitalii-code@cjyuan